[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003371: marked as done (libavif: reproducible-builds: BuildId differences triggered by RPATH)

Your message dated Thu, 28 Jul 2022 19:51:03 +0000
with message-id <E1oH9XD-000FXg-8y@fasolo.debian.org>
and subject line Bug#1003371: fixed in libavif 0.10.1-2
has caused the Debian Bug report #1003371,
regarding libavif: reproducible-builds: BuildId differences triggered by RPATH
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1003371: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003371
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libavif
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libavif.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

Alternately, updating the packaging to debhelper compat level 14 should
fix this, although it is currently an experimental compat level.


With this patch applied, libavif should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining libavif!


live well,
  vagrant

From 710784e88a6ac4e469b236bf820779856cfd97be Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Jan 2022 02:10:45 +0000
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 71386fc..29bf3cc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -32,5 +32,6 @@ override_dh_auto_configure:
 	    -DAVIF_BUILD_APPS=ON \
 	    -DAVIF_CODEC_DAV1D=ON \
 	    -DAVIF_CODEC_AOM=ON \
+	    -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON \
 	    $(LIBGAV1_FLAG) \
 	    -DAVIF_BUILD_GDK_PIXBUF=ON
-- 
2.34.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: libavif
Source-Version: 0.10.1-2
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
libavif, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1003371@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated libavif package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 28 Jul 2022 14:31:47 -0400
Source: libavif
Architecture: source
Version: 0.10.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 1003371
Changes:
 libavif (0.10.1-2) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * Trim trailing whitespace.
   * Remove unused license definitions for Expat.
 .
   [ Boyuan Yang ]
   * Rebuild against libgav1 (>> 0.18).
   * debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
     dh_auto_configure override. (Closes: #1003371)
Checksums-Sha1:
 942b50712cdb53011e15934664dfdc8028f9dbe7 2460 libavif_0.10.1-2.dsc
 f11d78c69d0f3af63549ba7e2fbf7f720dcc16b9 2085698 libavif_0.10.1.orig.tar.gz
 332b71732d6eebbd83cb420ce92e78b151e8d408 5768 libavif_0.10.1-2.debian.tar.xz
 b13d0f5faf94d9e2ddd20f305bb342f8e4ee2ac7 11063 libavif_0.10.1-2_amd64.buildinfo
Checksums-Sha256:
 ec868d7ec7d305e0c05c819dbeaed97a495e736ee0ef3262fa7c55177a1ef41d 2460 libavif_0.10.1-2.dsc
 66e82854ceb84a3e542bc140a343bc90e56c68f3ecb4fff63e636c136ed9a05e 2085698 libavif_0.10.1.orig.tar.gz
 c947d938c2715d07bf11be006350f773e0515acbc8c40bbffcc19e43a53a459d 5768 libavif_0.10.1-2.debian.tar.xz
 1f7063785afbbcfc1b3a6b6beb1d8269f7d24297264c629be57cf557ba592157 11063 libavif_0.10.1-2_amd64.buildinfo
Files:
 cdda712fcd853ca223f98e7a54a945b2 2460 libs optional libavif_0.10.1-2.dsc
 03db8c35534f565d98b24800ca105cf3 2085698 libs optional libavif_0.10.1.orig.tar.gz
 971eae55936b3a892f02d711fd8fed22 5768 libs optional libavif_0.10.1-2.debian.tar.xz
 c1d885ed9a635ab82290c69bfb3b553c 11063 libs optional libavif_0.10.1-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmLi1qcACgkQwpPntGGC
Ws52LxAAiSE2vuo9Y8mJcZ5iVJ0ioW0Kyr4/5mwB3U/SrPqqSKe5A0Xqbq0BVK4S
OJb+MD/T/0xJ4A5IBa3kJIHvn5f0BxeMjGVmnqQ1WA+SzKLuUpGKMa7ZpFoPnq4Q
cYn0KCE/wmrfkIIPwbNE4F1ELmxpC1gaUkgIHPUozTTMe7MPCQd9feC9XMeQJZL3
JKjDo0xq+MxSa/TZH3N0dUaQT6DnPq7wU3mMcXX2KyWAbSwZfYR3ITArr1wrfyG6
l81joQA1Wgv6pHubRiJC5afsJXnbYFMI/PUEpNxoww1cvUDa3w/IoEue1m7epvz+
iSijt+d382hDZyztCWr3n9guI+y9qjD3bvmofvZgmUBIqsCk5aGX4RsUnsjCmdeb
5k+Oh9GTBEgmmcuiIqaShhVGrEqKlzFSLKp7AI8zGd9HCsx9UVV/hEYH0DXp0dOI
CYTDybf3WjYJnMhQH9PD8UkmW5CXu3p1sEuoMu/cUq+QV7ZV+2PthTEByNps95mX
Qfx5lLL3FSy7TKV33hRYYBjDXio3x2/XTp5hkH/IvcechTSipQbxpfgJFcCe+yQ+
RtPyys56+Uis9iwYHXZkr0h3hgRyjixX0G6FY0sZWbSnzoT4tF7xzXvuzKQ1O6aN
IlhPdnkGOkWP33g33vBCxPHd8MaMWdNMfEJ8dj7tBUhWp+2WByk=
=5wT/
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: