Bug#1014542: FTBFS with fmtlib 9.0.0

[Shengjing Zhu <zhsj@debian.org>]

Source: kodi
Version: 2:19.4+dfsg2-2
Severity: important
Forwarded: https://github.com/xbmc/xbmc/pull/21649
X-Debbugs-Cc: zhsj@debian.org


Hi,

I have uploaded fmtlib 9.0.0 to experimental. During rebuild the reverse
dependencies, your package FTBFS.

Some relevant logs:

In file included from /usr/include/fmt/format.h:48,
                 from /<<PKGBUILDDIR>>/xbmc/utils/StringUtils.h:34,
                 from /<<PKGBUILDDIR>>/xbmc/windowing/X11/WinSystemX11.cpp:25:
/usr/include/fmt/core.h: In instantiation of ‘constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_value(T&&) [with Context = fmt::v9::basic_format_context<fmt:
:v9::appender, char>; T = unsigned char*&]’:
/usr/include/fmt/core.h:1753:29:   required from ‘constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_arg(T&&) [with bool IS_PACKED = true; Context = fmt::v9::
basic_format_context<fmt::v9::appender, char>; fmt::v9::detail::type <anonymous> = fmt::v9::detail::type::custom_type; T = unsigned char*&; typename std::enable_if<IS_PACK
ED, int>::type <anonymous> = 0]’
/usr/include/fmt/core.h:1877:77:   required from ‘constexpr fmt::v9::format_arg_store<Context, Args>::format_arg_store(T&& ...) [with T = {unsigned char*&}; Context = fmt:
:v9::basic_format_context<fmt::v9::appender, char>; Args = {unsigned char*}]’
/usr/include/fmt/core.h:1894:38:   required from ‘constexpr fmt::v9::format_arg_store<Context, typename std::remove_cv<typename std::remove_reference<Args>::type>::type ..
.> fmt::v9::make_format_args(Args&& ...) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {unsigned char*&}]’
/usr/include/fmt/core.h:3163:44:   required from ‘std::string fmt::v9::format(fmt::v9::format_string<T ...>, T&& ...) [with T = {unsigned char*&}; std::string = std::__cxx
11::basic_string<char>; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, unsigned char*&>]’
/<<PKGBUILDDIR>>/xbmc/utils/StringUtils.h:91:32:   required from ‘static std::string StringUtils::Format(const string&, Args&& ...) [with Args = {unsigned char*&}; std::st
ring = std::__cxx11::basic_string<char>]’
/<<PKGBUILDDIR>>/xbmc/utils/log.h:181:41:   required from ‘void CLog::FormatAndLogInternal(spdlog::level::level_enum, const Char*, Args&& ...) [with Char = char; Args = {u
nsigned char*&}]’
/<<PKGBUILDDIR>>/xbmc/utils/log.h:83:39:   required from ‘static void CLog::Log(spdlog::level::level_enum, const Char*, Args&& ...) [with Char = char; Args = {unsigned cha
r*&}]’
/<<PKGBUILDDIR>>/xbmc/utils/log.h:68:8:   required from ‘static void CLog::Log(int, const Char*, Args&& ...) [with Char = char; Args = {unsigned char*&}]’
/<<PKGBUILDDIR>>/xbmc/windowing/X11/WinSystemX11.cpp:1041:14:   required from here
/usr/include/fmt/core.h:1727:17: error: static assertion failed: Formatting of non-void pointers is disallowed.
 1727 |   static_assert(formattable_pointer,
      |                 ^~~~~~~~~~~~~~~~~~~

I think upstream is already working on this, ref https://github.com/xbmc/xbmc/pull/21649
Please backport it when it has been merged.