[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945901: marked as done (zynaddsubfx FTCBFS: misdetects fistpl instruction using wrong assembler)

Your message dated Wed, 04 May 2022 19:37:18 +0000
with message-id <E1nmKoI-000Dpf-4s@fasolo.debian.org>
and subject line Bug#945901: fixed in zynaddsubfx 3.0.6-1
has caused the Debian Bug report #945901,
regarding zynaddsubfx FTCBFS: misdetects fistpl instruction using wrong assembler
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
945901: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945901
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: zynaddsubfx
Version: 3.0.5-2
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

zynaddsubfx fails to cross build from source, because it tries to use
the fistpl assembler instruction on non-x86 and that makes compilation
fail. The cause is misdetection of the availability of the instruction.
zynaddsubfx checks for it by summoning "as", which is the right
assembler on unix for native compilation. When a user supplies a C++
compiler, this badly fails as is happening during cross compilation.

The attached patch changes the check to use try_compile, which uses the
very same compiler as is used for compiling the sources. That makes the
check reliable. Please consider applying it.

Please note that this patch won't make zynaddsubfx cross buildable. It
still runs some host arch tool much later during build. I haven't found
a solution for that. Please close this bug when just fixing the asm
check though. It is an incremental improvement that also helps other
platforms and distributions.

Helmut

--- zynaddsubfx-3.0.5.orig/src/CMakeLists.txt
+++ zynaddsubfx-3.0.5/src/CMakeLists.txt
@@ -63,9 +63,7 @@
 set(CMAKE_REQUIRED_FLAGS "")
 
 
-execute_process(COMMAND echo fistpl 0
-                COMMAND as -
-                ERROR_VARIABLE AVOID_ASM)
+try_compile(USE_ASM ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/check_asm.cpp)
 
 ######### Settings ###########
 # NOTE: These cache variables should normally not be changed in this
@@ -316,7 +314,7 @@
     add_definitions(--system-header-prefix="FL/")
 endif()
 
-if(NOT AVOID_ASM)
+if(USE_ASM)
 	message(STATUS "Compiling with x86 opcode support")
     add_definitions(-DASM_F2I_YES)
 endif()
--- /dev/null
+++ zynaddsubfx-3.0.5/src/check_asm.cpp
@@ -0,0 +1,5 @@
+int main()
+{
+	__asm__ __volatile__("fistpl 0");
+	return 0;
+}

--- End Message ---
--- Begin Message --- 
Source: zynaddsubfx
Source-Version: 3.0.6-1
Done: Dennis Braun <d_braun@kabelmail.de>

We believe that the bug you reported is fixed in the latest version of
zynaddsubfx, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 945901@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <d_braun@kabelmail.de> (supplier of updated zynaddsubfx package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 04 May 2022 21:16:08 +0200
Source: zynaddsubfx
Architecture: source
Version: 3.0.6-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <d_braun@kabelmail.de>
Closes: 945901
Changes:
 zynaddsubfx (3.0.6-1) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Bump Standards-Version to 4.4.1
 .
   [ Olivier Humbert ]
   * Update copyright (http -> https)
   * Update copyright (bump myself to 2019)
 .
   [ Dennis Braun ]
   * New upstream version 3.0.6 (Closes: #945901)
   * Refresh patchset
   * Bump Standards-Version to 4.6.0
   * Bump dh-compat to 13
   * Add me as uploader
   * d/copyright: Add new file entries, add missing licenses, update years
   * Remove obsolete files: d/dirs and d/source/local-options
   * Update d/*.lintian-overrides
   * d/rules: Remove unnecessary linker flags
   * Bump d/watch version
Checksums-Sha1:
 ef28da12518e11d4439d9f484b40f47e29c9ffe4 2600 zynaddsubfx_3.0.6-1.dsc
 69834c9a7ab357a7ff93e764ba45e1db25ce8cc1 10001014 zynaddsubfx_3.0.6.orig.tar.bz2
 6f7f2faaa7614498d80055968d1197dbc473760f 10884 zynaddsubfx_3.0.6-1.debian.tar.xz
Checksums-Sha256:
 00bbee57964b7930219fd554e6eb9e29b9a7391189f62a01b8054fdb6545ba5b 2600 zynaddsubfx_3.0.6-1.dsc
 cbd160778f6cf147f9b0487719edc5197a1404f46d7c7bfd89e153f0d8ce71ae 10001014 zynaddsubfx_3.0.6.orig.tar.bz2
 d77a66a71838fb387f8d84d9e3e883e209d656272a47243b7199fb4d6214b5e8 10884 zynaddsubfx_3.0.6-1.debian.tar.xz
Files:
 8d3b362dade113768694c24de9d26d0e 2600 sound optional zynaddsubfx_3.0.6-1.dsc
 62b6a152f941d76a92797add760b3de9 10001014 sound optional zynaddsubfx_3.0.6.orig.tar.bz2
 a86fb2f533d9ba8fe3fa814ddefc9cf9 10884 sound optional zynaddsubfx_3.0.6-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAmJy0kgACgkQafL8UW6n
GZNX/BAAgeE3vHDW2iYiDT01KStj9WDHc7JEKO9kUnCGpz5EAjC9DunGl/tG3ZTQ
13lO5Pni2togct0if0JdWQ2gAGPZJQD4sNRH81qkFfNcD08yZpMeLPdm2y+/DYnv
ffwbHriotImRMBzChtwNROyAKFW//5JUTWOAmlWV63sRRQVHRnbtnySKW4QH8aFT
FpzSqFTQXQ4cHJCl2W55lf9SI+S7+rQNWsSUjUOOiuSlX7iebotNGFIVQY8/AVk5
jyhiwXgveMy2hR+BjaFU4PU8E6kMoI5iZ29LMJZcVIEIsclb+yjW7d/FMgVdg7yr
BqCREG2pcxfPR8f4CsIP+MRnmBrDTBr1cujp5vYLt6wLIUe2WRSGJVQEfG8zklHY
49QVOgqyjjIC5XtdQeoKcQp+2mStnkXW0HQjUcHKfJtAAwBP4ZOicUvsplCueMLb
tNCo2EHOG0+xp7Vp24BoOrwJmLm3mzhY8B6HNkRh1CdOAJ26DIJS5FsD7CVF68hT
YXdB+Sd42LQ4zjMeyOHS3G6dtfXsDzLyCr/LTz6UVX42PuPa+wxaGzyikoBqdLAj
ooZvC2RKdSMiTKYs2N3TU8PMdDyEdU3EVU0K+ZKdzT5oWx0VlIuA4Jksq4sLFT5S
WJ85HwEYjHAJEzzs8r0vI+DdcShSCd4VA2b+/70SepkUyrJSsV4=
=+T0W
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: