[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985187: ffmpeg: reproducible builds: Embeds build path in binaries generated with cl2c



On 2021-08-08, Sebastian Ramacher wrote:
> On 2021-03-13 20:05:47 -0800, Vagrant Cascadian wrote:
>> Source: ffmpeg
>> Severity: normal
>> Tags: patch
>> User: reproducible-builds@lists.alioth.debian.org
>> Usertags: buildpath
>> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
>> 
>> The build path is embedded in various files generated with tools/cl2c:
>> 
>>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/ffmpeg.html
>> 
>>   avgblur.o (shipped in libavfilter.a)
>> 
>>   #line·1·"/build/1st/ffmpeg-4.3.2/libavfilter/opencl/avgblur.cl"
>>   vs.
>>   #line·1·"/build/2/ffmpeg-4.3.2/2nd/libavfilter/opencl/avgblur.cl"
>> 
>> 
>> The attached patch fixes this by patching tools/cl2c to use a basename
>> in the generated file rather than the full path.
>> 
>> 
>> It builds fine with this patch applied, but someone more familiar with
>> ffmpeg should ensure ffmpeg still functions correctly with the patch
>> applied.
>
> As this patch touches upstream's build system, please submit it
> upstream:
>
> https://ffmpeg.org/developer.html#Contributing

Did so, haven't really heard anything back:

  https://patchwork.ffmpeg.org/project/ffmpeg/patch/87sfwyotmg.fsf@yucca/

Any suggestions?

live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


Reply to: