Bug#1022186: sonivox -- does not honor the nocheck profile while building
Source: sonivox
Version: 3.6.11-1
Severity: important
Tags: patch
X-Debbugs-Cc: snd@y0o.de
Hi Dennis,
The CMakeLists.txt has BUILD_TESTING set to ON by default and
the tests are then forcefully run even when a nocheck opt is
being passed.
This also breaks cross builds, and this should be taken care
of in d/rules.
I have attached a patch, please consider merging.
Thanks!
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (990, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.18.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
>From ee2eedcca81e36db113d2711328342ada166b18a Mon Sep 17 00:00:00 2001
From: Nilesh Patra <nilesh@debian.org>
Date: Fri, 21 Oct 2022 20:54:30 +0530
Subject: [PATCH] Respect nocheck profile when passed in buildsystem
---
debian/control | 2 +-
debian/rules | 7 +++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 2596f20..999f5dc 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Uploaders: Dennis Braun <d_braun@kabelmail.de>
Build-Depends:
debhelper-compat (= 13),
cmake,
- libgtest-dev
+ libgtest-dev <!nocheck>
Homepage: https://github.com/pedrolcl/sonivox
Vcs-Browser: https://salsa.debian.org/multimedia-team/sonivox
Vcs-Git: https://salsa.debian.org/multimedia-team/sonivox.git
diff --git a/debian/rules b/debian/rules
index d8309f6..8de3a79 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,3 +4,10 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
%:
dh $@
+
+override_dh_auto_configure:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+ dh_auto_configure
+else
+ dh_auto_configure -- -DBUILD_TESTING=OFF
+endif
--
2.35.1
Reply to: