--- Begin Message ---
Package: openshot-qt
Version: 2.6.1+dfsg1-2
Severity: important
Tags: patch upstream
When adding the chroma key effect filter in openshot and trying to change the
key color from black, by double-clicking on the color, the color picker fails
to open, rendering the whole effect useless.
Traceback (most recent call last):
File "/usr/lib/python3/dist-
packages/openshot_qt/windows/views/properties_tableview.py", line 346, in
doubleClickedCB
currentColor = QColor(red, green, blue)
TypeError: arguments did not match any overloaded call:
QColor(Qt.GlobalColor): argument 1 has unexpected type 'float'
QColor(int): argument 1 has unexpected type 'float'
QColor(QRgba64): argument 1 has unexpected type 'float'
QColor(Any): too many arguments
QColor(): too many arguments
QColor(int, int, int, alpha: int = 255): argument 1 has unexpected type
'float'
QColor(str): argument 1 has unexpected type 'float'
QColor(Union[QColor, Qt.GlobalColor, QGradient]): argument 1 has unexpected
type 'float'
INFO main_window: Prompt user to save project
Upstream has indeed patched the line in question in March 2022 in a still
unreleased version in commit:
https://github.com/OpenShot/openshot-
qt/commit/be9a9b9faa62c66678cec4da89d00cbcc28748d8
I have verified that the patch applies cleanly to the released version of
openshot and fixes the issue at hand (the color picker opens and works).
I propose to cherry pick above upstream patch into the version that is
currently in bookworm as the chroma key effect is effectively broken in
bookworm and I don't think a new release is imminent.
I will propose a MR into the Debian packaging repo that includes this patch
soon.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.19.0-1-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages openshot-qt depends on:
ii fonts-cantarell 0.303.1-1
ii libjs-jquery 3.6.1+dfsg+~3.5.14-1
ii libjs-jquery-ui 1.13.2+dfsg-1
ii python3 3.10.6-1
ii python3-openshot 0.2.7+dfsg1-4
ii python3-pkg-resources 65.3.0-1.1
ii python3-pyqt5 5.15.7+dfsg-1+b1
ii python3-pyqt5.qtsvg 5.15.7+dfsg-1+b1
ii python3-pyqt5.qtwebkit 5.15.7+dfsg-1+b1
ii python3-requests 2.27.1+dfsg-1
ii python3-zmq 22.3.0-1+b2
Versions of packages openshot-qt recommends:
pn blender <none>
ii inkscape 1.2.1+ds-1+b1
Versions of packages openshot-qt suggests:
pn openshot-qt-doc <none>
-- no debconf information
>From be9a9b9faa62c66678cec4da89d00cbcc28748d8 Mon Sep 17 00:00:00 2001
From: Richard Newsham <richard@simperl.com>
Date: Tue, 22 Mar 2022 07:34:02 +0000
Subject: [PATCH] Properties: Ensure QColor() is passed int args
---
src/windows/views/properties_tableview.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/windows/views/properties_tableview.py b/src/windows/views/properties_tableview.py
index fdaa7ee2..6d05b7dd 100644
--- a/src/windows/views/properties_tableview.py
+++ b/src/windows/views/properties_tableview.py
@@ -343,7 +343,7 @@ class PropertiesTableView(QTableView):
blue = cur_property[1]["blue"]["value"]
# Show color dialog
- currentColor = QColor(red, green, blue)
+ currentColor = QColor(int(red), int(green), int(blue))
log.debug("Launching ColorPicker for %s", currentColor.name())
ColorPicker(
currentColor, parent=self, title=_("Select a Color"),
--
2.37.2
--- End Message ---
--- Begin Message ---
Source: openshot-qt
Source-Version: 2.6.1+dfsg1-3
Done: Sebastian Spaeth <Sebastian@SSpaeth.de>
We believe that the bug you reported is fixed in the latest version of
openshot-qt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1021119@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Spaeth <Sebastian@SSpaeth.de> (supplier of updated openshot-qt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 02 Oct 2022 16:19:41 +0200
Source: openshot-qt
Architecture: source
Version: 2.6.1+dfsg1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sebastian Spaeth <Sebastian@SSpaeth.de>
Closes: 1021119
Changes:
openshot-qt (2.6.1+dfsg1-3) unstable; urgency=medium
.
* Team upload.
* debian/patches: fix crash when selecting color picker (Closes: #1021119)
Checksums-Sha1:
7782c4c3299da8a606b71ab8bfeb0c82622d00df 2208 openshot-qt_2.6.1+dfsg1-3.dsc
fd51a9e944e21d0289d3e0eeb2d26598f6317ddd 227888 openshot-qt_2.6.1+dfsg1-3.debian.tar.xz
5bbee44712c278af9eb8f1fc6891462f44527b8a 9650 openshot-qt_2.6.1+dfsg1-3_source.buildinfo
Checksums-Sha256:
0d1cbb1bf73ff6e44029027b196b339969b27bd6eb1b912e6c2773221da06853 2208 openshot-qt_2.6.1+dfsg1-3.dsc
e798a38bffbd6973a098d0d8fc38c116cfdd6a7ba3f5d07616ad5331288701c2 227888 openshot-qt_2.6.1+dfsg1-3.debian.tar.xz
812d91728b1ee44e0f55eac4fd4ed8f886c5b34ac0ccfa9038ef40473d523bb1 9650 openshot-qt_2.6.1+dfsg1-3_source.buildinfo
Files:
2b0bab50af57886a291510c740544416 2208 video optional openshot-qt_2.6.1+dfsg1-3.dsc
2b4cc8e5d3ad4b80ee16f28147797ffb 227888 video optional openshot-qt_2.6.1+dfsg1-3.debian.tar.xz
b78ebce06b0490fd90fb765718ee1f3f 9650 video optional openshot-qt_2.6.1+dfsg1-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAmM5o4cACgkQW//cwljm
lDMttw/+KBz4vvt1Bcegmey5QRFOWz/6HGedxTxlbeWNisMGUx8+mLit/2c0/rJe
+q8Ds2Ltp8hNmju6zoE/o8rwdCKRXhE66ICW50/FimqfOFXRT6DP/iCixvADIrJb
vGo70dg4306Fs5qqArx4OKhsOfhXXBgUM9qLmm9KhGg8+gmMs9J7vPSGYJIK6p0L
6szz3igXWMM6zrACmMRu/GlTauOMP2fBqPPnVF9FjzQGlFKXBGMEgVb31rGbfKKT
XAvSKTLyVwh8UlJrZvevEzRVCv9NOi3pHCRTTOrJ9PG2ZhsvpRjVrF606tWmxGfx
QBwdcFAyWVLKVwayPA0DLQombo8jYC/ofKSwF9+d3iHJ8r2vmrWTDRBjLh8doJkx
MoyXV/ceqFv9jTk0fC/u0hgtkYEH4a2SvLgtssvy7wrRaKZLAYTDejCgm2Kiq1h9
lBArRd/StbQ4XshkOVYqppCLNDWkZ05mv+7zfuU8MrZZsXVhXyKgHcKoAxLVbQEb
d/QWDfZqrBXcslyPr/96oIYxEake3lEi5UTrC22XOcdc4Pfhm3jAYWxzeZ5UkOOx
AHP87LdcJzGjhkskAMbyUMeA8qpsCkIvNPsLgQT0vGrKnGSG6pCiOTPvI0qRSyFW
MsX/SH6bKSlsiZmSBHmmWh7sV7RA5xfQ7O5YKpvWv/nYSr8u6ck=
=AB3F
-----END PGP SIGNATURE-----
--- End Message ---