Bug#998779: bs1770gain: bashism in configure script
[Andrej Shadura]
> Your package uses configure script with bash features not present in
> POSIX without explicitly declaring the need to bash shell; this
> currently works as configure scripts select bash, but when dash enables
> LINENO support, your configure script will start failing:
Can you confirm that this patch solve the problem. It seem to work for
me:
diff --git a/configure.ac b/configure.ac
index 411da35..1a99ae5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -132,7 +132,7 @@ if test "x$ffmpeg" != "xno"; then # [
AC_CHECK_LIB(avfilter, avfilter_version, [ffmpeg=yes LIBS="${LIBS} -lavfilter"], ffmpeg=no),
ffmpeg=no)
fi # ]
-if test "x$ffmpeg" == "xno" ; then # [
+if test "x$ffmpeg" = "xno" ; then # [
AC_MSG_ERROR([FFmpeg not found])
fi # ]
# test for FFmpeg ]
@@ -312,7 +312,7 @@ if test "x$dynload" = "xyes"; then # [
AC_CHECK_LIB(dl, dlopen, [dl=yes LIBS="${LIBS} -ldl"], dl=no),
dl=no)
fi # ]
- if test "x$dl" == "xno" ; then # [
+ if test "x$dl" = "xno" ; then # [
AC_MSG_ERROR([libdl not found])
fi # ]
fi # ]
@@ -373,7 +373,7 @@ else # ] [
AC_CHECK_HEADER(libproc.h, AC_CHECK_LIB(proc, proc_pidpath,
[proc=yes LIBS="${LIBS} -lproc"], proc=no), proc=no)
- if test "x$proc" == "xno" ; then # [
+ if test "x$proc" = "xno" ; then # [
AC_MSG_ERROR([libproc not found])
else # ] [
AC_DEFINE([HAVE_LIBPROC], [1], [Define to 1 if you have libproc.])
@@ -390,7 +390,7 @@ else # ] [
AC_CHECK_HEADER(pthread.h,
AC_CHECK_LIB(pthread, pthread_create, [pthread=yes LIBS="${LIBS} -pthread"], pthread=no),
pthread=no)
- if test "x$pthread" == "xno" ; then # [
+ if test "x$pthread" = "xno" ; then # [
AC_MSG_NOTICE([*******************************************************************])
AC_MSG_NOTICE([* pthread not found. *])
AC_MSG_NOTICE([* bs10gain will be build without support for parallel processing. *])
CC to upstream.
--
Happy hacking
Petter Reinholdtsen
Reply to: