[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1012524: libass: PGP signature and i386 assembly



Source: libass
Version: 1:0.16.0-1
Severity: minor

Hi!

I noticed 7a4ee5d47246b80de8bb16ee75faf65bd9cd91b5 recently added the PGP 
key used to sign the last release for future verification. However, as the
0.16.0 release notes and the MAINTAINERS file note, future releases may
also be signed with a few other keys listed in the MAINTAINERS file.

To my understanding something like the following will allow uscan to match 
with any of the authorised keys (alternatively fetch from a keyserver by 
IDs as found in MAINTAINERS):

  alias gpg_t='gpg --no-default-keyring --keyring /tmp/tmp.keys'
  curl https://github.com/astiob.gpg | gpg_t --import -
  curl https://github.com/TheOneric.gpg | gpg_t --import -
  curl https://github.com/rcombs.gpg | gpg_t --import -
  gpg_t --export --export-options export-minimal --armor > debian/upstream/signing-key.asc
  # To verify which keys are included
  gpg --list-packets debian/upstream/signing-key.asc


While updating to 0.16.0 --with-pic was also added for i386 assembly.
However, it appears the nasm dependency is still limited to any-amd64,
after it was in the past[1] removed from i386 due to being not PIC.
The build log[2] confirms that no assembly is built on i386.
Can this be reenabled now that PIC assembly is supported?

Something to take note of is that previously assembly was enabled also for
kfreebsd-i386. Since then, we changed[3] the 32bit assembly configuration 
for BSD systems upstream to fix an issue with regular FreeBSD.
If it truly worked before on kfreebsd-i386 (other than non-PIC being at
odds with the guidelines), then this change may inadvertently have broken 
kfreebsd-i386.
I tried to test it, but the old kfreebsd-i386 installer I found always 
crashes or gets stuck early on in my VM and I wasn't able to set up a 
chroot or multiarch from a kfreebsd-amd64 host either. I can however 
confirm that on kfreebsd-64 the assembly works as intended.


Cheers

Oneric


[1]: https://salsa.debian.org/multimedia-team/libass/-/commit/d9eae1f0aefacf9b8c838cb5108dcc100f336e0b
[2]: https://buildd.debian.org/status/fetch.php?pkg=libass&arch=i386&ver=1%3A0.16.0-1&stamp=1652520467&raw=0
[3]: https://github.com/libass/libass/commit/3855299b0721acfeb5391a140cd6df65ce2b73d2

Attachment: signature.asc
Description: PGP signature


Reply to: