[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1005794: marked as done (snibbetracker: reproducible-builds: Build path embedded in debug symbols)

Your message dated Sun, 13 Mar 2022 18:51:16 +0000
with message-id <E1nTTJE-000Hfo-Nl@fasolo.debian.org>
and subject line Bug#1005794: fixed in snibbetracker 1.1.1-3
has caused the Debian Bug report #1005794,
regarding snibbetracker: reproducible-builds: Build path embedded in debug symbols
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1005794: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005794
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: snibbetracker
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Different build paths trigger reproducibility issues with binaries such
as /usr/bin/snibbetracker and relevent debugging symbols.

For two builds done with reprotest, the debug symbols contain the
different build paths:

  0  (line_strp)     (offset: 0x0): /tmp/reprotest.lNSnkN/const_build_path/snibbetracker/src
vs.
  0  (line_strp)     (offset: 0x0): /tmp/reprotest.lNSnkN/build-experiment-1/snibbetracker/src


The attached patch fixes this by passing -ffile-prefix-map in
debian/Makefile to avoid embedding the build path into the binaries.


Another option might be to pass COMPILER_FLAGS=$(CFLAGS) to use the
default flags from debhelper/dpkg-buildflags, which includes
-ffile-prefix-map, and/or explore patching the upstream
Makefile to accept variables passed to it...


With this patch applied, snibbetracker should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining snibbetracker!


live well,
  vagrant

From d2cb9d8738ad25dcbbe9a0cb2dd8906d86e558e5 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 15 Feb 2022 02:05:07 +0000
Subject: [PATCH] debian/Makefile: Pass -ffile-prefix-map to remove build
 directory from binaries.

Without this, building the package in a different directory results in
different binaries.

https://reproducible-builds.org/docs/build-path/
---
 debian/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/Makefile b/debian/Makefile
index f053e39..33ccea1 100644
--- a/debian/Makefile
+++ b/debian/Makefile
@@ -14,7 +14,7 @@ INCLUDE_PATHS = -I/usr/include/cjson
 LIBRARY_PATHS = -L/usr/lib/x86_64-linux-gnu
 
 # Compiler flags
-COMPILER_FLAGS = -Wall -std=c99 -Wno-unused-function -g
+COMPILER_FLAGS = -Wall -std=c99 -Wno-unused-function -g -ffile-prefix-map=$(CURDIR)=.
 
 # Linker flags
 LINKER_FLAGS = -lSDL2main -lSDL2 -lm -lcjson -luuid
-- 
2.34.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: snibbetracker
Source-Version: 1.1.1-3
Done: Gürkan Myczko <tar@debian.org>

We believe that the bug you reported is fixed in the latest version of
snibbetracker, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1005794@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Myczko <tar@debian.org> (supplier of updated snibbetracker package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 13 Mar 2022 19:24:27 +0100
Source: snibbetracker
Architecture: source
Version: 1.1.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Gürkan Myczko <tar@debian.org>
Closes: 1005794
Changes:
 snibbetracker (1.1.1-3) unstable; urgency=medium
 .
   * Apply patch to fix reproducible-builds. (Closes: #1005794)
     Thanks Vagrant Cascadian.
Checksums-Sha1:
 6cb51ab1f1b1d365300fc5023c22279fbbe58c9f 2007 snibbetracker_1.1.1-3.dsc
 d478eb71b415c1f0770165533ef19d7cbfc9ab77 3752 snibbetracker_1.1.1-3.debian.tar.xz
 10c8b440635b2c24e0298aec36f39bdc91512902 11541 snibbetracker_1.1.1-3_source.buildinfo
Checksums-Sha256:
 db8cceebee71e04ff7b66d1526103ac820863979e7a4cad071e311788d057349 2007 snibbetracker_1.1.1-3.dsc
 17a585417cced8c0a99d353633fcd72d807b28986fb8c8a921bd14ef1236c546 3752 snibbetracker_1.1.1-3.debian.tar.xz
 1bf504101a034e39c00da094477586dd4d21cd84b87fa81e8fdb1628f7793b52 11541 snibbetracker_1.1.1-3_source.buildinfo
Files:
 8d5ca566e9b8dfb55ee52d7ea77b0b72 2007 sound optional snibbetracker_1.1.1-3.dsc
 80a5291ec2e2ae8f92b04813b13be846 3752 sound optional snibbetracker_1.1.1-3.debian.tar.xz
 21b0a36724c19a7dc23fb0d3db2abd2c 11541 sound optional snibbetracker_1.1.1-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEtgob82PcExn/Co6JEWhSvN91FcAFAmIuN/kACgkQEWhSvN91
FcBsig//eZoXiZ7mmfALtLNJz3sjTn8wygoytAD4vGy2pR6zLhoCuYKYAoycr8I3
qm3OBaK6ehd2nSkqZscf6h9vaVU0Rww7sDjJVhy2DfBbFJdr15PSiUFKSMhb6DpS
peZy2tvlCTFcuzu1s07oc2P/W293lQAoyVZHGYOR/Zv+UaWuepe3foVRlUHaYd4q
JmmrC/mAob68Ho+qQKL1sHaOLzkaTvQPqWCs3neL2Baprq8aiLsk8IY1W1Qd2JSQ
6emR60GLS75pJllg5rezh494dHvCBZTdcS27t1LSKq8SfCChKe2gSEabmsMXAzP7
5cntB6TqQDFEGST14qddLyrKkyoJEy8a6R2dvIg0I8Is5cENwpVy5fB1qvLUv4jh
v0XMHVmcdv3G43u0PhtKz9TFN45bzv8hL3h2FPTegy3in5nCQSGaWKp0EQtZX4Vk
lQx68cFsufD3a5GwQ/06BQULsNV1F8VzGbbBj8vwkiAA9rEnB8SXFplWeEnvHSxx
EzzqMQG6Z4XUTdhpiGENWdmDAZ9vio73m/40HZCPs35L58dAhJ+zljMC69Okf5WM
kOQ91IHSD5fFp5v6TDfqB7FLrkKLmImYHS5OsuXL20yqf9VruOOF20dUF9wyBcYX
bgcGVdEVUwSExDdyy1WiB6ap7GXlam7tl3QF2ZqQ9f01pAwh8OU=
=ak9n
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: