[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006256: marked as done (gmerlin: reproducible builds: Timestamps embedded in manpages)

Your message dated Tue, 08 Mar 2022 14:35:28 +0000
with message-id <E1nRavw-0001me-Gv@fasolo.debian.org>
and subject line Bug#1006256: fixed in gmerlin 2.0.0~svn6298~dfsg0-2
has caused the Debian Bug report #1006256,
regarding gmerlin: reproducible builds: Timestamps embedded in manpages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1006256: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1006256
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: gmerlin
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build timestamp is embedded in manpages:

  ./usr/share/man/man1/mdb-tool.1.gz

  -.TH MDB-TOOL 1 "February 2022" Gmerlin "User Manuals"
  vs.
  +.TH MDB-TOOL 1 "November 2022" Gmerlin "User Manuals"


The attached patch fixes this by respecting the SOURCE_DATE_EPOCH
environment variable in the manpage generation code in lib/cmdline.c.


With this patch applied, gmerlin should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining gmerlin!


live well,
  vagrant

From d532ebe90243f9390b0b1e49f1d4918f173238a6 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 22 Feb 2022 03:25:25 +0000
Subject: [PATCH] lib/cmdline.c: Use deterministic timestamp when generating
 manpages.

Use the SOURCE_DATE_EPOCH environment variable if available, and use
numeric date to avoid embedding locale-dependent month names.

https://reproducible-builds.org/docs/source-date-epoch/
---
 lib/cmdline.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lib/cmdline.c b/lib/cmdline.c
index 4b4d2f6..049e905 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -441,9 +441,13 @@ void bg_cmdline_print_help(char * argv0, bg_help_format_t format)
       char ** args;
       char * string_uc;
       
-      time(&t);
-      localtime_r(&t, &brokentime);
-      strftime(date_str, 511, "%B %Y", &brokentime);
+      char *source_date_epoch;
+      /* This assumes that the SOURCE_DATE_EPOCH environment variable will contain
+         a correct, positive integer in the time_t range */
+      if ((source_date_epoch = getenv("SOURCE_DATE_EPOCH")) == NULL ||
+          (t = (time_t)strtoll(source_date_epoch, NULL, 10)) <= 0)
+        time(&t);
+      strftime(date_str, 511, "%F", gmtime(&t));
 
       string_uc = bg_toupper(bg_app_get_name());
       
-- 
2.35.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: gmerlin
Source-Version: 2.0.0~svn6298~dfsg0-2
Done: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>

We believe that the bug you reported is fixed in the latest version of
gmerlin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1006256@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated gmerlin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 08 Mar 2022 15:06:20 +0100
Source: gmerlin
Architecture: source
Version: 2.0.0~svn6298~dfsg0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 1006256
Changes:
 gmerlin (2.0.0~svn6298~dfsg0-2) unstable; urgency=medium
 .
   * Add patch for reproducible manpages.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>
     (Closes: #1006256)
Checksums-Sha1:
 82fe56c8c0b0ead78e7bfc8f736613de5ebbd7b6 2959 gmerlin_2.0.0~svn6298~dfsg0-2.dsc
 ba1b7733f1116836e3252d6c320f961bf795182f 27692 gmerlin_2.0.0~svn6298~dfsg0-2.debian.tar.xz
Checksums-Sha256:
 974b1ae29c1bfbba0c6c8baff50aa6d3faba0f5d1e6f020fd45487c2196ac55b 2959 gmerlin_2.0.0~svn6298~dfsg0-2.dsc
 03c7061b9c81c44010a0b3ae7a3a0f635dada6ca33808684436e123bac6066b2 27692 gmerlin_2.0.0~svn6298~dfsg0-2.debian.tar.xz
Files:
 866f314be1d1336a92f4e85077b29d40 2959 sound optional gmerlin_2.0.0~svn6298~dfsg0-2.dsc
 edac92cba2a0ba687da53d04f7315ae1 27692 sound optional gmerlin_2.0.0~svn6298~dfsg0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAmInZr8WHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+GZKEACAvttSV8Y6Ni/44sE5dZuMojb7
5Xqxnfu2nRdTeUbdsMWaL16zeRFYpuL6j6KQRuhMMSh2zEnc1X0tX5AhZIp2Hzd8
kohhnITswxtmUza9FuD9RCWbUCCnOGFTTxkOu2FH2sl07e8A6jzNWyY9t7PlZ2Zs
pWPCTV0zwk3HB6Jf8OMMar/MazVAgiYlIzSpZKVeAkztt2UXrsnrwmsaaNETB5Lb
iACQVSHaRHNaLruavNpU1KCCXh7ZokyzWlyUJ4dlVVgtUiWMY1ziyz62W2g6neBR
2QOAa10jilWkvYKxAJ1BsjRDMGKBONC1O+bGJRqBwYc+u/CmrvFSD3BQNA7gG48Y
Mk+a/+obqSVsBXtBSxNnPxjACFB25whS9X8/ZrTSTcA0JFqMknXMBoyYL2hyZBJi
b6hYvSc/20nGo8xSpzzoeenK6KVM4iJ5JkTrWICDXWNIK561NlxVghYyoCCvDKdI
LiqXXCpszZAg5mBwRC6XfBGqtqFG218QNzL/zsLk2MzCGhm064ztwvDo7IYQlhC0
zy42R8WKZOyAM846aQiWj7wHkEtkt/LHtVy1W1uSwHMeR0cvtnbCJzFAIW8OhYB0
xzbbOCRnBL6G/YLz2AZRgLuKc3q+UQmeugfF/wsVwdP72V7RQeAsH68Z5koEBzp9
huGZ+RQE2r6GIGak/A==
=Iwg1
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: