[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1006523: blender: please build with Intel Open Image Denoise support



On Sun, 27 Feb 2022 23:13:08 +0100 Matteo F. Vescovi wrote:

> Ciao!

Ciao!   :-)

Thanks for your very prompt reply.

> 
> Il sab 26 feb 2022, 20:15 Francesco Poli (wintermute) <
> invernomuto@paranoici.org> ha scritto:
[...]
> > However, it seems to me that the blender Debian package is built
> > without support for Intel [Open Image Denoise].
[...]
> > Because Intel [Open Image Denoise] is not (yet) packaged for Debian,
> > perhaps?
> > Maybe a RFP bug could be filed and let it block this bug report.
> >
> > [Open Image Denoise]: <https://www.openimagedenoise.org/>
[...]
> 
> Please, have a look at [1].
> 
[...]
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975318#10

I see, and I agree with Debian Policy that convenience copies of code
should be avoided, whenever possible.

However, I think we are *not* talking about a convenience copy here.

According to the upstream [issue] you cited, Intel Open Image Denoise
includes a modified version of oneAPI Deep Neural Network Library, and
cannot work correctly, if linked with the official oneAPI Deep Neural
Network Library.

[issue]: <https://github.com/OpenImageDenoise/oidn/issues/107#issuecomment-889049772>

That does *not* seem to be a convenience copy. It looks like a
*necessity* (modified) copy.

I don't think that packaging Intel Open Image Denoise for inclusion in
Debian (with that internal modified copy of oneAPI Deep Neural Network
Library) would be against the Debian Policy.

For instance, I personally saw a similar situation with Paraview that
embeds its own copy of the VTK library. It was [explained] to me that
the specific version of VTK is needed for Paraview to work correctly.

[explained]: <https://public.kitware.com/pipermail/paraview/2006-October/003884.html>

I [raised] the issue, while Paraview was being packaged for inclusion
in Debian, but Paraview needs its own specific version of VTK and was
included in Debian without linking with the already packaged VTK
library. As far as I can see, the Debian package still includes its own
VTK.

[raised]: <https://bugs.debian.org/462631#39>

Long story short, I would like to encourage you to package Intel Open
Image Denoise (with its internal modified copy of oneAPI Deep Neural
Network Library), if you still feel like doing so.



-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

Attachment: pgplgBAVkKQbX.pgp
Description: PGP signature


Reply to: