[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1000305: marked as done (lsp-plugins FTCBFS: uses the build architecture ld and pkg-config)

Your message dated Mon, 27 Dec 2021 21:49:58 +0000
with message-id <E1n1xsU-0006u9-LO@fasolo.debian.org>
and subject line Bug#1000305: fixed in lsp-plugins 1.1.31-1
has caused the Debian Bug report #1000305,
regarding lsp-plugins FTCBFS: uses the build architecture ld and pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1000305: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000305
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: lsp-plugins
Version: 1.1.30-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

lsp-plugins fails to cross build from source, becaue it uses the build
architecture ld and pkg-config. For ld, dh_auto_build does not pass a
cross tool as the use of LD variable is inconsistent across upstream
projects. pkg-config instead is hard coded in the upstream build system.
The attached patch addresses both, but it does not make lsp-plugins
cross buildable, because lsp-plugins builds some build tools and fails
running them with an Exec format error (e.g. gen_resources.exe or
gen_php.exe). I suppose more thought is required for fixing these.
Please consider applying my patch as an incremental improvement and
close this bug when doing so.

Helmut

diff --minimal -Nru lsp-plugins-1.1.30/debian/changelog lsp-plugins-1.1.30/debian/changelog
--- lsp-plugins-1.1.30/debian/changelog	2021-08-19 12:50:50.000000000 +0200
+++ lsp-plugins-1.1.30/debian/changelog	2021-11-20 12:54:14.000000000 +0100
@@ -1,3 +1,10 @@
+lsp-plugins (1.1.30-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Improve cross building: Use the host arch ld and pkg-config. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sat, 20 Nov 2021 12:54:14 +0100
+
 lsp-plugins (1.1.30-1) unstable; urgency=medium
 
   * Provide the lsp-plugins-r3d-glx package,
diff --minimal -Nru lsp-plugins-1.1.30/debian/patches/cross.patch lsp-plugins-1.1.30/debian/patches/cross.patch
--- lsp-plugins-1.1.30/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ lsp-plugins-1.1.30/debian/patches/cross.patch	2021-11-20 12:54:14.000000000 +0100
@@ -0,0 +1,58 @@
+--- lsp-plugins-1.1.30.orig/scripts/make/configure.mk
++++ lsp-plugins-1.1.30/scripts/make/configure.mk
+@@ -131,17 +131,17 @@
+   export ICONV_LIBS       = -liconv
+   export MATH_LIBS        = -lm
+   export DL_LIBS          = -ldl
+-  export CAIRO_HEADERS    = $(shell pkg-config --cflags cairo)
+-  export CAIRO_LIBS       = $(shell pkg-config --libs cairo)
+-  export XLIB_HEADERS     = $(shell pkg-config --cflags x11)
+-  export XLIB_LIBS        = $(shell pkg-config --libs x11)
+-  export LV2_HEADERS      = $(shell pkg-config --cflags lv2)
+-  export LV2_LIBS         = $(shell pkg-config --libs lv2)
+-  export SNDFILE_HEADERS  = $(shell pkg-config --cflags sndfile)
+-  export SNDFILE_LIBS     = $(shell pkg-config --libs sndfile)
+-  export JACK_HEADERS     = $(shell pkg-config --cflags jack)
+-  export JACK_LIBS        = $(shell pkg-config --libs jack)
+-  export OPENGL_HEADERS   = $(shell pkg-config --cflags gl 2>/dev/null || echo "")
+-  export OPENGL_LIBS      = $(shell pkg-config --libs gl 2>/dev/null || echo "")
++  export CAIRO_HEADERS    = $(shell $(PKG_CONFIG) --cflags cairo)
++  export CAIRO_LIBS       = $(shell $(PKG_CONFIG) --libs cairo)
++  export XLIB_HEADERS     = $(shell $(PKG_CONFIG) --cflags x11)
++  export XLIB_LIBS        = $(shell $(PKG_CONFIG) --libs x11)
++  export LV2_HEADERS      = $(shell $(PKG_CONFIG) --cflags lv2)
++  export LV2_LIBS         = $(shell $(PKG_CONFIG) --libs lv2)
++  export SNDFILE_HEADERS  = $(shell $(PKG_CONFIG) --cflags sndfile)
++  export SNDFILE_LIBS     = $(shell $(PKG_CONFIG) --libs sndfile)
++  export JACK_HEADERS     = $(shell $(PKG_CONFIG) --cflags jack)
++  export JACK_LIBS        = $(shell $(PKG_CONFIG) --libs jack)
++  export OPENGL_HEADERS   = $(shell $(PKG_CONFIG) --cflags gl 2>/dev/null || echo "")
++  export OPENGL_LIBS      = $(shell $(PKG_CONFIG) --libs gl 2>/dev/null || echo "")
+ endif
+ 
+--- lsp-plugins-1.1.30.orig/scripts/make/tools.mk
++++ lsp-plugins-1.1.30/scripts/make/tools.mk
+@@ -3,6 +3,7 @@
+ TOOL_CC                 = gcc
+ TOOL_CXX                = g++
+ TOOL_PHP                = php
++TOOL_PKG_CONFIG         = pkg-config
+ 
+ # Setup preferred flags
+ FLAG_RELRO              = -Wl,-z,relro,-z,now
+@@ -24,6 +25,7 @@
+ CXX                      ?= $(TOOL_CXX)
+ PHP                      ?= $(TOOL_PHP)
+ LD                       ?= $(TOOL_LD)
++PKG_CONFIG               ?= $(TOOL_PKG_CONFIG)
+ 
+ MAKE_OPTS                 = -s
+ CFLAGS                   += $(CC_ARCH) $(FLAG_CTUNE) $(CC_FLAGS) $(FLAG_VERSION)
+@@ -61,6 +63,7 @@
+ export CXX
+ export PHP
+ export LD
++export PKG_CONFIG
+ 
+ export MAKE_OPTS
+ export CFLAGS
diff --minimal -Nru lsp-plugins-1.1.30/debian/patches/series lsp-plugins-1.1.30/debian/patches/series
--- lsp-plugins-1.1.30/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ lsp-plugins-1.1.30/debian/patches/series	2021-11-20 12:52:02.000000000 +0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru lsp-plugins-1.1.30/debian/rules lsp-plugins-1.1.30/debian/rules
--- lsp-plugins-1.1.30/debian/rules	2021-08-18 23:41:28.000000000 +0200
+++ lsp-plugins-1.1.30/debian/rules	2021-11-20 12:54:12.000000000 +0100
@@ -3,6 +3,7 @@
 export PREFIX=/usr
 
 include /usr/share/dpkg/architecture.mk
+-include /usr/share/dpkg/buildtools.mk
 ifeq ($(DEB_HOST_ARCH),amd64)
 	export BUILD_PROFILE=x86_64
 endif
@@ -18,6 +19,7 @@
 ifeq ($(DEB_HOST_ARCH),armhf)
 	export BUILD_PROFILE=armv7a
 endif
+export LD ?= ld
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: lsp-plugins
Source-Version: 1.1.31-1
Done: Dennis Braun <d_braun@kabelmail.de>

We believe that the bug you reported is fixed in the latest version of
lsp-plugins, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1000305@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <d_braun@kabelmail.de> (supplier of updated lsp-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Dec 2021 22:30:32 +0100
Source: lsp-plugins
Architecture: source
Version: 1.1.31-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <d_braun@kabelmail.de>
Closes: 1000305
Changes:
 lsp-plugins (1.1.31-1) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Improve cross building: Use the host arch ld and pkg-config.
     (Closes: #1000305)
 .
   [ Dennis Braun ]
   * New upstream version 1.1.31
   * Update lintian-overrides
   * Update d/lsp-plugins-vst.links
Checksums-Sha1:
 31d924a7bf507ab87d64c4aa7f0b945eb9ec72b2 2471 lsp-plugins_1.1.31-1.dsc
 9f20a5785998fb3196c0952b6453ed7aaa745b0e 55132876 lsp-plugins_1.1.31.orig.tar.gz
 0047330789e9aeb67c67e76dfe8211cb697be0cf 7420 lsp-plugins_1.1.31-1.debian.tar.xz
 07ebef837ca7066f463218dbeba74de093593928 10056 lsp-plugins_1.1.31-1_source.buildinfo
Checksums-Sha256:
 e259ad715a87d3cb95b1e69de0d487649cbb12237c24ecd88cec1d2227825e0f 2471 lsp-plugins_1.1.31-1.dsc
 540252f747fa1253e0cec6d6b2804200929efcb5a69098d0487672877c84feb0 55132876 lsp-plugins_1.1.31.orig.tar.gz
 3b5311b09ba2d36db3743947067d703a2403c644d540fcd3b87ebcfdfbac1ae9 7420 lsp-plugins_1.1.31-1.debian.tar.xz
 a4d76e51358d74e2b32c72cf7948dd857ada9db386a7944ce05c4f5316915631 10056 lsp-plugins_1.1.31-1_source.buildinfo
Files:
 c123df7f7d71f9dc0f741085fd6d3791 2471 sound optional lsp-plugins_1.1.31-1.dsc
 429337bff7079e5ea8b04f28c66c1ed1 55132876 sound optional lsp-plugins_1.1.31.orig.tar.gz
 14b80db5e1a50d8d9b59e57eabe8c482 7420 sound optional lsp-plugins_1.1.31-1.debian.tar.xz
 aa6a6210451b4f048b85e3bfbd6b4edf 10056 sound optional lsp-plugins_1.1.31-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCgAzFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmHKMmQVHGRfYnJhdW5A
a2FiZWxtYWlsLmRlAAoJEGNOpV2QK5g20rsP+waZ2L6ZPXya+ph/QuN4jdwg62Up
OVd5FCYwCB6N/AnG5WwaVWvO7huOHI2iVu/8zwdqt2a2MNrSt/8HS/TyuPt+2rxB
rrZ6cGEUjX/w+CkkYim4TBFeJxDfIG9PNt2MhnNTepuToUtb3L+GEWN3l8YwjlXG
/bBU1LExtGbAy8TBW1PNX7voOViz9Od6Ot/OkrB//iTFYoVv1O2dwIF9mZs4WPjM
fwt6ZuaPGMYc7hadovMh8PDKW4oqti617KIEG3gWWdmh9AJ/rBmeZvmczhJc8LLa
xNo7UsHGARqGa2mvvvzc0vBvtWrSSY+iVIl8f31xfq0LnReCBMdOA0Nqt330KNbw
uKyBnrzcBE9wKjsISLh+2NntTXCJXo6pelkj/eSegOVQxDNHgZH+mqWsQ+QbXCL1
izEPVQNseJ0BauoElZ1RoFKusuM9h0irGXOXycI7r0NgD2oxtM5yqAoXnWQ57z6X
L69TfEbICcvsS60DcnHlgCUVETekMiuM+rigbxNexkyiugT6bIwMakxiNNoEsJQi
h9Rvl0Hn98Cvqvg8c3HIxcRAZV3r6JF0bLXXhmbC6OfARvdfcU9aySubeCLtL+QJ
3IE+EdoCX0qeNG9eom24qN9eH8o+VuxrahtQALMcW9yyfjfOy00Aye2wFZUhNzad
Wz5Yn9iENMXlXNv2
=Z3Ud
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: