Source: vlc Severity: normal Tags: patch User: reproducible-builds@lists.alioth.debian.org Usertags: umask X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org The umask of the build user affects the generated default.vlt, setting permissions on various files differently: https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/vlc.html ./usr/share/vlc/skins2/default.vlt drwxr-xr-x···0·root·········(0)·root·········(0)········0·2021-01-17·22:11:09.000000·default/ vs. drwxrwxr-x···0·root·········(0)·root·········(0)········0·2021-01-17·22:11:09.000000·default/ The attached patch fixes this by passing a mode argument to tar. This patch does not address all reproducibility issues in vlc (e.g. build paths), though applying it reduces the diff for the remaining issues. Thanks for maintaining vlc! live well, vagrant
From fa19a415056aeee2c5178926dbf638fe0e23fb98 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian <vagrant@reproducible-builds.org> Date: Wed, 23 Jun 2021 19:48:43 +0000 Subject: [PATCH 3/3] Pass mode to tar when creating default.vlt. Without explicitly passing the mode, the default.vlt may embed different permissions on the tar file depending on the umask of the build user. https://tests.reproducible-builds.org/debian/issues/unstable/different_due_to_umask_issue.html --- share/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/share/Makefile.am b/share/Makefile.am index 29e6d36f6..5c41ac793 100644 --- a/share/Makefile.am +++ b/share/Makefile.am @@ -98,6 +98,7 @@ skins2/default.vlt: $(skins2_default_vlt_FILES) tar cvvzf skins2/default.vlt.tmp \ --format=ustar $(tarsort) \ --owner=root --group=root --directory="$(srcdir)/skins2" \ + --mode=a+rX,og-w \ default/ $(AM_V_at)mv -f -- skins2/default.vlt.tmp skins2/default.vlt -- 2.32.0
Attachment:
signature.asc
Description: PGP signature