Bug#984682: kodi: Kodi 19.0+dfsg1 PVR Recordings from vdr vnsi plugin all show the same recording date.

[Vasyl Gello <vasek.gello@gmail.com>]

Package: kodi
Followup-For: Bug #984682

Hi!

Can you please build kodi-pvr-vdr-vnsi with attached patch and send me the Kodi log
in private mail? Before the run, please install Kodi from testing repo and try to
list the recordings with incorrect dates. This patch logs the actual timestamps
retrieved from client.

Also, is your timezone GMT+02 or +01 ?

Vasyl

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-66-generic (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages kodi depends on:
pn  kodi-bin   <none>
pn  kodi-data  <none>

Versions of packages kodi recommends:
pn  kodi-repository-kodi | kodi-repository  <none>
pn  kodi-visualization-spectrum             <none>

kodi suggests no packages.

diff --git a/src/ClientInstance.cpp b/src/ClientInstance.cpp
index 7019a3a..3bade64 100644
--- a/src/ClientInstance.cpp
+++ b/src/ClientInstance.cpp
@@ -655,7 +655,9 @@ PVR_ERROR CVNSIClientInstance::GetAvailableRecordings(kodi::addon::PVRRecordings
   {
     kodi::addon::PVRRecording tag;
 
-    tag.SetRecordingTime(vresp->extract_U32());
+    time_t recordingStartTime = vresp->extract_U32();
+
+    tag.SetRecordingTime(recordingStartTime);
     tag.SetDuration(vresp->extract_U32());
     tag.SetPriority(vresp->extract_U32());
     tag.SetLifetime(vresp->extract_U32());
@@ -683,7 +685,11 @@ PVR_ERROR CVNSIClientInstance::GetAvailableRecordings(kodi::addon::PVRRecordings
       tag.SetChannelType(PVR_RECORDING_CHANNEL_TYPE_UNKNOWN);
     }
 
-    tag.SetTitle(vresp->extract_String());
+    std::string title = vresp->extract_String();
+
+    kodi::Log(ADDON_LOG_ERROR, "%s - %s: %lld", __func__, title, recordingStartTime);
+
+    tag.SetTitle(title);
     tag.SetEpisodeName(vresp->extract_String());
     tag.SetPlotOutline(tag.GetEpisodeName());
     tag.SetPlot(vresp->extract_String());
@@ -713,7 +719,9 @@ PVR_ERROR CVNSIClientInstance::GetDeletedRecordings(kodi::addon::PVRRecordingsRe
   {
     kodi::addon::PVRRecording tag;
 
-    tag.SetRecordingTime(vresp->extract_U32());
+    time_t recordingStartTime = vresp->extract_U32();
+
+    tag.SetRecordingTime(recordingStartTime);
     tag.SetDuration(vresp->extract_U32());
     tag.SetPriority(vresp->extract_U32());
     tag.SetLifetime(vresp->extract_U32());
@@ -726,7 +734,11 @@ PVR_ERROR CVNSIClientInstance::GetDeletedRecordings(kodi::addon::PVRRecordingsRe
     else
       tag.SetChannelUid(PVR_CHANNEL_INVALID_UID);
 
-    tag.SetTitle(vresp->extract_String());
+    std::string title = vresp->extract_String();
+
+    kodi::Log(ADDON_LOG_ERROR, "%s - %s: %lld", __func__, title, recordingStartTime);
+
+    tag.SetTitle(title);
     tag.SetEpisodeName(vresp->extract_String());
     tag.SetPlotOutline(tag.GetEpisodeName());
     tag.SetPlot(vresp->extract_String());