[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994205: marked as done (Compilation of libopenshot fails with FFmpeg 4.4)

Your message dated Thu, 14 Oct 2021 07:36:01 +0000
with message-id <E1mavHV-000Dvm-9k@fasolo.debian.org>
and subject line Bug#994205: fixed in libopenshot 0.2.5+dfsg1-6
has caused the Debian Bug report #994205,
regarding Compilation of libopenshot fails with FFmpeg 4.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
994205: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994205
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 

Package: libopenshot
Version: 0.2.5+dfsg1-5
When libopenshot (v. 0.2.5+dfsg1-5) is compiled with FFMPEG 4.4-6 (now in bookworm/sid) compilation fails.
The patch in attachment (proposed here: https://github.com/OpenShot/libopenshot/pull/698) fixes the issue. 

I am using Ubuntu 20.04, kernel 5.11.0-34-generic and libc6 2.31-0ubuntu9.
diff -Nru libopenshot-0.2.5.orig/src/FFmpegWriter.cpp libopenshot-0.2.5/src/FFmpegWriter.cpp
--- libopenshot-0.2.5.orig/src/FFmpegWriter.cpp	2020-03-03 03:00:06.000000000 -0500
+++ libopenshot-0.2.5/src/FFmpegWriter.cpp	2021-09-11 22:05:52.000000000 -0400
@@ -1710,7 +1710,10 @@
 										 audio_encoder_buffer_size, 0);
 
 				// Create output frame (and allocate arrays)
-				frame_final->nb_samples = audio_input_frame_size;
+                frame_final->nb_samples = audio_input_frame_size;
+                frame_final->channels = info.channels;
+                frame_final->format = audio_codec->sample_fmt;
+                frame_final->channel_layout = info.channel_layout;
 				av_samples_alloc(frame_final->data, frame_final->linesize, info.channels, frame_final->nb_samples, audio_codec->sample_fmt, 0);
 
 				// Convert audio samples

----------------------------
     RUNNING ALL TESTS
----------------------------
[libvpx @ 0x5620a7020700] v1.10.0
[libvpx @ 0x5620a7020700] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] using cpu capabilities: MMX2 SSE2 SSE3 Cache64
[libx264 @ 0x5620a7363100] profile High, level 3.1, 4:2:0, 8-bit
[libx264 @ 0x5620a7363100] 264 - core 160 r3011 cde9a93 - H.264/MPEG-4 AVC codec - Copyleft 2003-2020 - http://www.videolan.org/x264.html - options: cabac=1 ref=3 deblock=1:0:0 analyse=0x3:0x113 me=hex subme=7 psy=1 psy_rd=1.00:0.00 mixed_ref=1 me_range=16 chroma_me=1 trellis=1 8x8dct=1 cqm=0 deadzone=21,11 fast_pskip=1 chroma_qp_offset=-2 threads=8 lookahead_threads=1 sliced_threads=0 nr=0 decimate=1 interlaced=0 bluray_compat=0 constrained_intra=0 bframes=0 weightp=2 keyint=12 keyint_min=1 scenecut=40 intra_refresh=0 rc_lookahead=12 rc=abr mbtree=1 bitrate=5000 ratetol=1.0 qcomp=0.60 qpmin=2 qpmax=30 qpstep=4 ip_ratio=1.40 aq=1:1.00
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
[libx264 @ 0x5620a7363100] Ignoring attempt to flush encoder that doesn't support it
/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/tests/FFmpegWriter_Tests.cpp:116:1: error: Failure in Options_Overloads: Expected 1 but was 0
/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/tests/FFmpegWriter_Tests.cpp:119:1: error: Failure in Options_Overloads: Expected 2 but was 0
/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/tests/FFmpegWriter_Tests.cpp:120:1: error: Failure in Options_Overloads: Expected 3 but was 4
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
FAILURE: 1 out of 93 tests failed (3 failures).
Test time: 23.54 seconds.
----------------------------
make[4]: *** [tests/CMakeFiles/test.dir/build.make:60: tests/CMakeFiles/test] Error 3
make[4]: Leaving directory '/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/debian/build'
make[3]: *** [CMakeFiles/Makefile2:489: tests/CMakeFiles/test.dir/all] Error 2
make[3]: Leaving directory '/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/debian/build'
make[2]: *** [CMakeFiles/Makefile2:496: tests/CMakeFiles/test.dir/rule] Error 2
make[2]: Leaving directory '/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/debian/build'
make[1]: *** [Makefile:332: test] Error 2
make[1]: Leaving directory '/home/nicola/Software/Ubuntu/openshot/test/libopenshot-0.2.5+dfsg1/debian/build'
dh_auto_test: error: cd debian/build && make -j8 test ARGS\+=-j8 returned exit code 2

--- End Message ---
--- Begin Message --- 
Source: libopenshot
Source-Version: 0.2.5+dfsg1-6
Done: Sebastian Ramacher <sramacher@debian.org>

We believe that the bug you reported is fixed in the latest version of
libopenshot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 994205@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <sramacher@debian.org> (supplier of updated libopenshot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 13 Oct 2021 22:01:31 +0200
Source: libopenshot
Architecture: source
Version: 0.2.5+dfsg1-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sebastian Ramacher <sramacher@debian.org>
Closes: 994205
Changes:
 libopenshot (0.2.5+dfsg1-6) unstable; urgency=medium
 .
   * Team upload
 .
   [ Gianfranco Costamagna ]
   * debian/patches/698.patch:
     - cherry-pick a rebase of an upstream patch for FFMPEG 4.4-6
       test failure (Closes: #994205)
       - thanks Nicola Ferralis for the help and patch!
 .
   [ Sebastian Ramacher ]
   * debian/control: Bump Standards-Version
Checksums-Sha1:
 634755069e1f5f7e1f49428442c01b345f81dc2a 2570 libopenshot_0.2.5+dfsg1-6.dsc
 66c1dd2615a37316e7e1a6763ed5c078f77ca429 6812 libopenshot_0.2.5+dfsg1-6.debian.tar.xz
Checksums-Sha256:
 1f48ea895a61f2720adf5d09ca7373f3dedec7227cc6a948ae81a26dda3d5ad9 2570 libopenshot_0.2.5+dfsg1-6.dsc
 b8dea7930e2125c3dea123172af146dca0e669099e9922f63f3aa4d289cb0e3c 6812 libopenshot_0.2.5+dfsg1-6.debian.tar.xz
Files:
 f219c3301d46fcd5433d71015299a0f6 2570 libs optional libopenshot_0.2.5+dfsg1-6.dsc
 bf4475c46c3dfc3f439061a3afea05b1 6812 libs optional libopenshot_0.2.5+dfsg1-6.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIyBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAmFn2c8ACgkQafL8UW6n
GZPMAg/42zVV46zqLDGhA655aX56+zAfFwCH5ddU6miq58NEcgZZkafH3+kqBZPB
keG0bmjdS6UiNgq4utBx1/9YuH5275lNPQ+8ES5FHDAv8ugSCiZQtgnyFNUMkc39
oXKAOMv1g9ftr3d7Bk96//RiaYXn8nWZTDtFRyQ1MxiFAjvp7ZOlEwxTkjVUUvtt
wvuLbttF2USsRmE1CrWKHTSM8r9IQ5PoWCqeoUpmAWJVALLBQJwo/vNv4xOWU+Pw
Xy23u/udYXYc/lCivJsUdt8Xa2g/snV95qttKF9w8ZsnvVJTSwQRm8bEQWHvgsH9
5Pz4oS6R7jvP5BsnlVoxOIV4ukOUiRIe8N/8tnpKZEL4jJIPYu5JPH/hXdV5lViU
0fMIRd/vtaL0qgOB/UcQBnjnTq9w/rd2kf7YgD7lyQPWsqEHsqirSOlA1BZJtfJG
YWOBjXW4H3t5il/emRdpep3JCJl0PH1VPWQKpxdHMavWJMWMXKrTDB2qanN2j1OA
5DGbSwLfGjbHRVB6AWgpiif0fZvSFng7p7zWrdHy4rm/w5EYuNSRTVZDOnHwTEJY
LbI4PUNVEP1MAlqbsLJCGYckGW8bpdHR18bv+odHuCCv9gfjBnuAWCXQfVFkFXxA
a/QKIGcWdrlTXVp4N2LOlgl3mJkhBXJWAbqN5M4SSQJQvH9Xbg==
=BM3e
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: