[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994741: regression tests: skipped vs failed



On Tue, 21 Sep 2021 19:03:07 +0200
Mattia Rizzolo <mattia@mapreri.org> wrote:

> concerning the ftbfs of 1.1. I know of it of course. Just that I've
> been busy over the past month. I'm as weirded out by that test failure
> as you, especially since I couldn't reproduce it anywhere else.

Does that not suggest that the problem is some peculiarity of the build
environment, rather than any specific problem with the Inkscape code?

Comparing the build logs for v1.0.2 and v1.1, one discovers that the
reason that this is not a problem for v1.0.2 is that this specific test
apparently does not exist in that version.

https://buildd.debian.org/status/fetch.php?pkg=inkscape&arch=amd64&ver=1.0.2-4&stamp=1618427913&raw=0

https://buildd.debian.org/status/fetch.php?pkg=inkscape&arch=amd64&ver=1.1-1&stamp=1629559190&raw=0

But what is this?


    Unable to init server: Could not connect: Connection refused
    Failed to get connection
    ** (inkscape:2024671): CRITICAL **: 15:19:35.442: dbus_g_proxy_new_for_name: assertion 'connection != NULL' failed

    ** (inkscape:2024671): CRITICAL **: 15:19:35.442: dbus_g_proxy_call: assertion 'DBUS_IS_G_PROXY (proxy)' failed

    ** (inkscape:2024671): CRITICAL **: 15:19:35.442: dbus_g_connection_register_g_object: assertion 'connection != NULL' failed
    end_font_face_cb: font face rule limited support.
      font-family : 'GeomTest';
      src : url(fonts/GeomTest-gzipped-SVG-glyphs.otf)
    end_font_face_cb: Added font: /<<PKGBUILDDIR>>/testfiles/rendering_tests/fonts/GeomTest-gzipped-SVG-glyphs.otf
    Background RRGGBBAA: ffffff00
    Area 0:0:110:40 exported to 110 x 40 pixels (96 dpi)
    Pixbuf::create_from_file: Unrecognized image file format
       ()
    Pixbuf::create_from_file: Unrecognized image file format
       ()
    Pixbuf::create_from_file: Unrecognized image file format
       ()
    1589
    text-gzipped-svg-glyph FAILED
    text-gzipped-svg-glyph-large SKIPPED


Why is a "connection" necessary to retrieve a font file from a "url"?
And why should the "server" then "refuse" it? Is this not expecting
entirely too much from a mere package-build server?

How does D-Bus come into this mess? Surely the resources provided by the
filesystem should be all that is required for compilation and regression
testing? This is not some kind of network client, or if it somehow is,
that functionality should not be required to just build the distribution
package.

The "src: url(fonts/GeomTest-gzipped-SVG-glyphs.otf)" part actually does
come from the regression test, but otherwise that tiny file provides no
hint of what is going on.

https://sources.debian.org/src/inkscape/1.1-1/testfiles/rendering_tests/text-gzipped-svg-glyph.svg/

But again: why does a font file need to be retrieved from a "url", in
the context of a regression test?

> But no, I'm not going to ignore a test failure just because it's
> skipped in other architectures for different reasons: I'll need more
> convincing reasons.

Do we know that it's skipped in other architectures for different
reasons? Maybe it's skipped in other architectures for the same reason:
it breaks things.

Again, note that this particular test was not present in previous
versions, which is why it never caused a problem before.


Reply to: