[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#923617: marked as done (vlevel FTCBFS: confuses CC vs. CXX)

Your message dated Sun, 05 Sep 2021 15:03:58 +0000
with message-id <E1mMtgc-000Gu2-Bm@fasolo.debian.org>
and subject line Bug#923617: fixed in vlevel 0.5.1-4
has caused the Debian Bug report #923617,
regarding vlevel FTCBFS: confuses CC vs. CXX
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
923617: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923617
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: vlevel
Version: 0.5.1-3
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

vlevel's upstream Makefile observes that storing the C++ compiler in
$(CC) is an "evil hack". Indeed, this hack breaks cross compilation,
because dh_auto_build passes a C compiler there. Updating CC to a $(CXX)
fixes that part, but there is still a Makefile that hard codes the build
architecture pkg-config. The attached patch makes vlevel cross
buildable. Please consider applying it.

Helmut

diff --minimal -Nru vlevel-0.5.1/debian/changelog vlevel-0.5.1/debian/changelog
--- vlevel-0.5.1/debian/changelog	2019-01-02 07:30:04.000000000 +0100
+++ vlevel-0.5.1/debian/changelog	2019-03-02 21:47:15.000000000 +0100
@@ -1,3 +1,12 @@
+vlevel (0.5.1-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Upstream expects $(CC) to contain a C++ compiler.
+    + cross.patch: Make pkg-config substitutable.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sat, 02 Mar 2019 21:47:15 +0100
+
 vlevel (0.5.1-3) unstable; urgency=medium
 
   [ Ondřej Nový ]
diff --minimal -Nru vlevel-0.5.1/debian/patches/cross.patch vlevel-0.5.1/debian/patches/cross.patch
--- vlevel-0.5.1/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ vlevel-0.5.1/debian/patches/cross.patch	2019-03-02 21:47:15.000000000 +0100
@@ -0,0 +1,18 @@
+--- vlevel-0.5.1.orig/vlevel-jack/Makefile
++++ vlevel-0.5.1/vlevel-jack/Makefile
+@@ -21,11 +21,12 @@
+ #
+ # This is evil, but it makes implicit link rules use g++, not gcc
+ CC = $(CXX)
++PKG_CONFIG ?= pkg-config
+ #LDFLAGS = -L/opt/local/lib
+-LDFLAGS += ` pkg-config --libs-only-L jack `
++LDFLAGS += ` $(PKG_CONFIG) --libs-only-L jack `
+ #LDLIBS = -ljack -lpthread -framework CoreAudio -framework CoreServices -framework AudioUnit
+-LDLIBS = ` pkg-config --libs-only-l jack `
+-CXXFLAGS += ` pkg-config --cflags jack `
++LDLIBS = ` $(PKG_CONFIG) --libs-only-l jack `
++CXXFLAGS += ` $(PKG_CONFIG) --cflags jack `
+ #CXXFLAGS= -I/opt/local/include -g -v
+ CFLAGS = $(CXXFLAGS)
+ 
diff --minimal -Nru vlevel-0.5.1/debian/patches/series vlevel-0.5.1/debian/patches/series
--- vlevel-0.5.1/debian/patches/series	2017-10-30 00:44:44.000000000 +0100
+++ vlevel-0.5.1/debian/patches/series	2019-03-02 21:47:15.000000000 +0100
@@ -1,2 +1,3 @@
 fix-hardcoded-makefile-variables.patch
 recursive-make-done-properly.patch
+cross.patch
diff --minimal -Nru vlevel-0.5.1/debian/rules vlevel-0.5.1/debian/rules
--- vlevel-0.5.1/debian/rules	2017-10-30 00:33:11.000000000 +0100
+++ vlevel-0.5.1/debian/rules	2019-03-02 21:47:13.000000000 +0100
@@ -6,6 +6,9 @@
 %:
 	dh $@
 
+override_dh_auto_build:
+	dh_auto_build -- 'CC=$$(CXX)'
+
 override_dh_auto_install:
 	dh_auto_install
 	mv -v debian/vlevel/usr/bin/vlevel-bin debian/vlevel/usr/bin/vlevel

--- End Message ---
--- Begin Message --- 
Source: vlevel
Source-Version: 0.5.1-4
Done: Axel Beckert <abe@debian.org>

We believe that the bug you reported is fixed in the latest version of
vlevel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 923617@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Axel Beckert <abe@debian.org> (supplier of updated vlevel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 05 Sep 2021 16:34:05 +0200
Source: vlevel
Architecture: source
Version: 0.5.1-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Axel Beckert <abe@debian.org>
Closes: 923617
Changes:
 vlevel (0.5.1-4) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #923617)
     + Upstream expects $(CC) to contain a C++ compiler.
     + cross.patch: Make pkg-config substitutable.
 .
   [ Axel Beckert ]
   * Add DEP-3 header to Helmut's patch.
   * Declare compliance with Debian Policy 4.6.0. (No changes needed.)
   * Create a DEP-12 debian/upstream/metadata file pointing to Github.
   * debian/watch:
     + Fix filenamemangle, replace "<project>" with "vlevel". Thanks Lintian!
     + Bump version from 3 to 4.
     + Drop old SF download page, the Github repo now at least has tags.
 .
   [ Debian Janitor ]
   * Bump debhelper-compat from 12 to 13.
Checksums-Sha1:
 eee32f729d58027dc77ca72e51883919bf49a995 1938 vlevel_0.5.1-4.dsc
 d7ae77d501c72b7ba86011a1bc0ad536be8992f0 4688 vlevel_0.5.1-4.debian.tar.xz
 e6db88f7b3765ab2d884a66782831f0879b079e1 6481 vlevel_0.5.1-4_source.buildinfo
Checksums-Sha256:
 ad9390b4819c1047d387bd0e617ea7b7d8ba8a553bc2df66bd80e64f83bdaddb 1938 vlevel_0.5.1-4.dsc
 0664d5a333b9715ae9fa58b552ffe1cd70c5ad517e11604ac95cc524847fde9f 4688 vlevel_0.5.1-4.debian.tar.xz
 d6c25879a5eac83be253bed3300a24100d74d534a3618ced5d921821648efb1c 6481 vlevel_0.5.1-4_source.buildinfo
Files:
 62f99d4afa2ed326c6e7892d7d49ebab 1938 sound optional vlevel_0.5.1-4.dsc
 5ed75807b4ffcd6e22a8d2011502fab5 4688 sound optional vlevel_0.5.1-4.debian.tar.xz
 875043f6e1dc9d31682cc98591d95a35 6481 sound optional vlevel_0.5.1-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEERoyJeTtCmBnp12Ema+Zjx1o1yXUFAmE01vIACgkQa+Zjx1o1
yXUuuxAAy80HbPjfug5H0vXfroJ8c4k68wbW0x/UtO40IV+LkTpYUtnU5TrJQVWc
z1E1bCkh8KUDRubQtRTaXSJwXxG2OW6FL0zzojXNER5fsFIf2w836wE6MlcC7dDu
fwjh3zirMnkiDSgxDbmPdgSgwHec3kHmYF1avLXf56T8DEnBZH2QzbUFprhIJ+YB
z8Cs3nRCA/WzoUzseqxNBTHNrHDnYOxFrbPjBKjX0wrHuHvx8rpigc4sq9N22IYD
sWA9+7mJQC9bDN/RasgteRZ8V65FIebCYScuvxneW0fInT2xBBTSPTE/BiQNpcnz
40Th7/d1Ah4x3gtURf5rsHhHwoRhLoQa5hh0dOE6IXt42LrQuaVYnpiG2OAafWgG
+pytRugEkYp3/mGt9PrHL2CCkl1nTdVqiAANxzVuDhHuA64KAoIhoGhYX8WIXRyb
0wA6oHZzJlFtftyxEeL6tZY9cI7ZDoOSdEFoAVGykWTa/zAAXPwIYAubv1A/Ih/b
LfiCVfC/9Q+lhR1AN0o57AEy4n8mnNviehe0dZTK4Fq1/Ei8R7G5WkrxQRdrIkBK
jnrniirjIBz+C8mcK25TopSWaILXcISynx1SnXBmXgn5M22ZDRRE9lTjEdanI1Ef
IXwSk2UQTjgvtNc7zT13y4IdkMWt+8vpIzOIOPuIJR8mUD6K5/U=
=2Ydd
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: