--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: libags-audio3: wrong ref-count in ags_fx_factory.c
- From: Joël Krähemann <jkraehemann@gmail.com>
- Date: Fri, 02 Apr 2021 16:54:28 +0200
- Message-id: <161737526847.2222006.6560804515876036321.reportbug@deb-halo>
Package: libags-audio3
Version: 3.7.44-3
Severity: normal
Tags: patch
Dear Maintainer,
Upstream discovered wrong ref-count in ags/audio/ags_fx_factory.c affecting
libags_audio.so and the gsequencer binary.
Without patching memory corruptions could occur. As AgsChannel implementation
might be finalize while in use.
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.9.0-1-amd64 (SMP w/24 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages libags-audio3 depends on:
ii gstreamer1.0-plugins-bad 1.18.2-1+b1
ii gstreamer1.0-plugins-base 1.18.3-1
ii gstreamer1.0-plugins-good 1.18.3-1
pn libags3 <none>
ii libasound2 1.2.4-1.1
ii libc6 2.31-10
ii libfftw3-double3 3.3.8-2
ii libglib2.0-0 2.66.8-1
ii libgstreamer-plugins-base1.0-0 1.18.3-1
ii libgstreamer1.0-0 1.18.3-1
ii libinstpatch-1.0-2 1.1.6-1
ii libjack-jackd2-0 [libjack-0.125] 1.9.17~dfsg-1
ii libpulse0 14.2-2
ii libsamplerate0 0.2.1+ds0-1
ii libsndfile1 1.0.31-1
ii libsoup2.4-1 2.72.0-2
ii libxml2 2.9.10+dfsg-6.3+b1
libags-audio3 recommends no packages.
libags-audio3 suggests no packages.
diff --git a/ags/audio/ags_fx_factory.c b/ags/audio/ags_fx_factory.c
index 2f904c133..dd2e78fb0 100644
--- a/ags/audio/ags_fx_factory.c
+++ b/ags/audio/ags_fx_factory.c
@@ -788,10 +788,6 @@ ags_fx_factory_create_playback(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -1236,10 +1232,6 @@ ags_fx_factory_create_buffer(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -1657,6 +1649,10 @@ ags_fx_factory_create_volume(AgsAudio *audio,
}
}
+ if(channel != NULL){
+ g_object_unref(channel);
+ }
+
if((AGS_FX_FACTORY_REMAP & (create_flags)) != 0){
if(fx_volume_audio != NULL){
g_object_unref(fx_volume_audio);
@@ -1683,10 +1679,6 @@ ags_fx_factory_create_volume(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -2131,10 +2123,6 @@ ags_fx_factory_create_peak(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -2589,10 +2577,6 @@ ags_fx_factory_create_eq10(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -3047,10 +3031,6 @@ ags_fx_factory_create_analyse(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -3505,10 +3485,6 @@ ags_fx_factory_create_envelope(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -3934,10 +3910,6 @@ ags_fx_factory_create_pattern(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -4381,10 +4353,6 @@ ags_fx_factory_create_notation(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -4892,10 +4860,6 @@ ags_fx_factory_create_ladspa(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -5407,10 +5371,6 @@ ags_fx_factory_create_dssi(AgsAudio *audio,
g_object_unref(input);
}
- if(channel != NULL){
- g_object_unref(channel);
- }
-
return(start_recall);
}
@@ -6025,10 +5985,6 @@ ags_fx_factory_create_lv2(AgsAudio *audio,
if(input != NULL){
g_object_unref(input);
}
-
- if(channel != NULL){
- g_object_unref(channel);
- }
return(start_recall);
}
--- End Message ---
--- Begin Message ---
Source: gsequencer
Source-Version: 3.10.1-1
Done: Joël Krähemann <jkraehemann@gmail.com>
We believe that the bug you reported is fixed in the latest version of
gsequencer, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 986290@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joël Krähemann <jkraehemann@gmail.com> (supplier of updated gsequencer package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 20 Aug 2021 13:54:56 +0200
Source: gsequencer
Architecture: source
Version: 3.10.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Joël Krähemann <jkraehemann@gmail.com>
Closes: 986290
Changes:
gsequencer (3.10.1-1) unstable; urgency=medium
.
* New upstream version 3.10.1
+ Fix wrong ref-count leading to memory corruption. Closes: #986290
Checksums-Sha1:
f2bfadb37cc2422e4f38b505932b9276c8bb1dd5 3925 gsequencer_3.10.1-1.dsc
fe43065f62f9390589259cbe4bd8eb5f9db6d692 7920944 gsequencer_3.10.1.orig.tar.gz
41e51685ed89184b96951c5a9c005ce25ef9e44e 659 gsequencer_3.10.1.orig.tar.gz.asc
ed3a1fa835b0630670be19acaaf777bac3799d4d 44576 gsequencer_3.10.1-1.debian.tar.xz
4510f4304068ac5aa2d8ce10fe66b0bf3ca9bf1a 25396 gsequencer_3.10.1-1_amd64.buildinfo
Checksums-Sha256:
a5ee698553f9a9208146155149f1476d7b6dd3ce23e21206e837e43f2335c1d9 3925 gsequencer_3.10.1-1.dsc
a012b80f2c7a2317de2dd77c573c5d87ea1044f16e878e5fb5e2839833ee11a3 7920944 gsequencer_3.10.1.orig.tar.gz
df3f1128e5f7f4639eebd22390e3ef48734f9ddb04c16e84468d1b35fd78ad20 659 gsequencer_3.10.1.orig.tar.gz.asc
4d92684015e508433ed8bcc5213655ebc02d2bf78a19e14aa5e9bd8d1c5f4844 44576 gsequencer_3.10.1-1.debian.tar.xz
c8bf874f9ee9d95ff70ba375e54260d5abe83ce4bb21af34cb4353c133572a40 25396 gsequencer_3.10.1-1_amd64.buildinfo
Files:
1ed3b06a686556e1bef909dd53af1d3c 3925 sound optional gsequencer_3.10.1-1.dsc
04f5a2e997971bd7357e6be669588849 7920944 sound optional gsequencer_3.10.1.orig.tar.gz
15a88fa6bbe0a5e1c18ae0994cc7d16b 659 sound optional gsequencer_3.10.1.orig.tar.gz.asc
bead066f2a9bb33c9efe6e09f1a39a7a 44576 sound optional gsequencer_3.10.1-1.debian.tar.xz
a068ed201a4d6c1b7af41c30bdf36ca0 25396 sound optional gsequencer_3.10.1-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmEhDpAACgkQCBa54Yx2
K61zRBAAuryZ1eMau7xNGQqEFgyHd0Yr28AMBnxwQbli9/bJ55iEANnAOWoPSA+j
8kxDxC1jY4mTuCY3Ewla9nl+LRnbKAueov5QqwM7cvWeRNwYWas6/ecg4EgoXaRD
SPNSOtbnkIqrh4EVcRXB9d6Wfu65NsDxuXxz/4coyjwdzHpgqPtdMJV0SVfyJB0a
fQUFBOMjGgfjCSBX2zq8xlcAXMuG4jegETGFYHsxsMTxWaas9fkUSshrDDuTJlrG
7vNWNcdxBWkHo1htJARtcJ5tRIIxppX6LXTa3BzZSkq/pL/mDA+CiFifaoKmHEkQ
q7LfGsvsccmalxEEzj1T9APsl3GaS+y9FbC/Fg5JfZze9TP8HS+D+9uyCSNKE21v
ad5yFe0qpPttIDpgzQcNsA2fuTVNx9+3DvYtQEnubUamsVXc/aw0v8gHA34qJEMn
+VBTBz+ZhVBq8R6gtLQ67i2rbdprQWAIbKepa8ViyFtb5U582Ic1a93HXEQ4Sig3
t9SmeC9BBYR8x/CB0+CBbnXyK6Ai+DEHuy+N23BCIzaj1R61TKAUNRpftcXR0rJc
BY/jQr4ahHIuB/60l2rWKUfYU0e24oUvSVxkVWOPjMLr8RdWL9d2kcs+5p5p/fkk
7zloixRwBbOhC2Yi7fqPR6otcGD5ImXkppn8wCHwhaGTXd67dVs=
=eHxt
-----END PGP SIGNATURE-----
--- End Message ---