[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946530: marked as done (Please make autopkgtests cross-test-friendly)

Your message dated Wed, 18 Aug 2021 08:37:00 +0000
with message-id <E1mGH4G-000D3A-0L@fasolo.debian.org>
and subject line Bug#946530: fixed in libopenmpt 0.5.10-1
has caused the Debian Bug report #946530,
regarding Please make autopkgtests cross-test-friendly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
946530: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946530
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libopenmpt
Version: 0.4.10-1
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

The libopenmpt tests currently fail in this environment, because they are
build tests that do not invoke the toolchain in a cross-aware manner.  I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment.  Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,


diff -Nru libopenmpt-0.4.10/debian/changelog libopenmpt-0.4.10/debian/changelog
--- libopenmpt-0.4.10/debian/changelog	2019-10-31 00:22:01.000000000 +0100
+++ libopenmpt-0.4.10/debian/changelog	2019-12-10 16:12:45.000000000 +0100
@@ -1,3 +1,9 @@
+libopenmpt (0.4.10-2) UNRELEASED; urgency=medium
+
+  * Make autopkgtests cross-test-friendly.
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Tue, 10 Dec 2019 11:01:27 +0100
+
 libopenmpt (0.4.10-1) unstable; urgency=medium
 
   [ James Cowgill ]
diff -Nru libopenmpt-0.4.10/debian/tests/build libopenmpt-0.4.10/debian/tests/build
--- libopenmpt-0.4.10/debian/tests/build	2019-10-31 00:22:01.000000000 +0100
+++ libopenmpt-0.4.10/debian/tests/build	2019-12-10 16:15:29.000000000 +0100
@@ -10,6 +10,12 @@
 	exit 1
 fi
 
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
 cd debian/tests
 
 # Runs argument on the test data and ensures it's matches expected result
@@ -22,14 +28,14 @@
 }
 
 # Build programs
-gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-c1" pattern-dump-c.c -lopenmpt
+${CROSS_COMPILE}gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-c1" pattern-dump-c.c -lopenmpt
 echo "build1: OK"
-gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-c2" pattern-dump-c.c $(pkg-config --cflags --libs libopenmpt)
+${CROSS_COMPILE}gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-c2" pattern-dump-c.c $(${CROSS_COMPILE}pkg-config --cflags --libs libopenmpt)
 echo "build2: OK"
 
-g++ -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-cpp1" pattern-dump-cpp.cpp -lopenmpt
+${CROSS_COMPILE}g++ -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-cpp1" pattern-dump-cpp.cpp -lopenmpt
 echo "build3: OK"
-g++ -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-cpp2" pattern-dump-cpp.cpp $(pkg-config --cflags --libs libopenmpt)
+${CROSS_COMPILE}g++ -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-cpp2" pattern-dump-cpp.cpp $(${CROSS_COMPILE}pkg-config --cflags --libs libopenmpt)
 echo "build4: OK"
 
 # Run them
diff -Nru libopenmpt-0.4.10/debian/tests/build-modplug libopenmpt-0.4.10/debian/tests/build-modplug
--- libopenmpt-0.4.10/debian/tests/build-modplug	2019-10-31 00:22:01.000000000 +0100
+++ libopenmpt-0.4.10/debian/tests/build-modplug	2019-12-10 12:29:46.000000000 +0100
@@ -12,6 +12,12 @@
 	exit 1
 fi
 
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
 cd debian/tests
 
 # Runs argument on the test data and ensures it's matches expected result
@@ -24,9 +30,9 @@
 }
 
 # Build programs
-gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-modplug1" pattern-dump-modplug.c -lmodplug
+${CROSS_COMPILE}gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-modplug1" pattern-dump-modplug.c -lmodplug
 echo "build1: OK"
-gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-modplug2" pattern-dump-modplug.c $(pkg-config --cflags --libs libmodplug)
+${CROSS_COMPILE}gcc -Wall -o "$AUTOPKGTEST_TMP/pattern-dump-modplug2" pattern-dump-modplug.c $(${CROSS_COMPILE}pkg-config --cflags --libs libmodplug)
 echo "build2: OK"
 
 # Run them

--- End Message ---
--- Begin Message --- 
Source: libopenmpt
Source-Version: 0.5.10-1
Done: Sebastian Ramacher <sramacher@debian.org>

We believe that the bug you reported is fixed in the latest version of
libopenmpt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 946530@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <sramacher@debian.org> (supplier of updated libopenmpt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 17 Aug 2021 22:52:36 +0200
Source: libopenmpt
Architecture: source
Version: 0.5.10-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sebastian Ramacher <sramacher@debian.org>
Closes: 946530 989956
Changes:
 libopenmpt (0.5.10-1) experimental; urgency=medium
 .
   [ Sebastian Ramacher ]
   * New upstream release (Closes: #989956)
   * debian/control: Remove modplug emulation
   * debian/copyright: Bump copyright years
   * debian/libopenmpt0.symbols: Add new symbols
 .
   [ Sebastien Bacher ]
   * Make autopkgtests cross-test-friendly (Closes: #946530)
Checksums-Sha1:
 1108600ad32085977565bd5f0856152b77b08746 2375 libopenmpt_0.5.10-1.dsc
 7f180e245fda270667ad744a2dc3bfb8c4ed3ce7 1475967 libopenmpt_0.5.10.orig.tar.gz
 03521d44412590efe67d98f47d8c6d34821f4e19 10592 libopenmpt_0.5.10-1.debian.tar.xz
Checksums-Sha256:
 2cb277d170cc0c06808ed6c811cf44bb747436a7d4eff26bac3ff51406a1e71a 2375 libopenmpt_0.5.10-1.dsc
 59a8fa28d8b8df69cb7fa5972bdf931081dab4e1e1156c69a1a53b65c2be9ffa 1475967 libopenmpt_0.5.10.orig.tar.gz
 05c9982a2137b658953eb152ad31f584a5573d30314f6484161c4c82e9e547d3 10592 libopenmpt_0.5.10-1.debian.tar.xz
Files:
 ab7f3b1988f2f7e750a4a55cf6c624d2 2375 libs optional libopenmpt_0.5.10-1.dsc
 68aa0c70569fbfc78ad9a060cdf3b5c8 1475967 libs optional libopenmpt_0.5.10.orig.tar.gz
 b7b7542be2589573f22b5b8e82bfe6f8 10592 libs optional libopenmpt_0.5.10-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAmEctuYACgkQafL8UW6n
GZM1IA//bux90AmhoJl+9T2VgzDvB7fHF6DJM2vXaeJlCqKQXBS7GZcyWLSKAuXV
hEAnkwSnCd02ygJKStMJNENAUQEexmeVhwsqvnkoO7Wj4VefzM+nBslWUqgwd8Pn
y0qg1WlwzCkj9C/y2qtcGn2y4AJQUaGtuG2918pEW8uOMWgbRW9uRAKr3TcHzamR
Kzi1NNrxYdb5H9XoYh8XP4J55FcSov1hMmcYTuNwkn0+UXCSvWVQWRcvXnulHPNC
nIRboI2LoSpgoULprxlVlcsE1NZ9uLghew4mEBjjy2setbejK+ApxmRilQt+jI2E
nLXDQuJ4ZscaJLCcWPvzKNKgw0NqPyDP2MIKaHRfhfnHLVKoEjBS6nxA1tFzxJvY
gSVrsNqQ43RVvswJ3Iix2Prol95kFXVK5Bhtzmxm26RAVRg2KIb2ULhPBPv7aYSL
eGkV+99ZHGxEJFnSkvwqKZADpsD3E3jzyDvpNBYq29yU+4zl7HCGUso46mPNheh9
I2FcIwbB0VXCvxGcEjdHYkI65EgeYVsKUKe7mL1RTdONArcnkInm/FKYYjq3kdgq
bY4Z2APbx6A8roizixTe9Ngbl3cUz8W3BqNgqBpM/X+X97yHRCSwBo9fTdT7TMOh
tEyOVFTldtQ+ZISRms1Hod4G6dD6G5aaIMJ++iAXY+Tk1OaI87Q=
=S//4
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: