[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983109: Build vlc with srt support



Control: tags -1 wontfix

On 2021-02-19 16:34:48, Anton Lundin wrote:
> Package: vlc
> Version: 3.0.12-2
> 
> >From reading the rules file it looks like #962624 was the reason to not
> build vlc with srt support. It looks like that bug is fixed to me, and I
> think it would be nice to include srt support in vlc.
> 
> 
> I took a quick stab at building my own vlc with srt support but i got
> stpped by:
> 
> 
> access/srt.c: In function 'srt_schedule_reconnect':
> access/srt.c:144:5: warning: 'srt_socket' is deprecated [-Wdeprecated-declarations]
>   144 |     p_sys->sock = srt_socket( res->ai_family, SOCK_DGRAM, 0 );
>       |     ^~~~~
> In file included from access/srt.c:38:
> /usr/include/srt/srt.h:754:41: note: declared here
>   754 | SRT_ATR_DEPRECATED_PX SRT_API SRTSOCKET srt_socket(int, int, int) SRT_ATR_DEPRECATED;
>       |                                         ^~~~~~~~~~
> access/srt.c:168:37: error: 'SRTO_TSBPDDELAY' undeclared (first use in this function); did you mean 'SRTO_TSBPDMODE'?
>   168 |     srt_setsockopt( p_sys->sock, 0, SRTO_TSBPDDELAY,
>       |                                     ^~~~~~~~~~~~~~~
>       |                                     SRTO_TSBPDMODE
> 
> 
> So, there is some incompatibility still left there.

Given the recent commits
https://code.videolan.org/videolan/vlc-3.0/-/commit/3aad852a05d9a3b2469328cb9ea2e20b0acbce5c,
I don't expect vlc 3.0.x to gain support for srt 1.4.x. This needs to be
fixed upstream first. Once that's done, we can enable srt support again.

Cheers

> 
> //Anton
> 

-- 
Sebastian Ramacher


Reply to: