[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#980823: libffado: reduce Build-Depends



Source: libffado
Version: 2.4.2-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

libffado participates in a number of dependency cycles relevant to
architecture bootstrap. Instead of working on such a difficult problem,
I looked into easily droppable dependencies.

It turns out, that the mixer component is separated to an Arch: all
package. As such it should be possible to disable its build in an
arch-only build. That can be achieved by using BUILD_MIXER=false. Once
doing so, a number of pyqt dependencies can be moved over to B-D-I.
Besides, dbus is only used for testing and can be annotated <!nocheck>.
Finally, libexpat-dev is entirely unused as libffado uses libxml2
instead.

Please consider applying the attached patch.

Helmut
diff --minimal -Nru libffado-2.4.2/debian/changelog libffado-2.4.2/debian/changelog
--- libffado-2.4.2/debian/changelog	2019-09-23 21:39:37.000000000 +0200
+++ libffado-2.4.2/debian/changelog	2021-01-21 22:54:50.000000000 +0100
@@ -1,3 +1,14 @@
+libffado (2.4.2-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Reduce Build-Depends: (Closes: #-1)
+    + Drop libexpat-dev as SERIALIZE_USE_EXPAT is not set.
+    + Pass BUILD_MIXER=true/false for indep/arch to the build and demote pyqt
+      dependencies to Build-Depends-Indep.
+    + Annotate test dependency dbus with <!nocheck>.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Thu, 21 Jan 2021 22:54:50 +0100
+
 libffado (2.4.2-1) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru libffado-2.4.2/debian/control libffado-2.4.2/debian/control
--- libffado-2.4.2/debian/control	2019-09-23 20:49:45.000000000 +0200
+++ libffado-2.4.2/debian/control	2021-01-21 22:54:50.000000000 +0100
@@ -7,7 +7,7 @@
  Jonas Smedegaard <dr@jones.dk>,
 Build-Depends:
  cdbs,
- dbus (>= 1.0.0),
+ dbus (>= 1.0.0) <!nocheck>,
 # Until CDBS does support debhelper 11, see #885407.
  debhelper (>= 10),
  dh-python,
@@ -15,18 +15,18 @@
  libdbus-1-dev,
  libdbus-c++-bin,
  libdbus-c++-dev,
- libexpat1-dev,
  libiec61883-dev (>= 1.1.0),
  libraw1394-dev (>= 1.3.0),
  libxml++2.6-dev,
  libxml2-dev (>= 2.6.13),
  pkg-config,
- pyqt5-dev-tools,
  python3,
+ scons,
+Build-Depends-Indep:
+ pyqt5-dev-tools,
  python3-dbus,
  python3-dbus.mainloop.pyqt5,
  python3-pyqt5,
- scons,
 Standards-Version: 4.4.0
 Section: libs
 Homepage: http://www.ffado.org/
diff --minimal -Nru libffado-2.4.2/debian/rules libffado-2.4.2/debian/rules
--- libffado-2.4.2/debian/rules	2019-09-23 21:33:58.000000000 +0200
+++ libffado-2.4.2/debian/rules	2021-01-21 22:54:50.000000000 +0100
@@ -32,8 +32,10 @@
   DETECT_USERSPACE_ENV=0 \
   $(patsubst parallel=%,-j%,$(filter parallel=%,$(DEB_BUILD_OPTIONS))) \
   ENABLE_OPTIMIZATION=no
-common-build-arch common-build-indep::
-	$(scons) DEBUG=0
+common-build-arch::
+	$(scons) BUILD_MIXER=false DEBUG=0
+common-build-indep::
+	$(scons) BUILD_MIXER=true DEBUG=0
 common-install-arch common-install-indep::
 	$(scons) DEBUG=0 install
 clean::

Reply to: