[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#966241: marked as done (x264 FTBFS with make 4.2)



Your message dated Sun, 26 Jul 2020 15:22:42 +0000
with message-id <E1jziU6-000AeC-Jx@fasolo.debian.org>
and subject line Bug#966241: fixed in x264 2:0.160.3011+gitcde9a93-2
has caused the Debian Bug report #966241,
regarding x264 FTBFS with make 4.2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
966241: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966241
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: x264
Version: 2:0.159.2999+git296494a-2
Severity: serious
Tags: patch

Make 4.3 changed the escaping rules with the # symbol is used inside a parameter to functions like $shell.
Previously it needed to be escaped, now it needs to *not* be escaped. A change was applied to the debian x264 package
recently "debian/rules: Fix awk invocation" which presumablly fixed the build with make 4.3 but causes it to fail under 4.2
with the following error.

dpkg-buildpackage: info: host architecture amd64
 debian/rules clean
debian/rules:3: *** unterminated call to function 'shell': missing ')'.  Stop.
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
This has been seen on both reproducible builds and on the raspbian autoforwardporter.

The upstream suggested solution to make a makefile that works with both 4.2 and 4.3 is to use a variable.
I implemented that soloution and uploaded to Raspbian. The patch I used can be found at

https://github.com/raspbian-packages/x264/commit/8b4de154127fdb95874d4d632431bbbabb3cbf64

If make 4.3 migrates to testing and this bug is not already fixed I will downgrade it. I still think this should
be fixed even if/when bullseye gets 4.3 to make life easier for backporters.

I do not have any immediate plans to NMU this, but this may change if the release gets
closer and make 4.3 is still not in testing.

--- End Message ---
--- Begin Message ---
Source: x264
Source-Version: 2:0.160.3011+gitcde9a93-2
Done: Sebastian Ramacher <sramacher@debian.org>

We believe that the bug you reported is fixed in the latest version of
x264, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 966241@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <sramacher@debian.org> (supplier of updated x264 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 26 Jul 2020 16:52:56 +0200
Source: x264
Architecture: source
Version: 2:0.160.3011+gitcde9a93-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sebastian Ramacher <sramacher@debian.org>
Closes: 966241
Changes:
 x264 (2:0.160.3011+gitcde9a93-2) unstable; urgency=medium
 .
   * Team upload
   * Upload to unstable
   * debian/rules: Fix awk invocation to work with make 4.2 and 4.3 (Closes:
     #966241)
Checksums-Sha1:
 24c90aa46891cc4ac4c4d48e29e21a1df506c372 2365 x264_0.160.3011+gitcde9a93-2.dsc
 6aaaefe5bc0652efe6502455e25762d1b106f985 23228 x264_0.160.3011+gitcde9a93-2.debian.tar.xz
Checksums-Sha256:
 f2c138aa9037ca2a16104428c8495671282db8919e0063432a60e9187ec04be9 2365 x264_0.160.3011+gitcde9a93-2.dsc
 4cfb4e2abd4ac11db7a3d112348aa193992e52b2eebe686d41213405dac0a09c 23228 x264_0.160.3011+gitcde9a93-2.debian.tar.xz
Files:
 433d71a2c2aa765e01011e99f0cdc496 2365 libs optional x264_0.160.3011+gitcde9a93-2.dsc
 32ba42934b7c4da760f16caf29ba5a2b 23228 libs optional x264_0.160.3011+gitcde9a93-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAl8dmhUACgkQafL8UW6n
GZO8dxAAjwr1ly6Jr0woW2lckfcxMIGNvWnWBCU325dKGYmUIunVzMLHbG3ywYb7
u4CWPtv/5DIFjIAkL3tcQTfoY3fpmR4AT9FrOdk+LkMWcDfW9Aorar2oYHaRenja
gOjp/Eb7o9LGXlTBm2JB7+KTmjl8OX2MmcvX7l0IxIqenOo7IVz+zqmaeOeQGSn2
sygeb4el9gOiq0a+CYp5ae+Fsv7UaZgTP8RhbJInDEbGkA5W9In5QM6g/6rux8Up
EJnqKdNxA8f1xI9Oq3h1witDY6pZh0V+feNSSJswN5TC8xxfofdwmxSjX2wkGq8W
Hjc5bd91E4P/PV3T9OC4QtrQrX+fGwYqpfL4PbiFsjovABSOv3Xi5UKQ4t31a47N
vpipQmwKzT8fM6r2UEcMj2cYcEPTs5/JZsqskzMI4PBljnEuF9ao6PGuMW7fKkRN
qyoJSUYqQ+PRaP23R9XmM1sgLfy0/wsVjtaYqcVY3DT5r2mQKc0K1OOoNdUnOkZH
11H5FKlQNIGj2RITYTdYOhUR8rjzIaGbYScrECI1Fh3HVQr1xhIJYZX7/kkGs4p8
M57fZ4rkcnR8duml5v1aCDJGWT6Ni2mDRP3N9AomUdHO8pLqLP2o0xNf2e/nqI38
0//ltv5tRkglYf7sXqZ9wWfm8Tsd4KKt9b0k0aewdgzV98IQisQ=
=OfvN
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: