[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#925754: Fixed in newer release of libopenshot / libopenshot-audio



Control: block 925754 by 925755
Control: notforwarded 925754
Control: forwarded 925755 https://github.com/OpenShot/libopenshot-audio/issues/33

Hi,

> On Wed, 29 Jan 2020 10:08:55 +0100 Matthias Klose <doko@debian.org> wrote:
> > libopenshot-audio 0.1.8 still fails to build
> 
> Quite right, sorry. libopenshot-audio-0.1.8 fixed building with GCC *less
> than* 9,
> but GCC9 coming along broke it again.
> 
> On Fedora / RPM Fusion we were building with commit 7001b68[1],
> which was at the time an unreleased commit on the development branch.
> 
> However, since then both 0.1.9 and 0.2.0 have been released,
> including fixes to build with GCC 9 and 10 respectively, IIRC.
> (I know 0.2.0 builds with GCC 10 for sure, since I've done it myself.)
> 
> Current releases:
> 
> libopenshot-audio-0.2.0:
> https://github.com/OpenShot/libopenshot-audio/archive/v0.2.0.tar.gz
> 
> libopenshot-0.2.5:
> https://github.com/OpenShot/libopenshot/archive/v0.2.5.tar.gz
> 
> OpenShot 2.5.1 (openshot-qt):
> https://github.com/OpenShot/openshot-qt/archive/v2.5.1.tar.gz
> 
> 
> [1]:
> https://github.com/OpenShot/libopenshot-audio/commit/7001b68787c0881a44bcafba98cccae509a31644

libopenshot-audio builds with Clang without any modifications. Using this
OpenShot (again with Clang) gets a bit farther:
/usr/include/libopenshot-audio/JuceLibraryCode/modules/juce_audio_basics/../juce_core/unit_tests/juce_UnitTest.h:73:17: note: candidate found by name lookup is 'juce::UnitTest'
class JUCE_API  UnitTest
                ^
/<<PKGBUILDDIR>>/tests/Cache_Tests.cpp:50:2: error: reference to 'UnitTest' is ambiguous

I've seen this is fixed in a commit upstream, and I think cherrypicking it
helped, but the -audio Debian package uses the Juce embedded code copies
instead of the ones in juce-modules-source as best as I can tell.

I'm uneasy about this and hope that a new release of OpenShot made with the
practices described in /usr/share/doc/juce-modules-source/README.Debian will
make an elegant solution.

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: