On 2020-04-21 12:49:09 +0800, Yangfl wrote: > Jonas Smedegaard <jonas@jones.dk> 于2020年4月20日周一 下午7:29写道： > > > > Quoting Sebastian Ramacher (2020-04-20 13:20:59) > > > On 2020-04-20 13:07:40 +0200, Jonas Smedegaard wrote: > > > > Quoting Sebastian Ramacher (2020-04-20 12:51:09) > > > > > On 2020-04-20 09:06:51, Yangfl wrote: > > > > > > As libjsonparser-dev is now available, please consider linking > > > > > > against system library instead of bundled json.c. > > > > > > > > > > The last release of libjsonparser was in 2014. In the meantime, vlc's > > > > > copy has seen some fixes (more so in the master branch than the > > > > > current version in Debian). Are there any plans upstream to release a > > > > > new version of libjsonparser? I don't think switching vlc to an older > > > > > libjsonparser makes sense. > > > > > > > > Seems you are asking the wrong place: Upstream developers of > > > > libjsonparser propably don't follow this bugreport. > > > > > > > > Probably helpful to go the other way: Inform libjsonparser upstream (or > > > > at least Debian maintainers ot its package) about fixes existing > > > > downstream in VLC. > > > > > > Yangfl is the package maintainer of libjsonparser in Debian … > > > > Good point. > > > > Still, better to share issues with libjsonparser as a bugreport against > > libjsonparser rather than here. > > > > - Jonas > > > I reviewed json.c in vlc and it seems an outdated version (1.0.0) > rather than 1.1.0. Some problems (like 'Fix check for > json_relaxed_commas') already fixed in 1.1.0 in another way. Other > fixes https://github.com/videolan/vlc/commits/master/modules/misc/webservices/json.c > are all minor but I will pick them into Debian package. Okay, thanks for the investigation. But anyway, is libjsonparser's upstream still active? No release since 2014 doesn't suggest that they are. If that is not the case and we end up with libjsonparser being maintained in Debian, this means that changing vlc to libjsonparser is not upstreamable. Due to the size and security history of vlc, I'd like to avoid that. Cheers -- Sebastian Ramacher
Attachment:
signature.asc
Description: PGP signature