[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#923940: [libtheoraenc] What resolution were you looking for?



On Tue, 2020-04-14 at 22:17 -0700, Ralph Giles wrote:

> Looking at this bug, I don't understand what exactly you're reporting.

I'm reporting underlinking at the ELF file level.

> libtheoraenc does depend on libtheoradec, so applications need to
> link to both. This is declared in the pkg-config file:

Generally one should only link a program with libraries that provide
symbols that are directly used by the program. There are lots of tools
that warn about unused libraries, especially dpkg-shlibdeps/adequate.

>     $ pkg-config --libs theoraenc
>     -ltheoraenc -ltheoradec -logg

Even when a program is linked using the flags suggested by pkg-config,
IIRC there are some GCC flags that ask the linker to drop dependencies
on unused libs, so a program linking against libtheoraenc.pc libs but
not libtheoradec.pc could have their libtheoradec linkage dropped and
then the program would fail to start because libtheoraenc references
libtheoradec symbols but neither of the the ELF files for the program
nor libtheoraenc depend on libtheoradec so it doesn't get loaded.

> Do you want libtheoraenc.so to declare the dependency internally so
> bare -ltheoraenc works on (some) linkers without bothering with
> pkg-config?

If libtheoraenc uses some functions from libtheoradec then it should
link against libtheoradec.

> Petters patch will remove the dependency entirely,

I'm not sure this is the correct solution, since it duplicates
libtheoradec functions inside libtheoraenc and might also add those
functions to the ABI of libtheoraenc.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: