Bug#955397: opencollada FTCBFS for mipsen: broken architecture detection
Source: opencollada
Version: 0.1.0~20180719.619d942+dfsg0-2
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs
opencollada fails to cross build from source for mipsen. It has a symbol
"mips" somewhere and therefore passes -Umips when building on mipsen
However, when cross building for mipsen, the flag isn't passed. Rather
than checking the uname output, please use CMAKE_SYSTEM_PROCESSOR.
Please consider applying the attached patch.
Helmut
--- opencollada-0.1.0~20180719.619d942+dfsg0.orig/CMakeLists.txt
+++ opencollada-0.1.0~20180719.619d942+dfsg0/CMakeLists.txt
@@ -1,6 +1,3 @@
-EXECUTE_PROCESS( COMMAND uname -m COMMAND tr -d '\n' OUTPUT_VARIABLE ARCHITECTURE )
-message( STATUS "Architecture: ${ARCHITECTURE}" )
-
if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_BINARY_DIR})
if(NOT DEFINED WITH_IN_SOURCE_BUILD)
message(FATAL_ERROR
@@ -65,7 +62,7 @@
else()
target_link_libraries(${name}_static ${target_lib})
endif()
- if( ${ARCHITECTURE} MATCHES "mips" )
+ if( ${CMAKE_SYSTEM_PROCESSOR} MATCHES "mips" )
if(TARGET OpenCOLLADASaxFrameworkLoader_static)
SET_TARGET_PROPERTIES(OpenCOLLADASaxFrameworkLoader_static PROPERTIES COMPILE_FLAGS "-Umips")
endif()
@@ -91,7 +88,7 @@
else()
target_link_libraries(${name}_shared ${target_lib})
endif()
- if( ${ARCHITECTURE} MATCHES "mips" )
+ if( ${CMAKE_SYSTEM_PROCESSOR} MATCHES "mips" )
if(TARGET OpenCOLLADASaxFrameworkLoader_shared)
SET_TARGET_PROPERTIES(OpenCOLLADASaxFrameworkLoader_shared PROPERTIES COMPILE_FLAGS "-Umips")
endif()
Reply to: