Bug#954658: qjackctl: Frames/Period setting not always saved when it's the only setting changed.
Package: qjackctl
Version: 0.6.1-1
Severity: normal
Tags: patch upstream
Dear Maintainer,
QJackCtl doesn't always save the Frames/Period setting properly if it's the only
setting changed in the setup window. (It persists in the UI when the setup
window is closed and reopened, but it isn't written to disk and the Jack server
uses the previous setting when relaunched.) I've written and included a
patch to address the issue.
Cheers,
Aaron
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.4.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages qjackctl depends on:
ii jackd 5+nmu1
ii libasound2 1.2.2-2.1
ii libc6 2.30-2
ii libgcc-s1 10-20200312-2
ii libjack-jackd2-0 [libjack-0.125] 1.9.12~dfsg-2+b1
ii libqt5core5a 5.12.5+dfsg-9
ii libqt5dbus5 5.12.5+dfsg-9
ii libqt5gui5 5.12.5+dfsg-9
ii libqt5network5 5.12.5+dfsg-9
ii libqt5widgets5 5.12.5+dfsg-9
ii libqt5xml5 5.12.5+dfsg-9
ii libstdc++6 10-20200312-2
qjackctl recommends no packages.
Versions of packages qjackctl suggests:
ii pulseaudio-utils 13.0-5
-- no debconf information
Make sure the frames setting is saved when it's the only setting that's changed.
Index: qjackctl-0.6.1/src/qjackctlSetupForm.cpp
===================================================================
--- qjackctl-0.6.1.orig/src/qjackctlSetupForm.cpp
+++ qjackctl-0.6.1/src/qjackctlSetupForm.cpp
@@ -1612,7 +1612,7 @@ void qjackctlSetupForm::apply (void)
if (pMainForm == nullptr)
return;
- if (m_iDirtySettings > 0 || m_iDirtyPreset > 0) {
+ if (m_iDirtySettings > 0 || m_iDirtyPreset > 0 || m_iDirtyBuffSize > 0) {
// Save current preset selection.
m_pSetup->sDefPreset = m_ui.PresetComboBox->currentText();
// Always save current settings...
Reply to: