[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#950705: marked as done (zita-resampler FTCBFS: incomplete patch application, new issue)

Your message dated Sun, 15 Mar 2020 21:00:58 +0000
with message-id <E1jDaNW-0008fv-Me@fasolo.debian.org>
and subject line Bug#950705: fixed in zita-resampler 1.6.2-2
has caused the Debian Bug report #950705,
regarding zita-resampler FTCBFS: incomplete patch application, new issue
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
950705: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950705
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: zita-resampler
Version: 1.6.2-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

zita-resampler fails to cross build from source. This was already
reported and supposedly fixed in #897049. However, the debian/rules
portion of that patch went somehow missing.

In addition to that, upstream introduce a new dependency. Building the
apps directory now depends on an installation of the source directory in
DESTDIR (notice the -I$(DESTDIR)/usr/include) flag. Therefore it must be
built after installing the source directory. Failing to do that results
in building again during make install - with the wrong compiler.

Please consider applying the attached patch. Please also consider
whether this DESTDIR hack in apps/Makefile is appropriate. The DESTDIR
variable is not meant to influence the build at all and it turns out to
have surprising effects here. It certainly fails the principle of least
surprise.

Helmut

diff --minimal -Nru zita-resampler-1.6.2/debian/changelog zita-resampler-1.6.2/debian/changelog
--- zita-resampler-1.6.2/debian/changelog	2020-02-03 20:45:07.000000000 +0100
+++ zita-resampler-1.6.2/debian/changelog	2020-02-05 06:08:43.000000000 +0100
@@ -1,3 +1,12 @@
+zita-resampler (1.6.2-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_build pass cross tools to make.
+    + app/ build needs source/ install.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 05 Feb 2020 06:08:43 +0100
+
 zita-resampler (1.6.2-1) unstable; urgency=medium
 
   * Team upload
diff --minimal -Nru zita-resampler-1.6.2/debian/rules zita-resampler-1.6.2/debian/rules
--- zita-resampler-1.6.2/debian/rules	2020-02-03 20:32:46.000000000 +0100
+++ zita-resampler-1.6.2/debian/rules	2020-02-05 06:08:43.000000000 +0100
@@ -19,8 +19,8 @@
 override_dh_auto_install:
 	dh_auto_install
 	$(MAKE) -C source/ DESTDIR=$(DESTDIR)
-	$(MAKE) -C apps/ DESTDIR=$(DESTDIR)
 	$(MAKE) -C source/ DESTDIR=$(DESTDIR) install
+	dh_auto_build -Dapps -- DESTDIR=$(DESTDIR)
 	$(MAKE) -C apps/ DESTDIR=$(DESTDIR) install
 	dh_install -plibzita-resampler-doc docs/* usr/share/doc/libzita-resampler-doc/docs/

--- End Message ---
--- Begin Message --- 
Source: zita-resampler
Source-Version: 1.6.2-2
Done: Dennis Braun <d_braun@kabelmail.de>

We believe that the bug you reported is fixed in the latest version of
zita-resampler, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 950705@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <d_braun@kabelmail.de> (supplier of updated zita-resampler package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 15 Mar 2020 17:07:31 +0100
Source: zita-resampler
Architecture: source
Version: 1.6.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <d_braun@kabelmail.de>
Closes: 950705
Changes:
 zita-resampler (1.6.2-2) unstable; urgency=medium
 .
   * Fix FTCBFS (Closes: #950705) Thanks to Helmut Grohne!
   * Add me as an uploader
   * Fix build
Checksums-Sha1:
 dbb49fa7fe423960a2063b43dfe10736b4b74a49 2308 zita-resampler_1.6.2-2.dsc
 ba1c3533493e1fe13512f53a189185daa300ea77 6860 zita-resampler_1.6.2-2.debian.tar.xz
Checksums-Sha256:
 4ad16f7d4ed257729d9d31005c8af55848c982c6083125e127aaeb2f8294d03f 2308 zita-resampler_1.6.2-2.dsc
 5f36f062513b6f554b85153a78d02b7c6c70509a3cda7be7870904c65461b906 6860 zita-resampler_1.6.2-2.debian.tar.xz
Files:
 965241f0542d6b9f3578a3a9399dbfa1 2308 sound optional zita-resampler_1.6.2-2.dsc
 f5c7a5c7591ad4202e1cdf03f598b584 6860 sound optional zita-resampler_1.6.2-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAl5uU9EACgkQafL8UW6n
GZMoNhAAuHz7T9uBxJUJp3tyBif4cH43tEpO/Fvd7doy8yu98/WLyPzZFonmucdN
3r57gMEJoIVMECDEaXQ7UE90QUx3PYDMZDdWc0LtcVaiDEqow/6jwlJrI424reMJ
7D8vh4tgdq7rLdxlWq0EWobrF1Ds7ePW/hKwkXTT/VfuuDU3i+G2JdUsIfBpNqPq
sWqTJnX4j5aZLKTJhT6al+hBvkFxgtkOl3Li9lm/bD81vbH6XzHnlpZ3paz2NS1e
bqjvcd3wR41d5ydt4hJQCNJS127X5jBFj9ASttr3tBLzSIvxYETCFDUQxQnXJ6zK
sMfJhywFiM40Wj3r7FqKsmZNsoXRMJBQX26JYAwN0HerXczuIIaD/aURcMm7QgX7
qI3bcy8+1rd4WDWNjFbkHFdGw1GojxbyQbSzLWY0Fj4lGbThKmG4A9yWa1VsBgK3
anaeH+Ql7/eAAmUb+MTe5z4dUwm7OB8UqpP4FdidsefXNzuvjvA5Z0+Fx81j6c2e
xU2MzvhONdbpnmQzKPhLIK6nOQvYInrTsOzTTvApPRLhcsbe2DLnx098VqKI5d6F
4u1CvOPwb88wyysVasWPYDNM9Susbb+unkJUXhFtXkx0kfLpZPo1UD2ez0hz3/y1
OCLivXVKwIwtjXyEXUlNcoVWguxSYg+nDvs/08lU75xp2VkeH9M=
=wExO
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: