[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#900887: marked as done (ir.lv2 FTCBFS: uses build architecture build tools)

Your message dated Sun, 01 Mar 2020 19:49:54 +0000
with message-id <E1j8Ub4-000Enu-T4@fasolo.debian.org>
and subject line Bug#900887: fixed in ir.lv2 1.3.4~dfsg0-2
has caused the Debian Bug report #900887,
regarding ir.lv2 FTCBFS: uses build architecture build tools
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
900887: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900887
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ir.lv2
Version: 1.3.3~dfsg0-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

ir.lv2 fails to cross build from source, because it uses build
architecture build tools. The attached patch makes ir.lv2 cross
buildable. It fixes both the upstream build system to make build tools
substitutable as well as teaching debian/rules to pass the required
tools. Please consider applying it.

Helmut

diff --minimal -Nru ir.lv2-1.3.3~dfsg0/debian/changelog ir.lv2-1.3.3~dfsg0/debian/changelog
--- ir.lv2-1.3.3~dfsg0/debian/changelog	2016-12-18 16:27:46.000000000 +0100
+++ ir.lv2-1.3.3~dfsg0/debian/changelog	2018-06-06 12:40:41.000000000 +0200
@@ -1,3 +1,13 @@
+ir.lv2 (1.3.3~dfsg0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + cross.patch: Make build tools substitutable.
+    + Let dh_auto_build pass cross tools to make.
+    + Also pass PKG_CONFIG to make clean.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 06 Jun 2018 12:40:41 +0200
+
 ir.lv2 (1.3.3~dfsg0-1) unstable; urgency=medium
 
   * Update watch file.
diff --minimal -Nru ir.lv2-1.3.3~dfsg0/debian/patches/cross.patch ir.lv2-1.3.3~dfsg0/debian/patches/cross.patch
--- ir.lv2-1.3.3~dfsg0/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ ir.lv2-1.3.3~dfsg0/debian/patches/cross.patch	2018-06-06 12:40:41.000000000 +0200
@@ -0,0 +1,67 @@
+--- ir.lv2-1.3.3~dfsg0.orig/Makefile
++++ ir.lv2-1.3.3~dfsg0/Makefile
+@@ -10,48 +10,49 @@
+ INST_FILES = ir.so ir_gui.so ir.ttl manifest.ttl
+ 
+ # change "-O2 -ffast-math" to "-g -O0" below if you want to debug the plugin
+-CPPFLAGS += -Wall -I. -I/usr/include `pkg-config --cflags gtk+-2.0` `pkg-config --cflags gthread-2.0` -D__STDC_FORMAT_MACROS -g -O2 -ffast-math
+-LIBS += -lc -lm -lzita-convolver -lsamplerate -lsndfile `pkg-config --libs gthread-2.0` `pkg-config --libs gtk+-2.0`
++PKG_CONFIG ?= pkg-config
++CPPFLAGS += -Wall -I. -I/usr/include `$(PKG_CONFIG) --cflags gtk+-2.0` `$(PKG_CONFIG) --cflags gthread-2.0` -D__STDC_FORMAT_MACROS -g -O2 -ffast-math
++LIBS += -lc -lm -lzita-convolver -lsamplerate -lsndfile `$(PKG_CONFIG) --libs gthread-2.0` `$(PKG_CONFIG) --libs gtk+-2.0`
+ 
+-ifeq ($(shell pkg-config --atleast-version='2.16' gtk+-2.0; echo $$?), 1)
++ifeq ($(shell $(PKG_CONFIG) --atleast-version='2.16' gtk+-2.0; echo $$?), 1)
+    $(error "At least GTK+ version 2.16 is needed to build IR.")
+ endif
+ 
+-ifeq ($(shell pkg-config --atleast-version='2.20' gtk+-2.0; echo $$?), 0)
++ifeq ($(shell $(PKG_CONFIG) --atleast-version='2.20' gtk+-2.0; echo $$?), 0)
+    CPPFLAGS += -D_HAVE_GTK_ATLEAST_2_20
+ endif
+ 
+-C4CFLAGS = -Wall -I. -I/usr/include `pkg-config --cflags gthread-2.0` -O2 -ffast-math
+-C4LIBS = -lsndfile `pkg-config --libs gthread-2.0`
++C4CFLAGS = -Wall -I. -I/usr/include `$(PKG_CONFIG) --cflags gthread-2.0` -O2 -ffast-math
++C4LIBS = -lsndfile `$(PKG_CONFIG) --libs gthread-2.0`
+ 
+ all: ir.so ir_gui.so
+ 
+ ir.o: ir.cc ir.h ir_utils.h
+-	g++ ir.cc $(CPPFLAGS) -c -fPIC -o ir.o
++	$(CXX) ir.cc $(CPPFLAGS) -c -fPIC -o ir.o
+ 
+ ir_gui.o: ir_gui.cc ir.h ir_utils.h ir_wavedisplay.h
+-	g++ ir_gui.cc $(CPPFLAGS) -c -fPIC -o ir_gui.o
++	$(CXX) ir_gui.cc $(CPPFLAGS) -c -fPIC -o ir_gui.o
+ 
+ ir_utils.o: ir_utils.cc ir_utils.h ir.h
+-	g++ ir_utils.cc $(CPPFLAGS) -c -fPIC -o ir_utils.o
++	$(CXX) ir_utils.cc $(CPPFLAGS) -c -fPIC -o ir_utils.o
+ 
+ ir_meter.o: ir_meter.cc ir_meter.h ir.h ir_utils.h
+-	g++ ir_meter.cc $(CPPFLAGS) -c -fPIC -o ir_meter.o
++	$(CXX) ir_meter.cc $(CPPFLAGS) -c -fPIC -o ir_meter.o
+ 
+ ir_modeind.o: ir_modeind.cc ir_modeind.h ir.h ir_utils.h
+-	g++ ir_modeind.cc $(CPPFLAGS) -c -fPIC -o ir_modeind.o
++	$(CXX) ir_modeind.cc $(CPPFLAGS) -c -fPIC -o ir_modeind.o
+ 
+ ir_wavedisplay.o: ir_wavedisplay.cc ir_wavedisplay.h ir.h ir_utils.h
+-	g++ ir_wavedisplay.cc $(CPPFLAGS) -c -fPIC -o ir_wavedisplay.o
++	$(CXX) ir_wavedisplay.cc $(CPPFLAGS) -c -fPIC -o ir_wavedisplay.o
+ 
+ ir.so: ir.o ir_utils.o
+-	g++ $(LDFLAGS) ir.o ir_utils.o $(LIBS) -shared -o ir.so
++	$(CXX) $(LDFLAGS) ir.o ir_utils.o $(LIBS) -shared -o ir.so
+ 
+ ir_gui.so: ir_gui.o ir_utils.o ir_meter.o ir_modeind.o ir_wavedisplay.o
+-	g++ $(LDFLAGS) ir_gui.o ir_utils.o ir_meter.o ir_modeind.o ir_wavedisplay.o $(LIBS) -shared -z nodelete -o ir_gui.so
++	$(CXX) $(LDFLAGS) ir_gui.o ir_utils.o ir_meter.o ir_modeind.o ir_wavedisplay.o $(LIBS) -shared -z nodelete -o ir_gui.so
+ 
+ convert4chan: convert4chan.c
+-	gcc $(C4CFLAGS) $(CPPFLAGS) $(LDFLAGS) convert4chan.c $(C4LIBS) -o convert4chan
++	$(CC) $(C4CFLAGS) $(CPPFLAGS) $(LDFLAGS) convert4chan.c $(C4LIBS) -o convert4chan
+ 
+ install: all
+ 	mkdir -p $(INSTDIR)
diff --minimal -Nru ir.lv2-1.3.3~dfsg0/debian/patches/series ir.lv2-1.3.3~dfsg0/debian/patches/series
--- ir.lv2-1.3.3~dfsg0/debian/patches/series	2016-12-18 16:27:46.000000000 +0100
+++ ir.lv2-1.3.3~dfsg0/debian/patches/series	2018-06-06 12:39:26.000000000 +0200
@@ -1 +1,2 @@
 04-allow_debbug.patch
+cross.patch
diff --minimal -Nru ir.lv2-1.3.3~dfsg0/debian/rules ir.lv2-1.3.3~dfsg0/debian/rules
--- ir.lv2-1.3.3~dfsg0/debian/rules	2016-12-18 16:27:46.000000000 +0100
+++ ir.lv2-1.3.3~dfsg0/debian/rules	2018-06-06 12:40:41.000000000 +0200
@@ -1,6 +1,9 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
 
+-include /usr/share/dpkg/buildtools.mk
+export PKG_CONFIG ?= pkg-config
+
 LDFLAGS+=-Wl,--as-needed
 export REPACK_SH=$(CURDIR)/debian/repack.sh
 
@@ -11,7 +14,7 @@
 
 override_dh_auto_build:
 	dh_auto_build
-	make convert4chan
+	dh_auto_build -- convert4chan
 
 override_dh_auto_install:
 	dh_auto_install

--- End Message ---
--- Begin Message --- 
Source: ir.lv2
Source-Version: 1.3.4~dfsg0-2
Done: Dennis Braun <d_braun@kabelmail.de>

We believe that the bug you reported is fixed in the latest version of
ir.lv2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 900887@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <d_braun@kabelmail.de> (supplier of updated ir.lv2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 01 Mar 2020 20:21:11 +0100
Source: ir.lv2
Architecture: source
Version: 1.3.4~dfsg0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <d_braun@kabelmail.de>
Closes: 900887
Changes:
 ir.lv2 (1.3.4~dfsg0-2) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #900887)
     + Pass PKG_CONFIG to make clean
     + Let dh_auto_build pass cross tools to make
 .
   [ Dennis Braun ]
   * d/control:
     + Add me as uploader
     + Set RRR: no
   * d/rules:
     + Simplify convert4chan installation
     + Remove export REPACK_SH
     + Remove get-orig-source, obsolete
   * d/patches:
     + Fix non-root build
     + Refresh cross patch
   * Add d/upstream/metadata
Checksums-Sha1:
 0e542aef0fd49a7d8ee2baab87267a8df74a88d7 2158 ir.lv2_1.3.4~dfsg0-2.dsc
 7da5b78ec1df7e43bed3fd8fa5400c2f3c6fe84e 5284 ir.lv2_1.3.4~dfsg0-2.debian.tar.xz
Checksums-Sha256:
 7c7b82ded82b0076eec18feb3449d372f71d163b7971b2f29434d75896ddb52a 2158 ir.lv2_1.3.4~dfsg0-2.dsc
 e71645f8b6685c99ce8299de79d1c56eff20fcf6e35fb7ab85011b12ca0c2de3 5284 ir.lv2_1.3.4~dfsg0-2.debian.tar.xz
Files:
 4c365711527bbec5d7741cd9c524dd24 2158 sound optional ir.lv2_1.3.4~dfsg0-2.dsc
 5f979404dc9fa0625532482b7c29fc59 5284 sound optional ir.lv2_1.3.4~dfsg0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAl5cC5MACgkQafL8UW6n
GZP3IA/9Fpg/2dnY7ER9wfxYJhItu8x9R1vDPS5fAY3e4nmYOWdJLprWgLQ6qwRj
7xT/DTDEyoiH4KFVUTq4sYn64vZ4DBLLtMTVt+0IkQmw2Fz8gkGqNywNIVr/7zOp
n9T+UFSK3YcJFWw+nw9YjOM4XFgBWmCf8DbK5Kfjuy7cX6Zbk3kfHI7j+sakBcAo
zbAvrrp/0DWZL8JHzdQK0eGTcudkR4bYaD+H1JCx2jw5VQ0cESnzaMEzAQ2XZM2V
9cnE95W1vPdX+TsR7mYNCciK7HzmX1wFLSwNSpqUnvNfxW93db+DQDq6t1awPtUh
V9dF4aT4Qd5oJ+bUBnd4WUqyJV85OBc/P+A4EIYe++gmYtH911UPdIoEQf9OzAFM
rxPpVommu7TIYetbm7UKDVvPdOKtzXKIBMBfXxMluJPWuSYVbFGbFcp7MLXDNkjA
4FqD3UveEUjwS+U/8gINKkN6K9DmhmzpIWyiIhDsGXjTtQeaFsoYqT8ilxpOehYX
zQTgUUVRe6e5Cp8Ez4ZkQZ0lktUAK0y784ypKh8AjLaBf2DPjgQmKzYA46r5DjRe
DiFbu5zGMZLxagJaTYuIAerHePV4pqGl4ulim/qW7XFQ9F6rf7li5V88xQ8ac893
WOYhpME7G+/NEiAg9RIpge2QApTnS5pJ7k1EdZ7css1XZ1DHAFs=
=4SGN
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: