[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#949817: marked as done (shotcut: please make the build reproducible)



Your message dated Mon, 03 Feb 2020 05:04:56 +0000
with message-id <E1iyTuq-00075u-3m@fasolo.debian.org>
and subject line Bug#949817: fixed in shotcut 19.12.31-2
has caused the Debian Bug report #949817,
regarding shotcut: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
949817: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949817
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: shotcut
Version: 19.12.31-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
shotcut could not be built reproducibly.

This is because it uses the current build date for the SHOTCUT_VERSION
variable. A patch is attached that bases this value on
SOURCE_DATE_EPOCH [1] instead.

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/specs/source-date-epoch/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2020-01-25 11:52:56.730142822 +0000
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2020-01-25
+
+--- shotcut-19.12.31.orig/src/src.pro
++++ shotcut-19.12.31/src/src.pro
+@@ -323,7 +323,7 @@ debug_and_release {
+ LIBS += -lCuteLogger
+ 
+ isEmpty(SHOTCUT_VERSION) {
+-    !win32:SHOTCUT_VERSION = $$system(date "+%y.%m.%d")
++    !win32:SHOTCUT_VERSION = $$system(date --utc --date="@${SOURCE_DATE_EPOCH:-$(date +%s)}" "+%y.%m.%d")
+      win32:SHOTCUT_VERSION = adhoc
+ }
+ DEFINES += SHOTCUT_VERSION=\\\"$$SHOTCUT_VERSION\\\"
--- a/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series	2020-01-25 11:52:55.762163756 +0000
@@ -0,0 +1 @@
+reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: shotcut
Source-Version: 19.12.31-2

We believe that the bug you reported is fixed in the latest version of
shotcut, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 949817@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Myczko <gurkan@phys.ethz.ch> (supplier of updated shotcut package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 03 Feb 2020 05:17:34 +0100
Source: shotcut
Architecture: source
Version: 19.12.31-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Gürkan Myczko <gurkan@phys.ethz.ch>
Closes: 949817
Changes:
 shotcut (19.12.31-2) unstable; urgency=medium
 .
   * Bump standards version to 4.5.0
   * Apply patch for reproducible builds. (Closes: #949817)
     Thanks Chris Lamby.
Checksums-Sha1:
 ef5db0f1c214d460c3b748113a194ceaa10869cb 2263 shotcut_19.12.31-2.dsc
 cbb113bd930256e2dbb89247ac04a7776e03bd3d 9616 shotcut_19.12.31-2.debian.tar.xz
 b0af5e15a54a1c31308f062696098769608996ad 8451 shotcut_19.12.31-2_source.buildinfo
Checksums-Sha256:
 ca87ccffa75cf58c715ba380db6ede3284e54fab0236b36e1e0132ba4e4799f2 2263 shotcut_19.12.31-2.dsc
 69e445f983e4a7bafdc5d7f2b69bc875b6b508978773a85ea8cab6efd62530a5 9616 shotcut_19.12.31-2.debian.tar.xz
 0ffe5f5a1051ef5f02bc919b4774719aa9e066bb0584757be5d03d48773c5fc4 8451 shotcut_19.12.31-2_source.buildinfo
Files:
 0e6440812f96be76fa578adc5405651c 2263 video optional shotcut_19.12.31-2.dsc
 d041708c9333488471ecfe54fa398644 9616 video optional shotcut_19.12.31-2.debian.tar.xz
 f95451d3921b7624bafe3d7de677cd4c 8451 video optional shotcut_19.12.31-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl43pCsACgkQweDZLphv
fH7oUBAAr5LgoI5bhRwbOF3KnRIyLwFFJM5XUuyId7riy1tTwaleNDjzWN5Cywto
RHGLZiZMzYqd1kpQ23eSlLk+j4XUi88mgEesab/bbppzmhmlHRDVbsQYrDUOmJKj
cekQCFUvBuLRpzoXw0ubwEBaqQrmsPlrUWmJbIna6vOwCYecrXCMSvI+o+Tj76Ex
GpVQcLnNKtx2jZG7rJTvtFmwb7ExeCNHqh0K5eFASdwaTBnP+0MvWPSuaPIuxF3O
/Sbkfi4nGpLFeEPkGbdBczETOxmH1IAIo0tBnDt+ZuMXWf9gdNgd4dzLhs3YVDip
DD0CBjSD6yE6wZ71UmM3dSQtK475v91fJ92Z1LHtqF5I2vxdcuNHHn+4iQWx3e8X
jxSJWVymfI7OnidY/v7iS0EMLE7nEaejZuK3mRy5Fp4tT4HgXb/35JKXGPiChYqf
HpDhWVqFB6eRkmMcoYyC78SQyFWjZWZc+lIX1hXkguLPQZbUOajqV0JWpKCaPIa8
5RYvVfm4FDVH6Woz3Gjo3a5+F8b89bUHNmHtQO85yyVXAhF65mJSbVgDX7FnweFg
BkdtOHCYmdBAWcmWvcgNOmAo9azpKf3WQk2wpJUPF56mrEXY7NQBg3KeFoNjfuuX
nXOOnnHd5zl7RROAVRM+09vSyjj8cRbjFo6nVS4HnoYn1wI48zk=
=w9L+
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: