Bug#971355: liblivemedia-dev: compilation fails due to missing openssl

[Helmut Grohne <helmut.grohne@intenta.de>]

Package: liblivemedia-dev
Version: 2020.01.19-1
Severity: important

It is a bit unclear whether liblivemedia-dev integrates with openssl. On
the upstream side, this is optional. The Debian package passes
-DNO_OPENSSL to the build. However, the installed headers still contain
the relevant guards, so when you build something against Debian's
livemedia, you can get a compilation error:

$ echo "#include <liveMedia.hh>" | g++ -x c++ -c - `pkg-config --cflags live555` -o /dev/null
In file included from /usr/include/liveMedia/RTSPClient.hh:34,
                 from /usr/include/liveMedia/RTSPRegisterSender.hh:26,
                 from /usr/include/liveMedia/liveMedia.hh:105,
                 from <stdin>:1:
/usr/include/liveMedia/TLSState.hh:31:10: fatal error: openssl/ssl.h: No such file or directory
   31 | #include <openssl/ssl.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
$

Once you add -DNO_OPENSSL to the invocation, compilation succeeds. I
think that a consumer of livemedia should not be responsible for adding
that macro. If it is required, it should come from the live555.pc file.
The name of the macro also seems quite generic, prefixing it with
LIVE555 or seems reasonable, but that'd likely require talking to Ross.

I also think that the above makes up for a nice, superficial
autopkgtest.

Helmut