[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946478: marked as done (libvorbis: Please make autopkgtests cross-test-friendly)



Your message dated Sun, 27 Sep 2020 14:33:54 +0000
with message-id <E1kMXkQ-000HDE-8y@fasolo.debian.org>
and subject line Bug#946478: fixed in libvorbis 1.3.7-1
has caused the Debian Bug report #946478,
regarding libvorbis: Please make autopkgtests cross-test-friendly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
946478: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946478
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: libvorbis
Version: 1.3.6-2
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

One of the libvorbis tests currently fails in this environment, because it
is a build test that does not invoke the toolchain in a cross-aware manner. 
In addition, all of the tests have a test dependency on pysycache-i18n,
which is an architecture: all package that is not marked Multi-Arch: foreign
which means this dependency can't be satisfied as-is.  However, by tagging
this test dep with :native, the dependency can be satisfied for both
same-arch and cross-arch testing.

I've verified that the attached patch lets the tests successfully build (and
run) i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment.  Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org
diff -Nru libvorbis-1.3.6/debian/tests/control libvorbis-1.3.6/debian/tests/control
--- libvorbis-1.3.6/debian/tests/control	2019-02-24 11:33:46.000000000 -0800
+++ libvorbis-1.3.6/debian/tests/control	2019-12-09 11:45:30.000000000 -0800
@@ -1,2 +1,2 @@
-Depends: @, vorbis-tools, build-essential, pysycache-i18n, sound-icons, valgrind
+Depends: @, vorbis-tools, build-essential, pysycache-i18n:native, sound-icons, valgrind
 Tests: test-examples test-coupling-segfault
diff -Nru libvorbis-1.3.6/debian/tests/test-examples libvorbis-1.3.6/debian/tests/test-examples
--- libvorbis-1.3.6/debian/tests/test-examples	2019-02-25 13:02:32.000000000 -0800
+++ libvorbis-1.3.6/debian/tests/test-examples	2019-12-09 12:07:09.000000000 -0800
@@ -7,7 +7,11 @@
 
 set -e
 
-CC=gcc
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CC="$DEB_HOST_GNU_TYPE-gcc"
+else
+    CC=gcc
+fi
 
 retval=0
 cd $AUTOPKGTEST_TMP

--- End Message ---
--- Begin Message ---
Source: libvorbis
Source-Version: 1.3.7-1
Done: Sebastian Ramacher <sramacher@debian.org>

We believe that the bug you reported is fixed in the latest version of
libvorbis, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 946478@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <sramacher@debian.org> (supplier of updated libvorbis package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 27 Sep 2020 16:13:53 +0200
Source: libvorbis
Architecture: source
Version: 1.3.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sebastian Ramacher <sramacher@debian.org>
Closes: 946478 955786 963082
Changes:
 libvorbis (1.3.7-1) unstable; urgency=medium
 .
   * Team upload
 .
   [ Ondřej Nový ]
   * Use debhelper-compat instead of debian/compat
   * Bump Standards-Version to 4.4.1
 .
   [ Petter Reinholdtsen ]
   * Include upstream status in all patches.
 .
   [ Balint Reczey ]
   * debian/gitlab-ci.yml: Add minimal Salsa CI configuration
 .
   [ Olivier Tilloy ]
   * Change autopkgtest dependency on pysycache-i18n (Closes: #963082)
 .
   [ Dennis Braun ]
   * New upstream version 1.3.7
   * Update patchset
   * Add me as uploader
   * Bump dh-compat to 13
   * Bump S-V to 4.5.0
   * Set RRR: no
   * Update copyright years
 .
   [ Sebastian Ramacher ]
   * Do not install .la files (Closes: #955786)
     Thanks to Pino Toscano
   * Make autopkgtests cross-test-friendly (Closes: #946478)
     Thanks to Steve Langasek
Checksums-Sha1:
 7fa9d9632a4f69b384da3ee6f7199fa2505644f5 2362 libvorbis_1.3.7-1.dsc
 2b415495f89b103138a23da5017a2a00837c6c94 1658963 libvorbis_1.3.7.orig.tar.gz
 2b69398cfdc344bde3a2a27fb7a27c05e63b0582 11600 libvorbis_1.3.7-1.debian.tar.xz
Checksums-Sha256:
 b25d27beb9162607c95cf58aa2b764d110bd1a1568d3926a96c523320b49171f 2362 libvorbis_1.3.7-1.dsc
 0e982409a9c3fc82ee06e08205b1355e5c6aa4c36bca58146ef399621b0ce5ab 1658963 libvorbis_1.3.7.orig.tar.gz
 c5c40944a3fc1cdd1ce019ef21f580ce5ed3b9f30e0cba7b3d859e8d9fea631f 11600 libvorbis_1.3.7-1.debian.tar.xz
Files:
 59e1e230ff562934ce4bd6c4332c1355 2362 libs optional libvorbis_1.3.7-1.dsc
 9b8034da6edc1a17d18b9bc4542015c7 1658963 libs optional libvorbis_1.3.7.orig.tar.gz
 5847ecd4008a16f1d132d8c4c60f5c19 11600 libs optional libvorbis_1.3.7-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE94y6B4F7sUmhHTOQafL8UW6nGZMFAl9wnw4ACgkQafL8UW6n
GZNEtRAAnvKtZ5jzPCiuOlx7FSgM2NbycV6Np4DjzzLWr3tbMjhoocZJCLRnpuAT
XKXJRZKoZqcNBfk+r2vM3aDXUgH14MVP5xHiZxG6rkmhj/Oz6kY3flZAT8gRmXrc
5jzjYGhKIK+OFeTN9qruDRlEH0B1MY+mkpy1zULUBaWuU5krmG6e3t2GyMyfVzGK
jGhw90XGunOIc/AS2s4ONjA1U9qoPRIX5EJbMh3vyGg90r328A+wminHOhlfLana
qeFuR7RgiEZyc0d2NXI5vTnGHErlpZrKvtSmfoOMulhSRWDxnPZ5xOTuUM8KOye6
ueW8IWbXcj2X1hJjpjF0FcxHkckhtguVyM+ISxjmewfl2NBHykw7XXGRwCAdRCM1
IF6A2ljbo/6oUjkqTTkTg5qLh0lceVRtAK27jsAOjMiMI1Y3mvMKzkqhryV/8Y2c
4yVrm+7KxvEKAUgqTz+6MiYElb/W5dfjHEgL4lYmLW1h1RnQI7uehm79tjNxVgGt
gQnh3IhhQihskcwK8b0S2uStDtaB3OkSBwSFZ+w2pWgrn3ANk8LdM6oanjBx0+b3
Guf5EN/VSc+j1Py8p//JA+bBeFl5AwikzY0WkkxEnWn/Xzw9xi0x5X2XYQHWxGM/
xDvbv8SejXvyIqszBidiV2RR7DMsP6wucfN7NOAjZOflriQF1ZI=
=Nlhj
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: