[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945905: marked as done (qtractor FTCBFS: uses AC_TRY_RUN to compute sizeof(float))

Your message dated Sat, 23 May 2020 15:20:53 +0200
with message-id <d1f96074-390d-9d24-5105-eb5ce3ec5863@kabelmail.de>
and subject line Re: qtractor FTCBFS: uses AC_TRY_RUN to compute sizeof(float)
has caused the Debian Bug report #945905,
regarding qtractor FTCBFS: uses AC_TRY_RUN to compute sizeof(float)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
945905: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945905
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: qtractor
Version: 0.9.11-1
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

qtractor fails to cross build from source, because it uses AC_TRY_RUN to
figure out sizeof(float). AC_TRY_RUN does not work at all during cross
compilation. For sizeof, autoconf has a better alternative
AC_CHECK_SIZEOF though. Replacing this AC_TRY_RUN actually makes the
code simpler and more portable. Please consider applying the attached
patch.

It still fails to cross build, because qtractor has more AC_TRY_RUN.
Please close this bug anyhow when fixing the float check.

Helmut

--- qtractor-0.9.11.orig/configure.ac
+++ qtractor-0.9.11/configure.ac
@@ -599,13 +599,8 @@
 
 
 # Check for IEEE 32bit float optimizations.
-AC_CACHE_CHECK([for IEEE 32bit float optimizations],
-   ac_cv_float32, [
-   AC_TRY_RUN([
-      int main() { return (sizeof(float) == 4 ? 0 : 1); }
-   ], ac_cv_float32="yes", ac_cv_float32="no")
-])
-ac_float32=$ac_cv_float32
+AC_CHECK_SIZEOF(float)
+AS_IF([test "$ac_cv_sizeof_float" = 4],[ac_float32=yes],[ac_float32=no])
 if test "x$ac_float32" = "xyes"; then
    AC_DEFINE(CONFIG_FLOAT32, 1, [Define if IEEE 32bit float optimizations are enabled.])
 fi

--- End Message ---
--- Begin Message --- 
Version: 0.9.13-1

fixed in this version

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: