[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#946236: marked as done (aom: please make autopkgtests cross-test-friendly)

Your message dated Thu, 02 Jan 2020 19:34:07 +0000
with message-id <E1in6ER-0003BK-B7@fasolo.debian.org>
and subject line Bug#946236: fixed in aom 1.0.0.errata1-3
has caused the Debian Bug report #946236,
regarding aom: please make autopkgtests cross-test-friendly
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
946236: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946236
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: aom
Version: 1.0.0.errata1-2
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Dear maintainers,

In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.

This requires changes to some tests so that they are cross-aware and can do
the right thing.

The aom tests currently fail in this environment, because they are build
tests that do not invoke the toolchain in a cross-aware manner.  I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.

Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment.  Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option.  So this change should be safe to land in your package despite this
not being upstream in autopkgtest.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

diff -Nru aom-1.0.0.errata1/debian/tests/library-build aom-1.0.0.errata1/debian/tests/library-build
--- aom-1.0.0.errata1/debian/tests/library-build	2019-09-01 05:28:49.000000000 -0700
+++ aom-1.0.0.errata1/debian/tests/library-build	2019-12-05 15:26:36.000000000 -0800
@@ -10,10 +10,14 @@
 cp debian/tests/library-build.c "$AUTOPKGTEST_TMP"
 cd "$AUTOPKGTEST_TMP"
 
+if [ -n "$DEB_HOST_MULTIARCH" ]; then
+    export PKG_CONFIG_PATH="/usr/lib/$DEB_HOST_MULTIARCH/pkgconfig"
+    PREFIX="$DEB_HOST_GNU_TYPE-"
+fi
 # Compile with and without pkg-config
-gcc -Wall -Wextra -O2 library-build.c -o build1 -laom
+${PREFIX}gcc -Wall -Wextra -O2 library-build.c -o build1 -laom
 echo "build1: compiled"
-gcc -Wall -Wextra -O2 $(pkg-config --cflags aom) library-build.c -o build2 $(pkg-config --libs aom)
+${PREFIX}gcc -Wall -Wextra -O2 $(pkg-config --cflags aom) library-build.c -o build2 $(pkg-config --libs aom)
 echo "build2: compiled"
 
 # Run the tests

--- End Message ---
--- Begin Message --- 
Source: aom
Source-Version: 1.0.0.errata1-3

We believe that the bug you reported is fixed in the latest version of
aom, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 946236@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James Cowgill <jcowgill@debian.org> (supplier of updated aom package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 02 Jan 2020 19:26:18 +0000
Source: aom
Architecture: source
Version: 1.0.0.errata1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: James Cowgill <jcowgill@debian.org>
Closes: 946236
Changes:
 aom (1.0.0.errata1-3) unstable; urgency=medium
 .
   [ James Cowgill ]
   * d/tests:
     - Merge pkg-config invocations.
     - Make library-build test cross test friendly.
       Thanks to Steve Langasek for the original patch. (Closes: #946236)
 .
   [ Ondřej Nový ]
   * d/control: Bump Standards-Version to 4.4.1.
Checksums-Sha1:
 5e6f3ec9c884d2063afc06908302ba995af0e92c 2370 aom_1.0.0.errata1-3.dsc
 bacbea76a9486671bee2f5922ecb75e1016d436b 21120 aom_1.0.0.errata1-3.debian.tar.xz
Checksums-Sha256:
 0efd39fc5062efb53622ffd062186da4c964d805115d9648ebc75a55e1bddfdf 2370 aom_1.0.0.errata1-3.dsc
 fc180608631a4bd9bf4c15af30d1b17b377ab0e926b9b4ded21aeb5849d6a1fe 21120 aom_1.0.0.errata1-3.debian.tar.xz
Files:
 3e02431abb5b181053854b67d787c2c2 2370 video optional aom_1.0.0.errata1-3.dsc
 507444c5d530d9bfa64206555222f9ac 21120 video optional aom_1.0.0.errata1-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEE+Ixt5DaZ6POztUwQx/FnbeotAe8FAl4ORDgUHGpjb3dnaWxs
QGRlYmlhbi5vcmcACgkQx/FnbeotAe9n0g/9F8GX9XG6bXqs+Tpy9wV3v9q8sNtb
f6iwzrm0WUsCPzV7aGoC1aRtqUQRwjgrHTRQTaLY8R/aWIch5C44V3QfPFksd0Ny
DsVB/wn3UtjT3ycc6IBCBxZaLuUzAYshO2Q4YSkHMKqMsTyX7jAnlsJN9b2bUqcI
a0IwbFd6M6J0WWVrtJogAXaREO4LxeC4iFAl7mvWsNlRpfiPvlji9Acjn57QnWL1
23OOGqAe3CPpwmcN1Uyd6ioyPo6EPE5WDveqwzwkGb27VTowFQDjV0qHnmNS4JPz
7bSBBj+sn1d79v8pQEmHdzMCWnDx794+UuXe1UrmP26gcbf3r6+5rU4dyBtseQWB
nRGIMsnSGQ9clyRScpL+YdRt/KsQAAYUK9qeGr3jVlLXNAQt+YJlnOYCvYJJmcsq
0c90vdpkAS09UZCoGdUjaWSu8fDqwkFpYVL4j25Y8lGTd0GqZwRQUGp908tUVs8G
sONN97oodzI9TxUn8lRz4wiFzHqM2YEPJxNL2XCHfGk8VExvy8c141o1P4ieE2y/
uvvN3KAWRngEMMIS23YK/v2GXn9eXbbVwgyonjHw9yOZHYzi3FBtXnjOaJpn815l
TpC1FKUyJO/mszAtbPZZuea/HC0whlQdRkZbJkuL57AuTIQYC3rxIy0dVG3Qk0zF
Um6LBEug+3Cw6rk=
=1McZ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: