[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#901975: marked as done (jackeq FTCBFS: fails configuring(!) during dh_auto_clean)

Your message dated Sun, 22 Dec 2019 21:31:47 +0100
with message-id <20191222203147.GA25095@alf.mars>
and subject line Re: jackeq FTCBFS: fails configuring(!) during dh_auto_clean
has caused the Debian Bug report #901975,
regarding jackeq FTCBFS: fails configuring(!) during dh_auto_clean
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
901975: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901975
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: jackeq
Version: 0.5.9-2.1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

jackeq fails to cross build from source, because dh_auto_clean runs make
distclean, which runs ./config.status --recheck, which fails finding
jack for the build architecture as it is only requested for the host
architecture by Build-Depends. Reconfiguring the package during
dh_auto_clean seems like a very bad idea to me and I'm not even sure why
it does that. The builds on the buildds didn't do it. Still I'm offering
the attached patch that makes dh_auto_clean reliably skip the
configuration step. After doing so, jackeq cross builds successfully.
Please consider applying it.

Alternatively, consider shipping a source tree without generated files.

Helmut

diff --minimal -Nru jackeq-0.5.9/debian/changelog jackeq-0.5.9/debian/changelog
--- jackeq-0.5.9/debian/changelog	2017-05-27 10:41:06.000000000 +0200
+++ jackeq-0.5.9/debian/changelog	2018-06-20 21:02:12.000000000 +0200
@@ -1,3 +1,10 @@
+jackeq (0.5.9-2.2) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Don't configure during dh_auto_clean. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 20 Jun 2018 21:02:12 +0200
+
 jackeq (0.5.9-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --minimal -Nru jackeq-0.5.9/debian/rules jackeq-0.5.9/debian/rules
--- jackeq-0.5.9/debian/rules	2010-11-25 20:55:19.000000000 +0100
+++ jackeq-0.5.9/debian/rules	2018-06-20 21:02:12.000000000 +0200
@@ -7,3 +7,16 @@
 
 override_dh_clean:
 	dh_clean -Xautom4te.cache -X*.deps -X*~ -X*.bak
+
+override_dh_auto_clean:
+	# prevent make distclean from rerunning configure
+	set -e; if test -f Makefile; then \
+		if test -f config.status; then \
+			touch config.status; \
+			sleep 1; \
+		fi; \
+		for d in . pixmaps po pixmaps; do \
+			test -f $$d/Makefile && touch $$d/Makefile; \
+		done; \
+	fi
+	dh_auto_clean

--- End Message ---
--- Begin Message --- 
Version: 0.5.9-3

On Wed, Jun 20, 2018 at 10:38:41PM +0200, Helmut Grohne wrote:
> jackeq fails to cross build from source, because dh_auto_clean runs make
> distclean, which runs ./config.status --recheck, which fails finding
> jack for the build architecture as it is only requested for the host
> architecture by Build-Depends. Reconfiguring the package during
> dh_auto_clean seems like a very bad idea to me and I'm not even sure why
> it does that. The builds on the buildds didn't do it. Still I'm offering
> the attached patch that makes dh_auto_clean reliably skip the
> configuration step. After doing so, jackeq cross builds successfully.
> Please consider applying it.

All clean errors are ignored since 0.5.9-3. Thus closing the bug.

Helmut

--- End Message ---
Reply to: