--- Begin Message ---
Package: jacktrip
Version: 1.1~repack-6
Severity: important
Tags: patch
Dear Maintainer,
Other clients hang at "Waiting for Peer..." when attempting to
connect to jacktrip running as a server. This is because of a change to
the way that QHostAddress works in Qt5, resulting in the return of an
IPv4-mapped address instead of an IPv4 address. I've written and
attached a patch that fixes this (restoring the behaviour shown by Qt4).
Cheers,
Aaron
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.2.0-2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages jacktrip depends on:
ii libc6 2.28-10
ii libgcc1 1:9.2.1-6
ii libjack-jackd2-0 [libjack-0.125] 1.9.12~dfsg-2+b1
ii libqt5core5a 5.11.3+dfsg1-4
ii libqt5network5 5.11.3+dfsg1-4
ii librtaudio6 5.0.0~ds-3
ii libstdc++6 9.2.1-6
jacktrip recommends no packages.
jacktrip suggests no packages.
-- no debconf information
--- jacktrip-1.1~repack/src/JackTrip.cpp 2019-09-01 22:29:24.000000000 +1000
+++ JackTrip.cpp 2019-09-01 22:24:03.033620369 +1000
@@ -451,6 +451,15 @@
UdpSockTemp.close(); // close the socket
mPeerAddress = peerHostAddress.toString();
+
+ // Convert any IPv4-mapped address to an actual IPv4 address
+ // (Due to a change in the way that QHostAddress works in Qt5)
+ bool couldConvert;
+ QHostAddress ipv4Address(peerHostAddress.toIPv4Address(&couldConvert));
+ if (couldConvert) {
+ mPeerAddress = ipv4Address.toString();
+ }
+
cout << "Client Connection Received from IP : "
<< qPrintable(mPeerAddress) << endl;
cout << gPrintSeparator << endl;
--- jacktrip-1.1~repack/src/JackTrip.cpp 2019-09-01 22:29:24.000000000 +1000
+++ JackTrip.cpp 2019-09-01 22:24:03.033620369 +1000
@@ -451,6 +451,15 @@
UdpSockTemp.close(); // close the socket
mPeerAddress = peerHostAddress.toString();
+
+ // Convert any IPv4-mapped address to an actual IPv4 address
+ // (Due to a change in the way that QHostAddress works in Qt5)
+ bool couldConvert;
+ QHostAddress ipv4Address(peerHostAddress.toIPv4Address(&couldConvert));
+ if (couldConvert) {
+ mPeerAddress = ipv4Address.toString();
+ }
+
cout << "Client Connection Received from IP : "
<< qPrintable(mPeerAddress) << endl;
cout << gPrintSeparator << endl;
--- End Message ---
--- Begin Message ---
Source: jacktrip
Source-Version: 1.1~repack-7
We believe that the bug you reported is fixed in the latest version of
jacktrip, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 939126@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated jacktrip package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 02 Sep 2019 13:35:55 +0200
Source: jacktrip
Architecture: source
Version: 1.1~repack-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 939126
Changes:
jacktrip (1.1~repack-7) unstable; urgency=medium
.
* Patch to handle IPv4-mapped addresses.
Thanks to Aaron Wyatt <dev@psi-borg.org> (Closes: #939126)
* Refresh patches
Checksums-Sha1:
e225f43bca43d8d53e699f719eee039a4dd62c39 2234 jacktrip_1.1~repack-7.dsc
572b3c65a6d8effe5a34c5ccd5be4e910d1793bb 8784 jacktrip_1.1~repack-7.debian.tar.xz
Checksums-Sha256:
3baa2fb2c7453a26bd2b610fb1e760d4657d8bd3640f5f808636174ef3ab9794 2234 jacktrip_1.1~repack-7.dsc
a1dd270fcc53b4965f01d80810c8cd308a018e3035e66882f97e883d63327a1d 8784 jacktrip_1.1~repack-7.debian.tar.xz
Files:
74cb596265672138a729fa21cfa4da82 2234 sound optional jacktrip_1.1~repack-7.dsc
6f74c70196e56ca87bfa427af0f665ee 8784 sound optional jacktrip_1.1~repack-7.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAl1tAUkWHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+F+mD/9vE831+rASpEtklNvj8LKz+FKA
eWVh1Jn0yCuTRRtSID85xr37PYrBeIZAj5hOUwibMMk23DHEAfvMt9XR+6j2Wi8+
YKGGojK8RNWRFzqNtdmNE60vHas7wiuVg4dAKxKIt1EOiyDx2r0MHtO+T66IQ2Oj
ULHGUbHRw4zWF4sFZyqgkn0DIvb2ajLBJzHGQhDSfPUcUgXXLScV9c9RYu8qkcDH
bhpKM1spCOQYMUu0atfDWNhPW5MaM4ufVTITjB0Qf9DuhfAcKCKfQoP4eGRpr87M
3X1U/h/XgkK8ZxjgjUH1L+ecs07c95h/8qBlDnJ07SPWihH9OYgnJ0epsPDhE+pj
TZTCXvfI6op2sNEfalwCM5VJlYKHAQgaAR94LsP+h1ZOIfdNb8aHdnpldHyGe6qh
lwGsc8FIbLp71TgDlqb/7RC79CN1zxTY65kuBFAnyKv/NfVRJcOerO8HuvcokdIL
98P59qUeM83TJyWxWeN6rbjTV8sVJxV3MNGfs9XiiMYNCQI7OD9dpqBgeh6GFVYo
PO5gWpQibq/sbildDi4H8HB0FbfRe846iYb0c/23Pt/yC+kkJb/6Qd5X4igY3QTJ
k703k5DhRlDxqHrdTw9WQx/3eAiDbOvCZFpt5BkU5Wi8QkSsNrJsB0nmmn0bYeV0
GiWt3+epwHOddqDyeA==
=2bx0
-----END PGP SIGNATURE-----
--- End Message ---