--- Begin Message ---
Source: faad2
Version: 2.8.8-3
Severity: normal
tags: patch
Hello, looks like gcc-9 is adding wl,asneeded flag in compilation, so libs passed as CFLAGS are not correctly
used by gcc anymore, because only LIBS is added at the end of the compilation line.
The following patch fixes the issue, and starts then using again the glib implementation of the library.
(without the patch, the bundled version is used everywhere, and the build fails only on i386 because of an implementation mismatch of a long/int data type)
I reported the patch already upstream
https://sourceforge.net/p/faac/bugs/242/
patch: http://launchpadlibrarian.net/427773869/faad2_2.8.8-3_2.8.8-3ubuntu1.diff.gz
please apply if possible, thanks!
Gianfranco
>From b9e6b9bf906c8c2c6fabf7255bcf9eceff96023b Mon Sep 17 00:00:00 2001
From: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Date: Tue, 11 Jun 2019 14:54:38 +0200
Subject: [PATCH] Add patch to fix a gcc-9 build failure on i386 and to
correctly use lprintf from glibc
---
debian/changelog | 6 ++++++
debian/patches/gcc-9.patch | 26 ++++++++++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 33 insertions(+)
create mode 100644 debian/patches/gcc-9.patch
diff --git a/debian/changelog b/debian/changelog
index dfa8217..c1267f4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+faad2 (2.8.8-4) UNRELEASED; urgency=medium
+
+ * Fix build with gcc-9 and asneeded flag on i386.
+
+ -- Gianfranco Costamagna <locutusofborg@debian.org> Tue, 11 Jun 2019 14:41:09 +0200
+
faad2 (2.8.8-3) unstable; urgency=high
* Team upload.
diff --git a/debian/patches/gcc-9.patch b/debian/patches/gcc-9.patch
new file mode 100644
index 0000000..e17a3a3
--- /dev/null
+++ b/debian/patches/gcc-9.patch
@@ -0,0 +1,26 @@
+Description: Fix link failure with gcc-9 and wl,asneeded flags
+Author: Gianfranco Costamagna <locutusofborg@debian.org>
+Last-Update: 2019-06-11
+
+--- faad2-2.8.8.orig/configure.ac
++++ faad2-2.8.8/configure.ac
+@@ -91,8 +91,8 @@ AC_DEFUN([AC_C99_FUNC_LRINTF],
+ [AC_CACHE_CHECK(for lrintf,
+ ac_cv_c99_lrintf,
+ [
+-lrintf_save_CFLAGS=$CFLAGS
+-CFLAGS="-O -lm"
++lrintf_save_LIBS=$LIBS
++LIBS="-O -lm"
+ AC_TRY_LINK([
+ #define _ISOC9X_SOURCE 1
+ #define _ISOC99_SOURCE 1
+@@ -102,7 +102,7 @@ AC_TRY_LINK([
+ #include <math.h>
+ ], if (!lrintf(3.14159)) lrintf(2.7183);, ac_cv_c99_lrintf=yes, ac_cv_c99_lrintf=no)
+
+-CFLAGS=$lrintf_save_CFLAGS
++LIBS=$lrintf_save_LIBS
+
+ ])
+
diff --git a/debian/patches/series b/debian/patches/series
index 6d4062f..f35c884 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ reproducible-build.patch
0009-syntax.c-check-for-syntax-element-inconsistencies.patch
0010-sbr_hfadj-sanitize-frequency-band-borders.patch
0004-Fix-a-couple-buffer-overflows.patch
+gcc-9.patch
--
2.17.1
--- End Message ---
--- Begin Message ---
Source: faad2
Source-Version: 2.8.8-3.2
We believe that the bug you reported is fixed in the latest version of
faad2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 930363@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hugo Lefeuvre <hle@debian.org> (supplier of updated faad2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 31 Aug 2019 09:11:54 -0400
Source: faad2
Architecture: source
Version: 2.8.8-3.2
Distribution: unstable
Urgency: high
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Hugo Lefeuvre <hle@debian.org>
Closes: 930363
Changes:
faad2 (2.8.8-3.2) unstable; urgency=high
.
* Non-maintainer upload with maintainer's permission.
* debian/patches/gcc-9.patch: Fix build with GCC-9 (thanks Gianfranco
Costamagna for the patch) (Closes: #930363).
Checksums-Sha1:
17a42b0b015655b6ee5a7409f593c5647db7cf70 1928 faad2_2.8.8-3.2.dsc
529fade97c2d2d0960b5725c73fe184e0a1a7b3d 11964 faad2_2.8.8-3.2.debian.tar.xz
15e3104c6c6990a199b479168e3f94fcee7fd774 6120 faad2_2.8.8-3.2_i386.buildinfo
Checksums-Sha256:
9365f0540caa0ebf3f35564701948a92d26e39233d7da27f3c2f7e859702e5f3 1928 faad2_2.8.8-3.2.dsc
6ee679b44c11b6ecd43f8440b4f4860ced6d5bdf533a91626035a711fb539880 11964 faad2_2.8.8-3.2.debian.tar.xz
def24e7f29a624eb5e70ea4764a4425466576d6c60343c571bc11bddb8433bfb 6120 faad2_2.8.8-3.2_i386.buildinfo
Files:
a50d22a333e4ed6aadc9b07bcf0ee59a 1928 libs optional faad2_2.8.8-3.2.dsc
21f1c8b11c13bf29cfee467b05e8357a 11964 libs optional faad2_2.8.8-3.2.debian.tar.xz
c1b39c0ec78c6030e13ce18cc69d6310 6120 libs optional faad2_2.8.8-3.2_i386.buildinfo
-----BEGIN PGP SIGNATURE-----
iQHDBAEBCgAtFiEEeDb9QWtkMa2LX4zREeMFjl5EGkIFAl1qd7wPHGhsZUBkZWJp
YW4ub3JnAAoJEBHjBY5eRBpC6+AL/1NXeynKw1lchrEqlDMylJ2S6AWejTX2eZif
85GemZ9y0dQ4trpa90ksKO69omOd2E0EJ5YNHkyqUjSHRIlzNNe+hUa/ve5jCbYb
dFlW2MOHDJvKKBS97ip1h2VRGy8E1RAPGEwMF/ALIzgpJ6Gnhu+uv0nscUKHKv/a
NibZhBfF1dfzLpcNiTr+7cyHQ3kVOaxRSzB7tBWuxTcjwkqsbgVwLwIGWZTYnLik
KeItgV1MG3UnGyJHdFbTZW3741R2xyhVOWsgJDaoJ6uavI3SpfHX+rXXMXX0bg2Q
08A+Md5TqxRxDrlT0/tS+H5n4q1bLOzSFmoZ335KPWYthLLqLNKa3r+cZ7NjKgJl
gFpShvXvtnNaIkgxEDqA2NlMEbFsVK63r2+tyvVHVgkJJKa6PdoYMvj/xlrEa9I1
POAYoyeekgp/eagSPAYG7ocVBNvo77SwvHcjc9qe3Kf6uYmVhmhvRN8/YsAWYiFY
UNMyHGkVJUA4GBzvst8aKYgibRAxoA==
=zQwD
-----END PGP SIGNATURE-----
--- End Message ---