[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#930363: faad2: fix build with gcc-9 [patch]



Hi Gianfranco,

On Thu, Aug 29, 2019 at 07:43:15AM +0200, Gianfranco Costamagna wrote:
> control: severity -1 serious
> On Tue, 11 Jun 2019 15:06:01 +0200 Gianfranco Costamagna <locutusofborg@debian.org> wrote:
> > Source: faad2
> > Version: 2.8.8-3
> > Severity: normal
> > tags: patch
> > 
> > Hello, looks like gcc-9 is adding wl,asneeded flag in compilation, so libs
> > passed as CFLAGS are not correctly used by gcc anymore, because only LIBS
> > is added at the end of the compilation line.
> > 
> > The following patch fixes the issue, and starts then using again the glib
> > implementation of the library.  (without the patch, the bundled version is
> > used everywhere, and the build fails only on i386 because of an
> > implementation mismatch of a long/int data type)
> > 
> > I reported the patch already upstream
> > https://sourceforge.net/p/faac/bugs/242/
> > patch: http://launchpadlibrarian.net/427773869/faad2_2.8.8-3_2.8.8-3ubuntu1.diff.gz
> 
> Now this bug is RC, and preventing CVE fixes from Migration.
> Hugo, can you please reupload with the Ubuntu patch?
> https://launchpad.net/ubuntu/+source/faad2/2.8.8-3.1ubuntu1
> I rebased it with the upstream version

Fabian (faad2 maintainer and upstream), do you want to handle this?

Otherwise I can NMU a second time with this patch.

cheers,
Hugo

-- 
                Hugo Lefeuvre (hle)    |    www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C

Attachment: signature.asc
Description: PGP signature


Reply to: