[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#918718: sonic-visualiser FTCBFS: fails running tests despite DEB_BUILD_OPTIONS=nocheck



Source: sonic-visualiser
Version: 3.2-1
Tags: patch upstream
User: helmutg@debian.org
Usertags: rebootstrap

sonic-visualiser fails to cross build from source, because it runs its
test via QMAKE_POST_LINK during dh_auto_build and thus
DEB_BUILD_OPTIONS=nocheck is not honoured. Lisandro Damián Nicanor Pérez
Meyer kindly explained to me that you are supposed to use "CONFIG +=
testcase". Once doing so, they're run during make check, which is
invoked by dh_auto_test (which honours DEB_BUILD_OPTIONS=nocheck). It
turns out that the qmake files become quite a bit easier that way.
Please consider applying the attached patch.

Helmut
--- sonic-visualiser-3.2.orig/dataquay/tests/tests.pro
+++ sonic-visualiser-3.2/dataquay/tests/tests.pro
@@ -1,6 +1,6 @@
 
 TEMPLATE = app
-CONFIG += debug console warn_on c++11
+CONFIG += debug console warn_on c++11 testcase
 QT += testlib
 QT -= gui
 TARGET = test-dataquay
@@ -40,14 +40,3 @@
 	include(../platform.pri)
     }
 }
-
-!win32 {
-    !macx* {
-        QMAKE_POST_LINK=$${DESTDIR}/$${TARGET}
-    }
-    macx* {
-        QMAKE_POST_LINK=./$${TARGET}.app/Contents/MacOS/$${TARGET}
-    }
-}
-
-win32:QMAKE_POST_LINK=$${TARGET}.exe
--- sonic-visualiser-3.2.orig/test-svcore-base.pro
+++ sonic-visualiser-3.2/test-svcore-base.pro
@@ -11,7 +11,7 @@
 
 include(base.pri)
 
-CONFIG += console
+CONFIG += console testcase
 QT += network xml testlib
 QT -= gui
 
@@ -27,7 +27,3 @@
 
 for (file, TEST_SOURCES) { SOURCES += $$sprintf("svcore/base/test/%1", $$file) }
 for (file, TEST_HEADERS) { HEADERS += $$sprintf("svcore/base/test/%1", $$file) }
-
-!win32* {
-    QMAKE_POST_LINK = ./$${TARGET}
-}
--- sonic-visualiser-3.2.orig/test-svcore-data-fileio.pro
+++ sonic-visualiser-3.2/test-svcore-data-fileio.pro
@@ -11,7 +11,7 @@
 
 include(base.pri)
 
-CONFIG += console
+CONFIG += console testcase
 QT += network xml testlib
 QT -= gui
 
@@ -27,7 +27,3 @@
 
 for (file, TEST_SOURCES) { SOURCES += $$sprintf("svcore/data/fileio/test/%1", $$file) }
 for (file, TEST_HEADERS) { HEADERS += $$sprintf("svcore/data/fileio/test/%1", $$file) }
-
-!win32* {
-    QMAKE_POST_LINK = ./$${TARGET}
-}
--- sonic-visualiser-3.2.orig/test-svcore-data-model.pro
+++ sonic-visualiser-3.2/test-svcore-data-model.pro
@@ -11,7 +11,7 @@
 
 include(base.pri)
 
-CONFIG += console
+CONFIG += console testcase
 QT += network xml testlib
 QT -= gui
 
@@ -27,7 +27,3 @@
 
 for (file, TEST_SOURCES) { SOURCES += $$sprintf("svcore/data/model/test/%1", $$file) }
 for (file, TEST_HEADERS) { HEADERS += $$sprintf("svcore/data/model/test/%1", $$file) }
-
-!win32* {
-    QMAKE_POST_LINK = ./$${TARGET}
-}
--- sonic-visualiser-3.2.orig/test-svcore-system.pro
+++ sonic-visualiser-3.2/test-svcore-system.pro
@@ -11,7 +11,7 @@
 
 include(base.pri)
 
-CONFIG += console
+CONFIG += console testcase
 QT += network xml testlib
 QT -= gui
 
@@ -27,7 +27,3 @@
 
 for (file, TEST_SOURCES) { SOURCES += $$sprintf("svcore/system/test/%1", $$file) }
 for (file, TEST_HEADERS) { HEADERS += $$sprintf("svcore/system/test/%1", $$file) }
-
-!win32* {
-    QMAKE_POST_LINK = ./$${TARGET}
-}

Reply to: