Bug#942444: Removing icons from action toolbar corrupts picard's config file

[cacatoes@tuxfamily.org]

Package: picard
Version: 2.2.2-1

Hello,

First an unrelated issue : updating to Picard 2.2.2-1 broke it, I had to
reset my Picard user settings. I experienced a similar issue during a
previous update, it's a little frustrating having to reset and start
over configurint it, I believe other users will experience similar
issues.

Back to the problem, I tried to pinpoint what makes my Picard crash, I
can provoke it by removing buttons from the toolbar, in Options > User
Interface > Customize Actions, remove some or all the actions from the
toolbar. Close picard, then restart it, it will crash with:

W: 15:55:17,486 /usr/lib/picard/picard/ui/playertoolbar.__init__:98: Internal player: unavailable, cannot import name 'QtMultimedia' from 'PyQt5' (/usr/lib/python3/dist-packages/PyQt5/__init__.py)
Traceback (most recent call last):
  File "/usr/lib/picard/picard/tagger.py", line 388, in event
    event.run()
  File "/usr/lib/picard/picard/util/thread.py", line 39, in run
    self.func(*self.args, **self.kwargs)
  File "/usr/lib/picard/picard/ui/mainwindow.py", line 571, in _update_cd_lookup_actions
    self.update_cd_lookup_drives(result)
  File "/usr/lib/picard/picard/ui/mainwindow.py", line 587, in update_cd_lookup_drives
    self._update_cd_lookup_button()
  File "/usr/lib/picard/picard/ui/mainwindow.py", line 592, in _update_cd_lookup_button
    button.setPopupMode(QtWidgets.QToolButton.MenuButtonPopup)
AttributeError: 'NoneType' object has no attribute 'setPopupMode'

A partial diff between the two picard.ini files give:

< toolbar_layout=@Invalid()
---
> toolbar_layout=add_directory_action, add_files_action, separator,
> cluster_action, separator, autotag_action, analyze_action,
> browser_lookup_action, separator, save_action, view_info_action,
> remove_action, separator, cd_lookup_action, separator,
> submit_acoustid_action

Hope this helps,

-- System Information:
Debian Release: bullseye/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages picard depends on:
ii  libc6                 2.29-2
ii  libchromaprint-tools  1.4.3-3
ii  python3               3.7.5-1
ii  python3-libdiscid     1.0-5
ii  python3-mutagen       1.40.0-2
ii  python3-pyqt5         5.12.3+dfsg-2

Versions of packages picard recommends:
pn  libqt5multimedia5-plugins   <none>
pn  python3-pyqt5.qtmultimedia  <none>

Versions of packages picard suggests:
ii  hicolor-icon-theme  0.17-2

-- no debconf information