Bug#930944: pd-lua FTCBFS: multiple reasons
Source: pd-lua
Version: 0.7.3-2
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs
pd-lua fails to cross build from source, because debian/rules hard codes
the build architecture pkg-config. Letting dpkg's buildtools.mk supply
it fixes this part. Additionally make install strips with the wrong
strip. Beyond breaking cross compilation, this breaks
DEB_BUILD_OPTIONS=nostrip as well as generation of -dbgsym packages. You
simply shouldn't strip during make install. The attached patch fixes all
of that. Please consider applying it.
Helmut
diff --minimal -Nru pd-lua-0.7.3/debian/changelog pd-lua-0.7.3/debian/changelog
--- pd-lua-0.7.3/debian/changelog 2018-02-01 23:19:43.000000000 +0100
+++ pd-lua-0.7.3/debian/changelog 2019-06-23 09:27:16.000000000 +0200
@@ -1,3 +1,12 @@
+pd-lua (0.7.3-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Supply pkg-config from dpkg's buildtools.mk.
+ + Don't strip during make install.
+
+ -- Helmut Grohne <helmut@subdivi.de> Sun, 23 Jun 2019 09:27:16 +0200
+
pd-lua (0.7.3-2) unstable; urgency=medium
* Switched buildsystem from dh to cdbs
diff --minimal -Nru pd-lua-0.7.3/debian/rules pd-lua-0.7.3/debian/rules
--- pd-lua-0.7.3/debian/rules 2018-02-01 23:19:43.000000000 +0100
+++ pd-lua-0.7.3/debian/rules 2019-06-23 09:27:16.000000000 +0200
@@ -14,9 +14,11 @@
BUILD_DATE ?= $(shell date "+$(DATE_FMT)")
endif
+-include /usr/share/dpkg/buildtools.mk
+PKG_CONFIG ?= pkg-config
CPPFLAGS+=-DBUILD_DATE='\"$(BUILD_DATE)\"'
-CFLAGS+=$(shell pkg-config --cflags lua5.2 pd)
-LIBS+=$(shell pkg-config --libs lua5.2 pd)
+CFLAGS+=$(shell $(PKG_CONFIG) --cflags lua5.2 pd)
+LIBS+=$(shell $(PKG_CONFIG) --libs lua5.2 pd)
LDFLAGS += -Wl,-as-needed
@@ -34,7 +36,7 @@
$(empty)
override_dh_auto_install:
- dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir)
+ dh_auto_install -- prefix=/usr pkglibdir=$(pkglibdir) STRIP=true
# fix permissions
find $(CURDIR)/debian/*/$(pkglibdir) -name "*.pd_linux" -exec \
chmod 0664 {} +
Reply to: