[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#924260: marked as done (Csound: regression in diskgrain stretch->buster when file sr != orchestra sr)

Your message dated Mon, 25 Mar 2019 02:47:37 +0000
with message-id <E1h8FeD-000EEU-Bi@fasolo.debian.org>
and subject line Bug#924260: fixed in csound 1:6.12.2~dfsg-3.1
has caused the Debian Bug report #924260,
regarding Csound: regression in diskgrain stretch->buster when file sr != orchestra sr
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
924260: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924260
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
package: csound
severity: important
justification: Stretch regression with no work around without code
changes
version: 1:6.12.2~dfsg-3
tags: patch, fixed-upstream, upstream

Hi.  In https://github.com/csound/csound/issues/1119
I reported an issue.

In stretch, if you want to deal with a file that doesn't match the
orchestra sample rate in diskgrain, you have to do all the work in your
orchestra.
Between stretch and buster upstream tried to improve it but got a couple
of things wrong:

* Most seriously, they handle the initial file seek according to the
  orchestra sr not the file sr.  So there will be a jump of
  uncontrollable length when the first file buffer is exausted.

* They scale the pitch but not the pointer read rate, so the orchestra
  still has to know about the gap.

This is fixed in f23c45efcef upstream.
I confirmed that code change works against the upstream code base and
the Debian code base.

I'd like to try and get an unblock to get this into buster.  I want your
support obviously before trying to do that.  I'm happy to do everything
(prepare a package; upload; file an unblock), simply write the unblock
justification, sit back and let you deal, or accept that you don't think
this is worth trying to get an unblock for.
My justification for the unblock is that it's a well-constrained change,
something that is possible in stretch is entirely impossible in the
current buster code, and there is an easy fix.

--Sam

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: csound
Source-Version: 1:6.12.2~dfsg-3.1

We believe that the bug you reported is fixed in the latest version of
csound, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 924260@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sam Hartman <hartmans@debian.org> (supplier of updated csound package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 21 Mar 2019 10:31:29 -0400
Source: csound
Architecture: source
Version: 1:6.12.2~dfsg-3.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Sam Hartman <hartmans@debian.org>
Closes: 924260
Changes:
 csound (1:6.12.2~dfsg-3.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Fix diskgrain, syncgrain and syncloop when sample rate of sample
     differs from orchestra, Closes: #924260
Checksums-Sha1:
 98c1a16b35cd1c671e6b8fe00dff2ad0eefd2051 2960 csound_6.12.2~dfsg-3.1.dsc
 1aa44fd509d61af7fde089717478726a94ccc918 26572 csound_6.12.2~dfsg-3.1.debian.tar.xz
Checksums-Sha256:
 6192efbb62f898134623538407e84779f4feebb42838e94079ac7c68391adee7 2960 csound_6.12.2~dfsg-3.1.dsc
 da320a673b29c3ff70ebd2d90301e161ed13b23a35ebfc1efe3182c4f3f9475b 26572 csound_6.12.2~dfsg-3.1.debian.tar.xz
Files:
 7f341fa48f77d3979705673a84e0414a 2960 sound optional csound_6.12.2~dfsg-3.1.dsc
 f88c2e08736258efe5951fa5ced853e7 26572 sound optional csound_6.12.2~dfsg-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE9Li3nMNy++OFgPTCQe7SUh/WssoFAlyVlFYACgkQQe7SUh/W
sson/AgAgaRBqw2RtQvVSBhjl2R2RkmHETqkqXM09qrNcY/NlTKtqgNFKp37geoP
c4CVgWTUd/J2A35OXR8vjaRXMNyj8N4+G0xuWL7L0J2GvodPsDa3GBzKg54JU9wj
iUDp5MIas2+m/MNXR4Q2YgSD/kuXGlbrtKz2xisKuroilpPMT6GtozYxrZgmslOl
pIZ0zgZv+aGph8LqiTrjOqCM28y0w5ltSgBMZS07hRVGDtp1NJ5a7ceRNNB1wuOg
UdDlzIW8O4z4nUzTC8+ZzBLFcbK1cMregqNOztk7ysny7Gzy+BGM0KOkyJ0nVuUH
X7qR3ohd/jJ+C+jlO6dc98R9M5CWSA==
=zkT2
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: