[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874220: marked as done (openni2 mustn't build with NEON on armel/armhf)



Your message dated Fri, 07 Dec 2018 20:45:17 +0000
with message-id <E1gVMzt-00068T-7A@fasolo.debian.org>
and subject line Bug#874220: fixed in openni2 2.2.0.33+dfsg-7+deb9u1
has caused the Debian Bug report #874220,
regarding openni2 mustn't build with NEON on armel/armhf
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
874220: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874220
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: openni2
Version: 2.2.0.33+dfsg-7
Severity: serious
Tags: patch
Control: affects -1 src:mrpt

NEON is not part of the armel and armhf architecture baselines,
it is therefore not permitted to use NEON unless proper runtime
detection is used.

NEON is also not available on the autobuilders.


openni2 trying to build with NEON on armel causes it to FTBFS:

https://buildd.debian.org/status/logs.php?pkg=openni2&arch=armel

...
In file included from Sensor/XnPacked11DepthProcessor.cpp:27:0:
/usr/lib/gcc/arm-linux-gnueabi/7/include/arm_neon.h:31:2: error: #error "NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softp or -mfloat-abi=hard"
 #error "NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softp or -mfloat-abi=hard"
  ^~~~~



I also strongly suspect that the FTBFS of mrpt on armhf might be
caused by this bug (test_mrpt_hwdrivers is linked with libOpenNI2):

https://buildd.debian.org/status/fetch.php?pkg=mrpt&arch=armhf&ver=1%3A1.5.3-1&stamp=1504457093&raw=0

...
cd /<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/tests && ./test_mrpt_hwdrivers
Illegal instruction



The "uname -m" usage in ThirdParty/PSCommon/BuildSystem/CommonDefs.mak
is wrong and also results in openni2 being built differently for i386
depending on whether a 32bit or 64bit kernel is used, but here I am
only addressing the ARM issues.

The fix contains of 3 parts:

1. In debian/patches/series, comment out
0006-rpi-Added-Armv6l-as-new-target-platform-and-created-missing-OniPlatformLinux-Arm.h-header.patch

This only made the uname bug above worse.


2. In debian/patches/0012-generic-linux.patch, fix a typo in
ThirdParty/PSCommon/BuildSystem/Platform.generic: FLAGS -> CFLAGS


3. Add the attached 0016-armel-armhf-no-neon.patch
Description: Use the generic platform for armel+armhf
 NEON is not part of the armel and armhf baselines.
Author: Adrian Bunk <bunk@debian.org>

--- openni2-2.2.0.33+dfsg.orig/ThirdParty/PSCommon/BuildSystem/CommonDefs.mak
+++ openni2-2.2.0.33+dfsg/ThirdParty/PSCommon/BuildSystem/CommonDefs.mak
@@ -16,8 +16,6 @@ else ifneq (,$(findstring i686,$(MACHINE
 	HOST_PLATFORM = x86
 else ifneq (,$(findstring i386,$(MACHINE)))
 	HOST_PLATFORM = x86
-else ifneq (,$(findstring arm,$(MACHINE)))
-	HOST_PLATFORM = Arm
 else
 	HOST_PLATFORM = generic
 endif

--- End Message ---
--- Begin Message ---
Source: openni2
Source-Version: 2.2.0.33+dfsg-7+deb9u1

We believe that the bug you reported is fixed in the latest version of
openni2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 874220@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adrian Bunk <bunk@debian.org> (supplier of updated openni2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 13 Mar 2018 17:52:24 +0200
Source: openni2
Binary: libopenni2-0 openni2-utils libopenni2-dev openni2-doc
Architecture: source
Version: 2.2.0.33+dfsg-7+deb9u1
Distribution: stretch
Urgency: medium
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Adrian Bunk <bunk@debian.org>
Description:
 libopenni2-0 - framework for sensor-based 'Natural Interaction'
 libopenni2-dev - headers for OpenNI 'Natural Interaction' frameworks
 openni2-doc - developer documentation for OpenNI frameworks
 openni2-utils - debug and test utilities OpenNI2 framework
Closes: 874220
Changes:
 openni2 (2.2.0.33+dfsg-7+deb9u1) stretch; urgency=medium
 .
   * Non-maintainer upload.
   * Fix armhf baseline violation and armel FTBFS caused by NEON usage.
     (Closes: #874220)
Checksums-Sha1:
 0a54372d150ad58d824097b74e635b17ac513fd7 2468 openni2_2.2.0.33+dfsg-7+deb9u1.dsc
 ff1a67dcf57c5bdc7c950e65aa2365dbdbfea8eb 16324 openni2_2.2.0.33+dfsg-7+deb9u1.debian.tar.xz
Checksums-Sha256:
 1c6c8986cf0204629167839398ae9eb6ab3b2cf9b64c6cb9abf0db765bb0f168 2468 openni2_2.2.0.33+dfsg-7+deb9u1.dsc
 b828b63ad1c8d955675cb042ca3d676d8434f1fe47ec220c7d0c149b48e91b27 16324 openni2_2.2.0.33+dfsg-7+deb9u1.debian.tar.xz
Files:
 a5f8cfdad7fc52cc18d68ec98b266f7e 2468 libs optional openni2_2.2.0.33+dfsg-7+deb9u1.dsc
 ba4a2596fb03d5940764b23f4d7b6c67 16324 libs optional openni2_2.2.0.33+dfsg-7+deb9u1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAlqoDb0ACgkQiNJCh6LY
mLH5IxAAjO1XSzUG51Qv0GCPviPYaR9FdbkG8pmQv4gXC2VIwvrWGZcJq9IxnI7p
0J4bW+iKOzr8eNrRfmNuJLmT/uqYkpdfEQin8PDeQxD6C8Hl8VVBC1Ed6xgkp0EW
LpD+SL2m7gQoVR6UForC810N5HUM04BOZ+4ZIOpi4cIbaob4JtMRLka7Jd2pp8Yz
XdWjqrg1Vo5+6vsph8GFZzX+48IdNsLO4Uee+kJPt+Mk8RIaqZB23d4uBBh1jGo7
QHNhDfJeFZ8ZZz0do/42Y1OMnzTKuQAcKAbt7GL48jKmkpJcEgPUOlY/ciPTPa8M
0eovznKCq4ih/FwiqxOvXeFH2Z/UYtt+NasBibvzlRx4/b2UKU8PjeXf51b7ibuX
UoqXrtMdpWwcUBaQ2jFeW4bRZ/sAJZSYyEXuq5PTqtDqSbrK58afxn89nnH3Jxdm
KLgme70lin0fzpnAivGV7o6c6Ehcx1ozTYm8u1ADqiyzTULo+khxGTytp9jqMxn2
JRxl1/m41qGJRHte/QTump6VIaB1nts+d14VfU+PCwfR/x3HRY8Hg0UeLnRlVnzP
weodj86OxV8hOxwjrdyfsPeO4so5NU8DGxx3eiEIcfXQzg5FoG/M5wE2M8GjyU5E
LqrTGAF17iG32JnWPoKVwgmz0WALAyGi9Az4IVKNGpbM9rrbOsg=
=Xk12
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: