[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#912347: marked as done (pdp FTCBFS: multiple reasons)

Your message dated Wed, 31 Oct 2018 09:57:15 +0000
with message-id <E1gHnFT-000BNn-2V@fasolo.debian.org>
and subject line Bug#912347: fixed in pdp 1:0.14.1+darcs20180201-2
has caused the Debian Bug report #912347,
regarding pdp FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
912347: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912347
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pdp
Version: 1:0.14.1+darcs20180201-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

pdp fails to cross build from source. The immediate failure is a
confusion of build and host architecture in debian/rules. Refer to man
dpkg-architecture for a description. Ultimately, it tries to pass -mmmx
to a mips64el compiler that wonders whether you maybe meant -mdmx. Then
the various Makefile subprojects don't receive cross toolchains. Using
dh_auto_build fixes that. The attached patch makes pdp cross buildable.
Please consider applying it.

Helmut

diff --minimal -Nru pdp-0.14.1+darcs20180201/debian/changelog pdp-0.14.1+darcs20180201/debian/changelog
--- pdp-0.14.1+darcs20180201/debian/changelog	2018-02-06 14:48:40.000000000 +0100
+++ pdp-0.14.1+darcs20180201/debian/changelog	2018-10-30 06:20:05.000000000 +0100
@@ -1,3 +1,12 @@
+pdp (1:0.14.1+darcs20180201-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Fix build/host confusion.
+    + Let dh_auto_build pass cross tools to make.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Tue, 30 Oct 2018 06:20:05 +0100
+
 pdp (1:0.14.1+darcs20180201-1) unstable; urgency=medium
 
   * New upstream version 0.14.1+darcs20180201
diff --minimal -Nru pdp-0.14.1+darcs20180201/debian/rules pdp-0.14.1+darcs20180201/debian/rules
--- pdp-0.14.1+darcs20180201/debian/rules	2018-02-06 14:48:40.000000000 +0100
+++ pdp-0.14.1+darcs20180201/debian/rules	2018-10-30 06:20:05.000000000 +0100
@@ -3,16 +3,11 @@
 export PDP_EXTRA_CFLAGS = -fPIC -Wno-error $(CPPFLAGS) $(CFLAGS)
 DPKG_EXPORT_BUILDFLAGS = 1
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
+include /usr/share/dpkg/architecture.mk
 include /usr/share/dpkg/buildflags.mk
 
 
-ifeq ($(DEB_BUILD_ARCH),i386)
-DEB_CONFIGURE_EXTRA_FLAGS = --enable-mmx
-DEB_EXTRA_CFLAGS = -mmmx
-BUILD_SCAF = yes
-endif
-
-ifeq ($(DEB_BUILD_ARCH),amd64)
+ifneq ($(filter amd64 i386,$(DEB_HOST_ARCH)),)
 DEB_CONFIGURE_EXTRA_FLAGS = --enable-mmx
 DEB_EXTRA_CFLAGS = -mmmx
 BUILD_SCAF = yes
@@ -29,17 +24,17 @@
 	dh_auto_configure -Dscaf -- $(DEB_CONFIGURE_EXTRA_FLAGS)
 
 override_dh_auto_build:
-	make pdp_all
-	make -C opengl \
+	dh_auto_build -- pdp_all
+	dh_auto_build --buildsystem=makefile --sourcedirectory=opengl -- \
 		LDFLAGS="$(LDFLAGS)" \
 		PDP_EXTRA_CFLAGS="$(CFLAGS) $(DEB_EXTRA_CFLAGS)" \
 		PDP_EXTRA_CPPFLAGS="$(CPPFLAGS)"
-	[ -z $(BUILD_SCAF) ] || \
-	make -C scaf \
+ifneq ($(BUILD_SCAF),)
+	dh_auto_build --sourcedirectory=scaf -- \
 		LDFLAGS="-fPIC $(LDFLAGS)" \
 		PDP_CFLAGS="$(CPPFLAGS) -fPIC $(CFLAGS)"
-	[ -z $(BUILD_SCAF) ] || \
 	cp scaf/rules/carules.scafo scaf/rules/default.scafo
+endif
 	docbook-to-man debian/pdp-config.sgml > pdp-config.1
 
 override_dh_auto_clean:

--- End Message ---
--- Begin Message --- 
Source: pdp
Source-Version: 1:0.14.1+darcs20180201-2

We believe that the bug you reported is fixed in the latest version of
pdp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 912347@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated pdp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 31 Oct 2018 09:49:53 +0100
Source: pdp
Binary: pd-pdp pd-3dp pd-scaf
Architecture: source
Version: 1:0.14.1+darcs20180201-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Description:
 pd-3dp     - openGL extensions for PDP
 pd-pdp     - Graphics system for Pd
 pd-scaf    - Simple Cellular Automaton Forth for PDP
Closes: 912347
Changes:
 pdp (1:0.14.1+darcs20180201-2) unstable; urgency=medium
 .
   * Fix FTCBFS (Closes: #912347)
     * Fix build/host confusion
     * Let dh_auto_build pass cross tools to make.
     Thanks to Helmut Grohne <helmut@subdivi.de>
   * Declare that "root" is not required for building this package
   * Bumped standards version to 4.2.1
Checksums-Sha1:
 a4fa8f71340b6aacac1ca5ddd10407cd1c48917c 2301 pdp_0.14.1+darcs20180201-2.dsc
 4101d0b4202ecc9170d08540d617731a725fb91c 17644 pdp_0.14.1+darcs20180201-2.debian.tar.xz
 e8db7d57d0389f0b9edbe52f8a7c9ee8e16db9bc 13135 pdp_0.14.1+darcs20180201-2_amd64.buildinfo
Checksums-Sha256:
 f882168cf8898c91d134a7fcaf03c029bf346347fc26dff356f93530a6cce885 2301 pdp_0.14.1+darcs20180201-2.dsc
 3ee08cc7e5d85e0c86a4400bcd1c0cfe82c1d0edc7e2d597c0875a3be355a627 17644 pdp_0.14.1+darcs20180201-2.debian.tar.xz
 f0b8f2ab0bf5ff1a19c4b5f8a27c0338aa5cb6ed4817f5884897e157889b2035 13135 pdp_0.14.1+darcs20180201-2_amd64.buildinfo
Files:
 7a344d128e4acb0b8b5bfa485ca97b0e 2301 graphics optional pdp_0.14.1+darcs20180201-2.dsc
 845183532bef25516bdb793262c2c7d7 17644 graphics optional pdp_0.14.1+darcs20180201-2.debian.tar.xz
 08058c35b5d98215f0b9ccc7c109a9d6 13135 graphics optional pdp_0.14.1+darcs20180201-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdAXnRVdICXNIABVttlAZxH96NvgFAlvZbUYACgkQtlAZxH96
Nvjw8Q//e2JhEb/40JElhEQ3OGGBDQ6fs/a9Ypn/fHVmq6i6i5NEHTRYo+UNkY9J
WcvSOhos7ENwRyX47MLrzOZ94y8ircfdiNul/Km3p6kW/9QyBwzW9abzBgNmvyhD
1d5ZaVNLlaL1tDTxCG3hKwpfhYsZJvxga5K4+KhHziOyJhTi0YJAufB+7/nErDoB
BZoea3i7E+Ea8jBU6HFcQ3eUQ2plfgDvYm6Qz4qVknAriaZrkiRdAUxpzHmwB0d7
clZZi+EU/34W0Y7h0PDPPXXHjfp5iUdmutcvXXzN1FdjqOBg8pL1i1Q7Yx5LlcM/
GeNmcJkZZs0/l9sYrfUHSHvz/K2kYZDNLogvncS9nRxe89TryAwgI5jf02pHr4VP
MfXGgD32Mjn0kEhNG3KGpBzH9NOPc6VTFYWi1g75H30Qr4/GrPeLsKFZiC2kbc+J
U16ToPk2Xs6ZIOBtyNe/qJn6LMmRmnZ5l2C5DSuLmf5LVx0CDkNuZjU1u/s6FfzD
gS+2zwu41ZPfGk8kgRPA2erW0dAqCy2mzXAvNSWo51p0/lf6oxS8GgRrCTfxbtEP
hqVCCVVEYt8lJ3Io64ISfB9mt8w0hCRmpTNcOWBvTnlHUTcSCNymvOjyYu/cE8u1
X44Xcs5Rs1Txyo88wvjoRC3IENIug4zNkk/Ltc7b7f2n/pQvWms=
=2zVg
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: