[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#901580: mpv: doesn't play well with upstream youtube-dl



Control: retitle -1 mpv: doesn't play well with upstream youtube-dl
Control: tags -1 moreinfo

Hi,

On 15/06/18 00:30, Witold Baryluk wrote:
> Package: mpv
> Version: 0.28.2-1
> Severity: normal
> 
> Hi.
> 
> I noticed that https://salsa.debian.org/multimedia-team/mpv/blob/debian/master/player/lua/ytdl_hook.lua
> is different than upstream ( https://github.com/mpv-player/mpv/blob/master/player/lua/ytdl_hook.lua#L511 ) .
> 
> My guess is that this is because it is made to work with what is provided
> in Debian repos for youtube-dl?

Debian ships mpv 0.28.2, but you are comparing it to upstream git master
so clearly it's going to be different. The Debian copy of ytdl_hook.lua
should be identical to the ytdl_hook.lua released with 0.28.2 - Debian
makes no changes to that file.

> I do have youtube-dl from git, and it is in my PATH.
> 
> 
> However mpv fails to correctly use it.
> 
> When I call mpv -v -v, I see command line to youtube-dl to execute:
> 
> [ytdl_hook] Running: youtube-dl --no-warnings -J --flat-playlist --sub-format ass/srt/best --no-playlist --format bestvideo+bestaudio/best --all-subs -- https://www.youtube.com/watch?v=tKemIJ0G1C8 
> [ytdl_hook] youtube-dl failed, trying to play URL directly ... 
> 
> and then mpv fails.
> 
> If I run youtube-dl literally as is from the debug output, I receive
> correct JSON output with URLs to video formats, etc. And exit status is
> 0. (via echo $?).
> 
> So some handling of subprocesses in Debian version of mpv ytdl_hook is
> not quiet right.

I tried installing upstream youtube-dl (the same version as you have)
and Debian's mpv seems to work fine with it, so I think it's a problem
with your setup.

Could you provide the full log of this command:
mpv -v -v --no-config https://www.youtube.com/watch?v=tKemIJ0G1C8

James

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: