[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909815: pd-readanysf FTBFS with puredata 0.49.0



Source: pd-readanysf
Version: 0.43-2
Severity: serious
Tags: ftbfs patch

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pd-readanysf.html

...
src/readanysf~.cpp: In function 'void m_open(t_readanysf*, t_symbol*)':
src/readanysf~.cpp:227:22: error: invalid conversion from 'const char*' to 'char*' [-fpermissive]
  x->rm->openFile( s->s_name, 0, x->num_frames_in_fifo, x->num_samples_per_frame );
                   ~~~^~~~~~
In file included from src/readanysf~.cpp:35:
src/ReadMedia.h:59:25: note:   initializing argument 1 of 'void ReadMedia::openFile(char*, int, int, int)'
   void openFile( char * filename, int vfifosize, int afifosize, int samples_per_frame);
                  ~~~~~~~^~~~~~~~
make[2]: *** [Makefile:54: pd_linux] Error 1


Fix is attached.
Description: The first parameter of ReadMedia::openFile() should be const
 Fixes FTBFS with puredata 0.49.0.
Author: Adrian Bunk <bunk@debian.org>

--- pd-readanysf-0.43.orig/src/ReadMedia.cpp
+++ pd-readanysf-0.43/src/ReadMedia.cpp
@@ -369,7 +369,7 @@ bool ReadMedia::quitAVThreads() {
 	return b;
 }
 
-void ReadMedia::openFile( char * fn, int vsize, int asize, int spf) {
+void ReadMedia::openFile(const char * fn, int vsize, int asize, int spf) {
 	lockState();
 	/*
 	if (  strcmp(m_filename, fn) == 0  && m_state == STATE_READY) {
--- pd-readanysf-0.43.orig/src/ReadMedia.h
+++ pd-readanysf-0.43/src/ReadMedia.h
@@ -56,7 +56,7 @@ class ReadMedia  {
 		ReadMedia();
 		~ReadMedia();
 
-		void openFile( char * filename, int vfifosize, int afifosize, int samples_per_frame);
+		void openFile(const char * filename, int vfifosize, int afifosize, int samples_per_frame);
 
 		int decodeAudio( gavl_audio_frame_t *af);
 		int decodeVideo( gavl_video_frame_t *vf);

Reply to: