[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#527942: marked as done (Keys stop working when a key is pressed out of the displayed piano)

Your message dated Thu, 10 Sep 2009 22:48:21 +0000
with message-id <E1MlsRB-00010f-Pm@ries.debian.org>
and subject line Bug#527942: fixed in vkeybd 1:0.1.18d-1
has caused the Debian Bug report #527942,
regarding Keys stop working when a key is pressed out of the displayed piano
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
527942: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=527942
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- Package: vkeybd
Version: 1:0.1.17b-2
Severity: important
Tags: patch

*** Please type your report below this line ***

If your keymap is designed for keys that are not displayed in the piano keyboard, pressing the corresponding keys of your computer keyboard will raise an error with the key note number. Moreover the same error keeps raising afterwards for any other key pressed because the unexpected key note number stays in the key stack. Error message looks like this:

----------------------------------------------------
can't read "keyitem(36)": no such element in array
can't read "keyitem(36)": no such element in array
    while executing
"$keywin itemconfigure $keyitem($key) -fill blue"
    (procedure "KeyStart" line 8)
    invoked from within
[…]
----------------------------------------------------

To get this message you may use the french layout on a 3 octaves piano:

$ vkeybd --keymap /usr/share/vkeybd/vkeybdmap-french

Then press the “!” key.

Using a “catch” instruction in both KeyStart and KeyStop procedures of the file “/usr/share/vkeybd/vkeybd.tcl” make it possible to avoid error raising whatever the key pressed and the piano octaves displayed. Here is the small patch:

--- /usr/share/vkeybd/vkeybd.tcl.orig    2009-05-08 22:09:03.000000000
+0200
+++ /usr/share/vkeybd/vkeybd.tcl    2009-05-08 22:21:58.000000000
+0200
@@ -170,10 +170,12 @@
 proc KeyStart {key button} {
     global keybase keywin keyitem keyvel activekey
     SeqOn
-    if {$button == 1} {
-    set activekey $keyitem($key)
+    catch {
+        if {$button == 1} {
+        set activekey $keyitem($key)
+        }
+        $keywin itemconfigure $keyitem($key) -fill blue
     }
-    $keywin itemconfigure $keyitem($key) -fill blue
     set key [expr $key + $keybase]
     SeqStartNote $key $keyvel
 }
@@ -181,11 +183,13 @@
 proc KeyStop {key button} {
     global keybase keywin keyitem keyindex keycolor activekey
     SeqOn
-    if {$button == 1 && $activekey != ""} {
-    set key $keyindex($activekey)
-    set activekey ""
+    catch {
+        if {$button == 1 && $activekey != ""} {
+        set key $keyindex($activekey)
+        set activekey ""
+        }
+        $keywin itemconfigure $keyitem($key) -fill $keycolor($key)
     }
-    $keywin itemconfigure $keyitem($key) -fill $keycolor($key)
     set key [expr $key + $keybase]
     SeqStopNote $key 0
 }

Regards,

JM. Philippe

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages vkeybd depends on:
ii  libasound2                    1.0.16-2   ALSA library
ii  libc6                         2.7-18     GNU C Library: Shared libraries
ii  libx11-6                      2:1.1.5-2  X11 client-side library
ii  tcl8.4                        8.4.19-2   Tcl (the Tool Command Language) v8
ii  tk8.4                         8.4.19-2   Tk toolkit for Tcl and X11, v8.4 -

vkeybd recommends no packages.

vkeybd suggests no packages.

-- no debconf information


--- End Message ---
--- Begin Message --- 
Source: vkeybd
Source-Version: 1:0.1.18d-1

We believe that the bug you reported is fixed in the latest version of
vkeybd, which is due to be installed in the Debian FTP archive:

vkeybd_0.1.18d-1.diff.gz
  to pool/main/v/vkeybd/vkeybd_0.1.18d-1.diff.gz
vkeybd_0.1.18d-1.dsc
  to pool/main/v/vkeybd/vkeybd_0.1.18d-1.dsc
vkeybd_0.1.18d-1_amd64.deb
  to pool/main/v/vkeybd/vkeybd_0.1.18d-1_amd64.deb
vkeybd_0.1.18d.orig.tar.gz
  to pool/main/v/vkeybd/vkeybd_0.1.18d.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 527942@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Free Ekanayaka <freee@debian.org> (supplier of updated vkeybd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 10 Sep 2009 23:04:59 +0200
Source: vkeybd
Binary: vkeybd
Architecture: source amd64
Version: 1:0.1.18d-1
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Team <debian-multimedia@lists.debian.org>
Changed-By: Free Ekanayaka <freee@debian.org>
Description: 
 vkeybd     - Virtual MIDI Keyboard
Closes: 527942 527943 543680
Changes: 
 vkeybd (1:0.1.18d-1) unstable; urgency=low
 .
   * New upstream version, thanks to Jean-Michel Philippe (Closes: #527942, #527943)
   * Fix broken watch file, thanks to Arnout Engelen (Closes: #543680)
Checksums-Sha1: 
 dbcf632ca12fbf52309c540506d269f58c540f19 1084 vkeybd_0.1.18d-1.dsc
 753c48c6b2f52dc9eb47bbf254b8e3a1a370c0e1 40643 vkeybd_0.1.18d.orig.tar.gz
 4d6df8da5e32f262ea4e75b7773869e73eef19d1 8218 vkeybd_0.1.18d-1.diff.gz
 05ea0b214d2a112706a20f3598ab86f806f3241d 32874 vkeybd_0.1.18d-1_amd64.deb
Checksums-Sha256: 
 bd5bf1a71d1a8b6f428ed677e573b85486a94df5ced7bba22c8fb6998754f731 1084 vkeybd_0.1.18d-1.dsc
 d220563add32356f61feb7efd87b29ae7b0c294ff84d4a7f4d70b52af650f073 40643 vkeybd_0.1.18d.orig.tar.gz
 eb5bc24693e72638aaf1eb861d165e158ad8bccce8de7bec32b2453c536c79bf 8218 vkeybd_0.1.18d-1.diff.gz
 6151255f14b396b7205994c27e4739364ba7067e857bcbd4df050f06180e9d47 32874 vkeybd_0.1.18d-1_amd64.deb
Files: 
 ee8dd7c3362ee5c303b8337cd2830420 1084 sound optional vkeybd_0.1.18d-1.dsc
 0945f968c30125ea870df696c8cf8802 40643 sound optional vkeybd_0.1.18d.orig.tar.gz
 0008ef263e1559187e3f4559618bd140 8218 sound optional vkeybd_0.1.18d-1.diff.gz
 810b89815dfbe63b0cd3484b9ce6d03e 32874 sound optional vkeybd_0.1.18d-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqpbakACgkQcanJGlcVnlnlPwCfXo3biXr/kbFvXVUmAUtw9TmS
et8AnikMO7WmuHd63QxvV4jS5UMNTd0f
=9iwj
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: