[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#430961: libjack sets rpath for amd64



On Sun, Mar 09, 2008 at 12:51:47PM +0900, Junichi Uekawa wrote:
> Hi,
> 
> > > Package: libjack-dev
> > > Version: 0.103.0-6
> > > Severity: serious
> > > 
> > > /usr/lib64 is not used in Debian, and this enters each .la file, which
> > > in turn results in rpath being set in resulting binaries, please fix
> > > it, rather than using chrpath to work around it.
> > 
> > Hi,
> > 
> > Do you plan to upload a fix for this soon?
> > Do you mind if I NMU this?
> 
> I'd say go ahead

I've uploaded it with the attached diff.


Kurt

diff -u jack-audio-connection-kit-0.109.2/debian/rules jack-audio-connection-kit-0.109.2/debian/rules
--- jack-audio-connection-kit-0.109.2/debian/rules
+++ jack-audio-connection-kit-0.109.2/debian/rules
@@ -65,20 +65,10 @@
 # ensure jackstart can be root.audio 4754
 DEB_FIXPERMS_EXCLUDE := jackstart
 
-install/jackd::
-ifneq (,$(shell echo x86_64 mips64 ppc64 sparc64 s390x | grep $(DEB_HOST_GNU_CPU)))
-	ln -s lib64 debian/tmp/usr/lib
-endif
-
 # after the directories are created but before dh_compress is run.
 common-binary-post-install-arch::
 	ln -s jack debian/libjack0/usr/lib/libjack0.100.0
 	ln -s libjack.so.0 debian/libjack0/usr/lib/libjack-0.100.0.so.0
-
-	for i in debian/jackd/usr/bin/*; do \
-		chrpath -d $$i; \
-	done
-
 	dh_buildinfo
 
 binary-predeb/jackd::
diff -u jack-audio-connection-kit-0.109.2/debian/changelog jack-audio-connection-kit-0.109.2/debian/changelog
--- jack-audio-connection-kit-0.109.2/debian/changelog
+++ jack-audio-connection-kit-0.109.2/debian/changelog
@@ -1,3 +1,14 @@
+jack-audio-connection-kit (0.109.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Don't use lib64 and so avoid setting the rpath in other packages
+    (Closes: #430961)
+  * Don't create a debian/tmp/usr/lib/lib64 that points to itself.
+  * There is no need to remove rpath's from binaries anymore so
+    drop the build dependency on chrpath.
+
+ -- Kurt Roeckx <kurt@roeckx.be>  Sat, 15 Mar 2008 11:49:05 +0000
+
 jack-audio-connection-kit (0.109.2-1) unstable; urgency=low
 
   * New upstream release
diff -u jack-audio-connection-kit-0.109.2/debian/control jack-audio-connection-kit-0.109.2/debian/control
--- jack-audio-connection-kit-0.109.2/debian/control
+++ jack-audio-connection-kit-0.109.2/debian/control
@@ -7,7 +7,7 @@
  libasound2-dev [i386 ia64 alpha amd64 armeb arm hppa m32r m68k mips mipsel powerpc ppc64 s390 s390x sh3 sh3eb sh4 sh4eb sparc], libsndfile1-dev, doxygen, 
  libcap-dev [i386 ia64 alpha amd64 armeb arm hppa m32r m68k mips mipsel powerpc ppc64 s390 s390x sh3 sh3eb sh4 sh4eb sparc], autotools-dev, libreadline5-dev,
  libraw1394-dev [i386 ia64 alpha amd64 armeb arm hppa m32r m68k mips mipsel powerpc ppc64 s390 s390x sh3 sh3eb sh4 sh4eb sparc], 
- libfreebob0-dev [i386 ia64 alpha amd64 armeb arm hppa m32r m68k mips mipsel powerpc ppc64 s390 s390x sh3 sh3eb sh4 sh4eb sparc], chrpath
+ libfreebob0-dev [i386 ia64 alpha amd64 armeb arm hppa m32r m68k mips mipsel powerpc ppc64 s390 s390x sh3 sh3eb sh4 sh4eb sparc]
 Build-Conflicts: libcap2-dev
 Standards-Version: 3.7.2
 
only in patch2:
unchanged:
--- jack-audio-connection-kit-0.109.2.orig/debian/patches/10_debian_lib64.patch
+++ jack-audio-connection-kit-0.109.2/debian/patches/10_debian_lib64.patch
@@ -0,0 +1,46 @@
+--- configure.orig	2008-03-15 11:46:49.000000000 +0000
++++ configure	2008-03-15 11:47:28.000000000 +0000
+@@ -19829,19 +19829,8 @@
+ 
+ #
+ # We need to establish suitable defaults for a 64-bit OS
++# But we don't use /usr/lib64 in Debian
+ libnn=lib
+-case "${host_os}" in
+-    linux*)
+-    case "${host_cpu}" in
+-	x86_64|mips64|ppc64|sparc64|s390x)
+-        libnn=lib64
+-	;;
+-    esac
+-    ;;
+-    solaris*)
+-    ## libnn=lib/sparcv9 ## on 64-bit only, but that's compiler-specific
+-    ;;
+-esac
+ 
+ ## take care not to  override the command-line setting
+ if test "${libdir}" = '${exec_prefix}/lib'; then
+--- configure.ac.orig	2008-03-15 11:46:41.000000000 +0000
++++ configure.ac	2008-03-15 11:47:21.000000000 +0000
+@@ -102,19 +102,8 @@
+ 
+ #
+ # We need to establish suitable defaults for a 64-bit OS
++# But we don't use /usr/lib64 in Debian
+ libnn=lib
+-case "${host_os}" in
+-    linux*)
+-    case "${host_cpu}" in
+-	x86_64|mips64|ppc64|sparc64|s390x)
+-        libnn=lib64
+-	;;
+-    esac
+-    ;;
+-    solaris*)
+-    ## libnn=lib/sparcv9 ## on 64-bit only, but that's compiler-specific
+-    ;;  
+-esac
+ 
+ ## take care not to  override the command-line setting
+ if test "${libdir}" = '${exec_prefix}/lib'; then

Reply to: