Bug#508114: jack-a-c-k: Patch not a total fix
On Sun, 14 Dec 2008, Asheesh Laroia wrote:
On Sat, 13 Dec 2008, Sebastian Andrzej Siewior wrote:
So you should check for one of them IMHO. So in that case I was in the
wrong line an passing va_list to next function is valid (I was wondering
here a little...).
Got it. So this patch fixes the FTBFS on alpha.
Now that it compiles, the semantics are the same on any architecture.
Upstream seems slow to answer if the patch is good
Upstream committed this patch:
<torbenh3> 20:47 droncho New news from jacktimeline: Changeset [3205]:
Fix alpha compilation error. Debian Bug #508114.
So that's that! I'm attaching an NMU-style debdiff as a proposal for what
should go into Lenny. This way you have a ready-made changelog entry to
use if you like.
-- Asheesh.
--
Go to a movie tonight. Darkness becomes you.
diff -urN jack-audio-connection-kit-0.115.6.orig/debian/changelog jack-audio-connection-kit-0.115.6/debian/changelog
--- jack-audio-connection-kit-0.115.6.orig/debian/changelog 2008-12-14 12:07:19.000000000 -0800
+++ jack-audio-connection-kit-0.115.6/debian/changelog 2008-12-14 12:13:23.000000000 -0800
@@ -1,3 +1,12 @@
+jack-audio-connection-kit (0.115.6-1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Add patch to fix alpha build failure by using var args correctly
+ (earlier versions of Jack improperly passed the va_list around).
+ The issue is fixed in upstream svn r3205. (Closes: #508114)
+
+ -- Asheesh Laroia <asheesh@asheesh.org> Sun, 14 Dec 2008 12:09:16 -0800
+
jack-audio-connection-kit (0.115.6-1) unstable; urgency=low
* New Upstream Version
diff -urN jack-audio-connection-kit-0.115.6.orig/libjack/client.c jack-audio-connection-kit-0.115.6/libjack/client.c
--- jack-audio-connection-kit-0.115.6.orig/libjack/client.c 2008-11-23 06:27:20.000000000 -0800
+++ jack-audio-connection-kit-0.115.6/libjack/client.c 2008-12-14 12:09:11.000000000 -0800
@@ -969,7 +969,7 @@
}
/* parse variable arguments */
- if (ap)
+ if (options & (JackServerName | JackLoadName | JackLoadInit))
jack_varargs_parse(options, ap, &va);
else
jack_varargs_init(&va);
@@ -1117,7 +1117,7 @@
jack_options_t options = JackUseExactName;
if (getenv("JACK_START_SERVER") == NULL)
options |= JackNoStartServer;
- return jack_client_open_aux (client_name, options, NULL, NULL);
+ return jack_client_open (client_name, options, NULL);
}
char *
Reply to: