[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#508114: jack-a-c-k: Patch not a total fix



On Sat, 13 Dec 2008, Sebastian Andrzej Siewior wrote:

* Asheesh Laroia | 2008-12-13 06:59:46 [-0800]:

Hi.
Hello,

Is it adequate, do you think, to test if &ap == NULL?  I am falling asleep
so take it as a senseless suggestion.
This is not what you want. You should not access va_list directly, you
have to use helpers like va_{start|end|arg|copy} to deal with them.
The code looks to me like the option variable can be ored with
"JackServerName JackLoadName JackLoadInit" to indicate what is in
va_list. Same like %s printf for instance.

Ah-hah, got it.

So you should check for one of them IMHO. So in that case I was in the wrong line an passing va_list to next function is valid (I was wondering here a little...).

Please find attached an updated patch.

The updated patch *alone* does fix the compile failure on Alpha, with no other changes.

-- Asheesh.

--
< doogie> asuffield: how do you think dpkg was originally written?  :|
< asuffield> by letting iwj get dangerously near a computer
		-- in #debian-devel



Reply to: